]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-14935 Display banner for project only
authorPhilippe Perrin <philippe.perrin@sonarsource.com>
Thu, 24 Jun 2021 12:44:44 +0000 (14:44 +0200)
committersonartech <sonartech@sonarsource.com>
Thu, 24 Jun 2021 20:03:29 +0000 (20:03 +0000)
server/sonar-web/src/main/js/apps/overview/branches/FirstAnalysisNextStepsNotif.tsx
server/sonar-web/src/main/js/apps/overview/branches/__tests__/FirstAnalysisNextStepsNotif-test.tsx

index c345eba2247dd73f4a7f57d74b6dec263b90fbb6..2db27f088b2a07c23592f84a4ed887ad397055c8 100644 (file)
@@ -25,6 +25,7 @@ import { withCurrentUser } from '../../../components/hoc/withCurrentUser';
 import DismissableAlert from '../../../components/ui/DismissableAlert';
 import { isLoggedIn } from '../../../helpers/users';
 import { ProjectAlmBindingResponse } from '../../../types/alm-settings';
+import { ComponentQualifier } from '../../../types/component';
 import { PULL_REQUEST_DECORATION_BINDING_CATEGORY } from '../../settings/components/AdditionalCategoryKeys';
 
 export interface FirstAnalysisNextStepsNotifProps {
@@ -44,7 +45,7 @@ export function FirstAnalysisNextStepsNotif(props: FirstAnalysisNextStepsNotifPr
     projectBinding
   } = props;
 
-  if (!isLoggedIn(currentUser)) {
+  if (!isLoggedIn(currentUser) || component.qualifier !== ComponentQualifier.Project) {
     return null;
   }
 
index 21494366a5505878e12a669d1898f15483053bae..b7a1c2a1cb12226d4590a58df3d4cb9e93231bbf 100644 (file)
@@ -22,6 +22,7 @@ import { shallow } from 'enzyme';
 import * as React from 'react';
 import { mockProjectAlmBindingResponse } from '../../../../helpers/mocks/alm-settings';
 import { mockComponent, mockCurrentUser, mockLoggedInUser } from '../../../../helpers/testMocks';
+import { ComponentQualifier } from '../../../../types/component';
 import {
   FirstAnalysisNextStepsNotif,
   FirstAnalysisNextStepsNotifProps
@@ -29,6 +30,11 @@ import {
 
 it('should render correctly', () => {
   expect(shallowRender({ currentUser: mockCurrentUser() }).type()).toBeNull();
+  expect(
+    shallowRender({
+      component: mockComponent({ qualifier: ComponentQualifier.Application })
+    }).type()
+  ).toBeNull();
   expect(shallowRender({ detectedCIOnLastAnalysis: false })).toMatchSnapshot(
     'show prompt to configure CI'
   );