Remove check for negative length (#5120)

diff --git a/models/issue_label.go b/models/issue_label.go
index ab6c4731eee75f599231b16e991b0e457cc4f18f..bf61fcaeca3b106ebd6e8cbea2a5d1fe5c1c8673 100644 (file)
--- a/models/issue_label.go
+++ b/models/issue_label.go
@@ -134,7 +134,7 @@ func NewLabels(labels ...*Label) error {
 // If pass repoID as 0, then ORM will ignore limitation of repository
 // and can return arbitrary label with any valid ID.
 func getLabelInRepoByName(e Engine, repoID int64, labelName string) (*Label, error) {
-       if len(labelName) <= 0 {
+       if len(labelName) == 0 {
                return nil, ErrLabelNotExist{0, repoID}
        }
 

diff --git a/models/org.go b/models/org.go
index 1cc25231e61a5f65ab4509d653dbf840bb869d14..c0a4172dc5209129271a3825fef4bfb6f0801ca8 100644 (file)
--- a/models/org.go
+++ b/models/org.go
@@ -677,7 +677,7 @@ func (env *accessibleReposEnv) Repos(page, pageSize int) ([]*Repository, error)
        }
 
        repos := make([]*Repository, 0, len(repoIDs))
-       if len(repoIDs) <= 0 {
+       if len(repoIDs) == 0 {
                return repos, nil
        }
 
@@ -705,7 +705,7 @@ func (env *accessibleReposEnv) MirrorRepos() ([]*Repository, error) {
        }
 
        repos := make([]*Repository, 0, len(repoIDs))
-       if len(repoIDs) <= 0 {
+       if len(repoIDs) == 0 {
                return repos, nil
        }
 

diff --git a/models/ssh_key.go b/models/ssh_key.go
index c2836e6885dd26a00d723c053eee935f3ebb1cfe..2592209b4d7a351b8b2cddb0174cb83ab87dc050 100644 (file)
--- a/models/ssh_key.go
+++ b/models/ssh_key.go
@@ -376,7 +376,7 @@ func calcFingerprint(publicKeyContent string) (string, error) {
 }
 
 func addKey(e Engine, key *PublicKey) (err error) {
-       if len(key.Fingerprint) <= 0 {
+       if len(key.Fingerprint) == 0 {
                key.Fingerprint, err = calcFingerprint(key.Content)
                if err != nil {
                        return err

diff --git a/modules/auth/auth.go b/modules/auth/auth.go
index 8391e7de8f9065365c1de2d171f85c6993f45493..0d703084da0a41814bae78c07e57727dda7b33ec 100644 (file)
--- a/modules/auth/auth.go
+++ b/modules/auth/auth.go
@@ -36,7 +36,7 @@ func SignedInID(ctx *macaron.Context, sess session.Store) int64 {
        // Check access token.
        if IsAPIPath(ctx.Req.URL.Path) {
                tokenSHA := ctx.Query("token")
-               if len(tokenSHA) <= 0 {
+               if len(tokenSHA) == 0 {
                        tokenSHA = ctx.Query("access_token")
                }
                if len(tokenSHA) == 0 {

diff --git a/modules/user/user_test.go b/modules/user/user_test.go
index 51f10dbbd23edaa91e898bfb0a809841012b0219..ae7460281fc035beb05274c4131c2e6363693a7d 100644 (file)
--- a/modules/user/user_test.go
+++ b/modules/user/user_test.go
@@ -18,7 +18,7 @@ func getWhoamiOutput() (string, error) {
 
 func TestCurrentUsername(t *testing.T) {
        user := CurrentUsername()
-       if len(user) <= 0 {
+       if len(user) == 0 {
                t.Errorf("expected non-empty user, got: %s", user)
        }
        // Windows whoami is weird, so just skip remaining tests

diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
index 23a85759c2f5f945fa6b61590ad7d06ad2baddc5..3a539f6ce78467a91a8e36b5dc1a3c654940cbdc 100644 (file)
--- a/routers/api/v1/api.go
+++ b/routers/api/v1/api.go
@@ -80,7 +80,7 @@ import (
 func sudo() macaron.Handler {
        return func(ctx *context.APIContext) {
                sudo := ctx.Query("sudo")
-               if len(sudo) <= 0 {
+               if len(sudo) == 0 {
                        sudo = ctx.Req.Header.Get("Sudo")
                }
 

diff --git a/routers/user/home.go b/routers/user/home.go
index 0c84b2498e0136b32cbbe6108f4fea366b25a865..cbab5c835036b25d687651a70a3c713db43af0e8 100644 (file)
--- a/routers/user/home.go
+++ b/routers/user/home.go
@@ -213,7 +213,7 @@ func Issues(ctx *context.Context) {
                        return
                }
        }
-       if len(userRepoIDs) <= 0 {
+       if len(userRepoIDs) == 0 {
                userRepoIDs = []int64{-1}
        }