]> source.dussan.org Git - poi.git/commitdiff
Try to fix compiling on some CI-runs to support all active types of JDKs
authorDominik Stadler <centic@apache.org>
Fri, 14 May 2021 08:20:45 +0000 (08:20 +0000)
committerDominik Stadler <centic@apache.org>
Fri, 14 May 2021 08:20:45 +0000 (08:20 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889885 13f79535-47bb-0310-9956-ffa450edef68

poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java
poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java
poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java

index 74df887a504b928ca4eeef46c2fe095701e4fd19..92cbd37ef24e52546c295cfcee55bef6fcda47d0 100644 (file)
@@ -58,8 +58,8 @@ public final class TestDeferredSXSSFWorkbook extends BaseTestXWorkbook {
      */
     @Override
     @Test
-    protected void cloneSheet() throws IOException {
-        RuntimeException e = assertThrows(RuntimeException.class, () -> super.cloneSheet());
+    public void cloneSheet() throws IOException {
+        RuntimeException e = assertThrows(RuntimeException.class, super::cloneSheet);
         assertEquals("Not Implemented", e.getMessage());
     }
 
@@ -68,8 +68,8 @@ public final class TestDeferredSXSSFWorkbook extends BaseTestXWorkbook {
      */
     @Override
     @Test
-    protected void sheetClone() throws IOException {
-        RuntimeException e = assertThrows(RuntimeException.class, () -> super.sheetClone());
+    public void sheetClone() {
+        RuntimeException e = assertThrows(RuntimeException.class, super::sheetClone);
         assertEquals("Not Implemented", e.getMessage());
     }
 
index 17c4eec07447a3d43d0389ac96c4b8f7ed53aadf..88bf9b417d759d2c3481e533179004f5d287f7d4 100644 (file)
@@ -72,7 +72,7 @@ public final class TestSXSSFWorkbook extends BaseTestXWorkbook {
      */
     @Override
     @Test
-    protected void cloneSheet() throws IOException {
+    public void cloneSheet() throws IOException {
         RuntimeException e = assertThrows(RuntimeException.class, super::cloneSheet);
         assertEquals("Not Implemented", e.getMessage());
     }
@@ -82,7 +82,7 @@ public final class TestSXSSFWorkbook extends BaseTestXWorkbook {
      */
     @Override
     @Test
-    protected void sheetClone() {
+    public void sheetClone() {
         RuntimeException e = assertThrows(RuntimeException.class, super::sheetClone);
         assertEquals("Not Implemented", e.getMessage());
     }
@@ -358,6 +358,7 @@ public final class TestSXSSFWorkbook extends BaseTestXWorkbook {
 
     @Disabled("Crashes the JVM because of documented JVM behavior with concurrent writing/reading of zip-files, "
             + "see http://www.oracle.com/technetwork/java/javase/documentation/overview-156328.html")
+       @Test
     void bug53515a() throws Exception {
         File out = new File("Test.xlsx");
         assertTrue(!out.exists() || out.delete());
@@ -528,6 +529,7 @@ public final class TestSXSSFWorkbook extends BaseTestXWorkbook {
     }
 
     @Disabled("not implemented")
+       @Test
     void changeSheetNameWithSharedFormulas() {
     }
 }
index a38ec3448f4f4a7c96bc4881dda0c3ac37b36756..b70ea3402bdfa705736b7b1ca511d06363c44c2f 100644 (file)
@@ -441,7 +441,7 @@ public abstract class BaseTestWorkbook {
     }
 
     @Test
-    protected void cloneSheet() throws IOException {
+    public void cloneSheet() throws IOException {
         try (Workbook book = _testDataProvider.createWorkbook()) {
             Sheet sheet = book.createSheet("TEST");
             sheet.createRow(0).createCell(0).setCellValue("Test");
@@ -804,7 +804,7 @@ public abstract class BaseTestWorkbook {
     }
 
     @Test
-    protected void sheetClone() throws IOException {
+    public void sheetClone() throws IOException {
         // First up, try a simple file
         try (Workbook b = _testDataProvider.createWorkbook();
              Workbook bBack = HSSFTestDataSamples.openSampleWorkbook("SheetWithDrawing.xls")) {