Migrations should not fail for comment reactions (#13352)

An extension to #13444 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton <art27@cantab.net>

diff --git a/modules/migrations/gitea_downloader.go b/modules/migrations/gitea_downloader.go
index e30c92a2fc5939bffedebfc708ed7aaf5da132f1..0509c708bff5cad302bfff71d5008fdc3aefd3ad 100644 (file)
--- a/modules/migrations/gitea_downloader.go
+++ b/modules/migrations/gitea_downloader.go
@@ -457,7 +457,11 @@ func (g *GiteaDownloader) GetComments(index int64) ([]*base.Comment, error) {
        for _, comment := range comments {
                reactions, err := g.getCommentReactions(comment.ID)
                if err != nil {
-                       return nil, fmt.Errorf("error while listing reactions for comment %d in issue #%d. Error: %v", comment.ID, index, err)
+                       log.Warn("Unable to load comment reactions during migrating issue #%d for comment %d to %s/%s. Error: %v", index, comment.ID, g.repoOwner, g.repoName, err)
+                       if err2 := models.CreateRepositoryNotice(
+                               fmt.Sprintf("Unable to load reactions during migrating issue #%d for comment %d to %s/%s. Error: %v", index, comment.ID, g.repoOwner, g.repoName, err)); err2 != nil {
+                               log.Error("create repository notice failed: ", err2)
+                       }
                }
 
                allComments = append(allComments, &base.Comment{