Chunk if you have too many contacts

diff --git a/apps/dav/lib/CardDAV/CardDavBackend.php b/apps/dav/lib/CardDAV/CardDavBackend.php
index f8552f1323e113cdafc20382de0c1bad01f257e4..ac0b5849f8a12c608462f87a751397051e669942 100644 (file)
--- a/apps/dav/lib/CardDAV/CardDavBackend.php
+++ b/apps/dav/lib/CardDAV/CardDavBackend.php
@@ -439,23 +439,29 @@ class CardDavBackend implements BackendInterface, SyncSupport {
         * @return array
         */
        function getMultipleCards($addressBookId, array $uris) {
+               if (empty($uris)) {
+                       return [];
+               }
+
+               $chunks = array_chunk($uris, 100);
+               $cards = [];
+
                $query = $this->db->getQueryBuilder();
                $query->select(['id', 'uri', 'lastmodified', 'etag', 'size', 'carddata'])
                        ->from('cards')
                        ->where($query->expr()->eq('addressbookid', $query->createNamedParameter($addressBookId)))
-                       ->andWhere($query->expr()->in('uri', $query->createParameter('uri')))
-                       ->setParameter('uri', $uris, IQueryBuilder::PARAM_STR_ARRAY);
+                       ->andWhere($query->expr()->in('uri', $query->createParameter('uri')));
 
-               $cards = [];
+               foreach ($chunks as $uris) {
+                       $query->setParameter('uri', $uris, IQueryBuilder::PARAM_STR_ARRAY);
+                       $result = $query->execute();
 
-               $result = $query->execute();
-               while($row = $result->fetch()) {
-                       $row['etag'] = '"' . $row['etag'] . '"';
-                       $row['carddata'] = $this->readBlob($row['carddata']);
-                       $cards[] = $row;
+                       while($row = $result->fetch()) {
+                               $row['etag'] = '"' . $row['etag'] . '"';
+                               $row['carddata'] = $this->readBlob($row['carddata']);
+                               $cards[] = $row;
+                       }
                }
-               $result->closeCursor();
-
                return $cards;
        }