cleanuup, updated status for line height

git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@195090 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/org/apache/fop/area/LineArea.java b/src/org/apache/fop/area/LineArea.java
index 0ba001f5e559ddcb3429bbd1e3787966b6aa64a1..fc7771da0e85798c30520012ab1b57daf861c78a 100644 (file)
--- a/src/org/apache/fop/area/LineArea.java
+++ b/src/org/apache/fop/area/LineArea.java
@@ -8,8 +8,6 @@
 package org.apache.fop.area;
 
 import org.apache.fop.area.inline.InlineArea;
-import org.apache.fop.layoutmgr.LayoutInfo;
-import org.apache.fop.fo.properties.VerticalAlign;
 
 import java.util.ArrayList;
 import java.util.List;

diff --git a/src/org/apache/fop/area/inline/InlineArea.java b/src/org/apache/fop/area/inline/InlineArea.java
index 2278806d581ea36cd207cbd133dae98f13bbbb68..98a8fc992c2d605d703704593c9715f6f90ea84a 100644 (file)
--- a/src/org/apache/fop/area/inline/InlineArea.java
+++ b/src/org/apache/fop/area/inline/InlineArea.java
@@ -13,8 +13,6 @@ import org.apache.fop.area.Trait;
 import org.apache.fop.render.Renderer;
 import org.apache.fop.traits.BorderProps;
 
-import org.apache.fop.layoutmgr.LayoutInfo;
-
 import java.util.List;
 import java.util.ArrayList;
 

diff --git a/src/org/apache/fop/fo/flow/ExternalGraphic.java b/src/org/apache/fop/fo/flow/ExternalGraphic.java
index bef021138c6a0ac89625728d7f9cfcdfad99b6eb..6f18214d1cf9d1e85f84134e9bf31fcc49dd71ee 100644 (file)
--- a/src/org/apache/fop/fo/flow/ExternalGraphic.java
+++ b/src/org/apache/fop/fo/flow/ExternalGraphic.java
@@ -16,7 +16,6 @@ import org.apache.fop.image.*;
 import org.apache.fop.area.inline.InlineArea;
 import org.apache.fop.layoutmgr.LayoutManager;
 import org.apache.fop.layoutmgr.LeafNodeLayoutManager;
-import org.apache.fop.layoutmgr.LayoutInfo;
 import org.apache.fop.area.inline.Image;
 import org.apache.fop.area.inline.Viewport;
 import org.apache.fop.datatypes.*;

diff --git a/src/org/apache/fop/fo/flow/InstreamForeignObject.java b/src/org/apache/fop/fo/flow/InstreamForeignObject.java
index 47a50453d36cafaad321f7d199dff8fe4ec78048..e6da7233ca6ed90e651f5861efe9f058cb5bd16c 100644 (file)
--- a/src/org/apache/fop/fo/flow/InstreamForeignObject.java
+++ b/src/org/apache/fop/fo/flow/InstreamForeignObject.java
@@ -25,7 +25,6 @@ import org.apache.fop.layout.RelativePositionProps;
 import org.apache.fop.apps.FOPException;
 import org.apache.fop.layoutmgr.LayoutManager;
 import org.apache.fop.layoutmgr.LeafNodeLayoutManager;
-import org.apache.fop.layoutmgr.LayoutInfo;
 
 import org.w3c.dom.Document;
 

diff --git a/src/org/apache/fop/layoutmgr/LineBPLayoutManager.java b/src/org/apache/fop/layoutmgr/LineBPLayoutManager.java
index eebec252918efa8fb7d8b57b63e05a83015b9f7a..337980d2ce6fd29ed5bc2954aa4e2c60fe9c2ed2 100644 (file)
--- a/src/org/apache/fop/layoutmgr/LineBPLayoutManager.java
+++ b/src/org/apache/fop/layoutmgr/LineBPLayoutManager.java
@@ -456,10 +456,6 @@ public class LineBPLayoutManager extends InlineStackingBPLayoutManager {
         BreakPoss curLineBP = new BreakPoss( new LineBreakPosition(this,
                                              m_vecInlineBreaks.size() - 1, dAdjust, lineLead + middlefollow, lineLead));
 
-        /* FIX ME!!
-         * Need to calculate line height based on all inline BP info
-         * for this line not just the current inlineBP!
-         */
         curLineBP.setFlag(BreakPoss.ISLAST, isFinished());
         curLineBP.setStackingSize(new MinOptMax(lineLead + middlefollow));
         return curLineBP;

diff --git a/status.xml b/status.xml
index df9984fe85ead375b600b6ed13c11fbba90878aa..611d0ae06d07055ce35b0ecbd222de286d64bd96 100644 (file)
--- a/status.xml
+++ b/status.xml
@@ -68,11 +68,6 @@ inactive??
       When doing the static areas the markers wil need to be available for
       retrieving. The marker can then be layed out as normal.
     </action>
-    <action context="code" dev="open">
-      Calculate line height.
-      The line height needs to be calculated while finding breaks. This needs
-      to include all the alignment and height details of the inline areas.
-    </action>
     <action context="code" dev="open">
       implement the caching mechanism to store pages
       when a page contains a forward reference that has not been
@@ -126,6 +121,11 @@ inactive??
 
   <changes>
    <release version="?" date="2002">
+    <action dev="KLL" type="update" context="code">
+      Calculate line height.
+      The line height is calculated while finding breaks.
+      Improved alignment to use the breaks and context.
+    </action>
     <action dev="KLL" type="update" context="code">
       Updated batik with change to TextPainter interface and UserAgent.
       Improved PDFTextPainter to handle more types of text.
@@ -283,6 +283,10 @@ inactive??
     <action dev="KL" type="add" context="code">
       New layout system using layout managers
     </action>
+    <action dev="KL" type="add" context="code">
+      Implemented handlers for whitespace handling that collapse whitespace
+      better in various places
+    </action>
     <action dev="KLL" type="update" context="code">
      Changed area tree xml format to match the area tree hierarchy
     </action>