Trigger onclick handlers of links

diff --git a/src/event.js b/src/event.js
index 927beda4eb59452fd819c077d83942bc4da2016c..d0cacf6b582b174cab4540573e5566b14232aade 100644 (file)
--- a/src/event.js
+++ b/src/event.js
@@ -203,8 +203,8 @@ jQuery.event = {
                        if ( jQuery.isFunction( jQuery.data(elem, "handle") ) )
                                val = jQuery.data(elem, "handle").apply( elem, data );
 
-                       // Handle triggering native .onfoo handlers
-                       if ( !fn && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
+                       // Handle triggering native .onfoo handlers (and on links since we don't call .click() for links)
+                       if ( (!fn || (jQuery.nodeName(elem, 'a') && type == "click")) && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
                                val = false;
 
                        // Extra functions don't get the custom event object

diff --git a/test/unit/event.js b/test/unit/event.js
index ba29ab7ecccd228da2cda7b8e365d6df6ffeb733..0ec0f5966b2e1f757ed9fdf1689a167350fcc2cc 100644 (file)
--- a/test/unit/event.js
+++ b/test/unit/event.js
@@ -113,7 +113,7 @@ test("bind(), namespaced events, cloned events", function() {
 });
 
 test("click()", function() {
-       expect(4);
+       expect(5);
        $('<li><a href="#">Change location</a></li>').prependTo('#firstUL').find('a').bind('click', function() {
                var close = $('spanx', this); // same with $(this).find('span');
                ok( close.length == 0, "Context element does not exist, length must be zero" );
@@ -131,6 +131,13 @@ test("click()", function() {
        };
        $('#firstp').click();
        ok( counter == 1, "Check that click, triggers onclick event handler also" );
+       
+       var clickCounter = 0;
+       $('#simon1')[0].onclick = function(event) {
+               clickCounter++;
+       };
+       $('#simon1').click();
+       ok( clickCounter == 1, "Check that click, triggers onclick event handler on an a tag also" );
 });
 
 test("unbind(event)", function() {