SONAR-7287 Rename FavoriteUpdater#put to add

diff --git a/server/sonar-server/src/main/java/org/sonar/server/component/DefaultRubyComponentService.java b/server/sonar-server/src/main/java/org/sonar/server/component/DefaultRubyComponentService.java
index 19325c6d9dc1fdc3860cb61601f7d853af5d60c1..c031791764035fcecf5797074b8ccbe7f3247d1e 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/component/DefaultRubyComponentService.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/component/DefaultRubyComponentService.java
@@ -88,7 +88,7 @@ public class DefaultRubyComponentService implements RubyComponentService {
     permissionTemplateService.applyDefaultPermissionTemplate(dbSession, provisionedComponent.getKey());
     if (Qualifiers.PROJECT.equals(provisionedComponent.qualifier())
       && permissionTemplateService.hasDefaultTemplateWithPermissionOnProjectCreator(dbSession, provisionedComponent)) {
-      favoriteUpdater.put(dbSession, provisionedComponent.getId());
+      favoriteUpdater.add(dbSession, provisionedComponent.getId());
       dbSession.commit();
     }
 

diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/queue/ReportSubmitter.java b/server/sonar-server/src/main/java/org/sonar/server/computation/queue/ReportSubmitter.java
index 4c28e03bf0dbc29101174bbe9f0b91719e86593b..fcc65c09da4fe73cf1325d22debc72607b8f0b38 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/computation/queue/ReportSubmitter.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/computation/queue/ReportSubmitter.java
@@ -88,7 +88,7 @@ public class ReportSubmitter {
     // "provisioning" permission is check in ComponentService
     ComponentDto project = componentService.create(dbSession, newProject);
     if (permissionTemplateService.hasDefaultTemplateWithPermissionOnProjectCreator(dbSession, project)) {
-      favoriteUpdater.put(dbSession, project.getId());
+      favoriteUpdater.add(dbSession, project.getId());
       dbSession.commit();
     }
 

diff --git a/server/sonar-server/src/main/java/org/sonar/server/favorite/FavoriteUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/favorite/FavoriteUpdater.java
index 7ae2a9c86706aafec555f5d63c58550a94fd2af2..8aaf771f4ddaf9e5c3e4efb1f63ac3699ff9f89b 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/favorite/FavoriteUpdater.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/favorite/FavoriteUpdater.java
@@ -39,7 +39,7 @@ public class FavoriteUpdater {
   /**
    * Set favorite to the logged in user. If no user is logged, no action is done
    */
-  public void put(DbSession dbSession, long componentDbId) {
+  public void add(DbSession dbSession, long componentDbId) {
     if (!userSession.isLoggedIn()) {
       return;
     }

diff --git a/server/sonar-server/src/main/java/org/sonar/server/favorite/ws/AddAction.java b/server/sonar-server/src/main/java/org/sonar/server/favorite/ws/AddAction.java
index 031f7e69d37ac30dabcd72acde599809d186e465..a834320a05fc5cf7a6087960525aa5678255958b 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/favorite/ws/AddAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/favorite/ws/AddAction.java
@@ -76,7 +76,7 @@ public class AddAction implements FavoritesWsAction {
         userSession
           .checkLoggedIn()
           .checkComponentUuidPermission(UserRole.USER, componentDto.uuid());
-        favoriteUpdater.put(dbSession, componentDto.getId());
+        favoriteUpdater.add(dbSession, componentDto.getId());
         dbSession.commit();
       }
     };

diff --git a/server/sonar-server/src/test/java/org/sonar/server/component/DefaultRubyComponentServiceTest.java b/server/sonar-server/src/test/java/org/sonar/server/component/DefaultRubyComponentServiceTest.java
index 16c8485c2bff12f872c16f5ea37321842d43c536..d4c44bc4961f2a43eb8fcb91283f077b3a6adcde 100644 (file)
--- a/server/sonar-server/src/test/java/org/sonar/server/component/DefaultRubyComponentServiceTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/component/DefaultRubyComponentServiceTest.java
@@ -117,7 +117,7 @@ public class DefaultRubyComponentServiceTest {
     assertThat(project.qualifier()).isEqualTo(qualifier);
     assertThat(project.getId()).isEqualTo(result);
     verify(permissionTemplateService).applyDefaultPermissionTemplate(any(DbSession.class), eq(componentKey));
-    verify(favoriteUpdater).put(any(DbSession.class), eq(project.getId()));
+    verify(favoriteUpdater).add(any(DbSession.class), eq(project.getId()));
   }
 
   @Test(expected = BadRequestException.class)

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/queue/ReportSubmitterTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/queue/ReportSubmitterTest.java
index 687d267c9e062798ab0aa38113574265a3828349..5953cf80bb93036a7321b31e5c87b4ec64f6ee0c 100644 (file)
--- a/server/sonar-server/src/test/java/org/sonar/server/computation/queue/ReportSubmitterTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/computation/queue/ReportSubmitterTest.java
@@ -119,7 +119,7 @@ public class ReportSubmitterTest {
 
     verifyReportIsPersisted(TASK_UUID);
     verify(permissionTemplateService).applyDefault(any(DbSession.class), eq(createdProject), anyLong());
-    verify(favoriteUpdater).put(any(DbSession.class), eq(createdProject.getId()));
+    verify(favoriteUpdater).add(any(DbSession.class), eq(createdProject.getId()));
     verify(queue).submit(argThat(new TypeSafeMatcher<CeTaskSubmit>() {
       @Override
       protected boolean matchesSafely(CeTaskSubmit submit) {

diff --git a/server/sonar-server/src/test/java/org/sonar/server/favorite/FavoriteUpdaterTest.java b/server/sonar-server/src/test/java/org/sonar/server/favorite/FavoriteUpdaterTest.java
index 157b7513c1412c283849026b9ad0b067a0c67af3..74560b17558c5325916392c86cfc25e422c9dfdb 100644 (file)
--- a/server/sonar-server/src/test/java/org/sonar/server/favorite/FavoriteUpdaterTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/favorite/FavoriteUpdaterTest.java
@@ -49,7 +49,7 @@ public class FavoriteUpdaterTest {
   public void put_favorite() {
     assertNoFavorite();
 
-    underTest.put(dbSession, COMPONENT_ID);
+    underTest.add(dbSession, COMPONENT_ID);
 
     assertFavorite();
   }
@@ -58,17 +58,17 @@ public class FavoriteUpdaterTest {
   public void do_nothing_when_not_logged_in() {
     userSession.anonymous();
 
-    underTest.put(dbSession, COMPONENT_ID);
+    underTest.add(dbSession, COMPONENT_ID);
 
     assertNoFavorite();
   }
 
   @Test
   public void put_existing_favorite() {
-    underTest.put(dbSession, COMPONENT_ID);
+    underTest.add(dbSession, COMPONENT_ID);
     assertFavorite();
 
-    underTest.put(dbSession, COMPONENT_ID);
+    underTest.add(dbSession, COMPONENT_ID);
 
     assertFavorite();
   }