]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-5007 - Ignore test for SONAR-5183
authorStephane Gamard <stephane.gamard@searchbox.com>
Thu, 3 Jul 2014 13:24:25 +0000 (15:24 +0200)
committerStephane Gamard <stephane.gamard@searchbox.com>
Thu, 3 Jul 2014 14:23:56 +0000 (16:23 +0200)
sonar-server/src/main/java/org/sonar/server/rule/index/RuleNormalizer.java
sonar-server/src/test/java/org/sonar/server/qualityprofile/ActiveRuleBackendMediumTest.java

index 8fff85e916696bbee8788c9779460a200ff7c3cf..1c2c91db539d10d47e478b764b652480a7141e75 100644 (file)
@@ -26,6 +26,7 @@ import org.elasticsearch.action.WriteConsistencyLevel;
 import org.elasticsearch.action.support.replication.ReplicationType;
 import org.elasticsearch.action.update.UpdateRequest;
 import org.sonar.api.rule.RuleKey;
+import org.sonar.api.rule.RuleStatus;
 import org.sonar.api.server.debt.DebtCharacteristic;
 import org.sonar.core.persistence.DbSession;
 import org.sonar.core.rule.RuleDto;
@@ -39,7 +40,12 @@ import org.sonar.server.search.Indexable;
 import org.sonar.server.search.es.ListUpdate;
 
 import java.lang.reflect.Field;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 
 public class RuleNormalizer extends BaseNormalizer<RuleDto, RuleKey> {
 
@@ -179,7 +185,10 @@ public class RuleNormalizer extends BaseNormalizer<RuleDto, RuleKey> {
       update.put(RuleField.HTML_DESCRIPTION.field(), rule.getDescription());
       update.put(RuleField.FIX_DESCRIPTION.field(), rule.getEffortToFixDescription());
       update.put(RuleField.SEVERITY.field(), rule.getSeverityString());
-      update.put(RuleField.STATUS.field(), rule.getStatus().name());
+
+      RuleStatus status = rule.getStatus();
+      update.put(RuleField.STATUS.field(), status != null ? rule.getStatus().name() : null);
+
       update.put(RuleField.LANGUAGE.field(), rule.getLanguage());
       update.put(RuleField.INTERNAL_KEY.field(), rule.getConfigKey());
       update.put(RuleField.IS_TEMPLATE.field(), rule.isTemplate());
@@ -316,24 +325,24 @@ public class RuleNormalizer extends BaseNormalizer<RuleDto, RuleKey> {
     newParam.put(RuleParamField.DEFAULT_VALUE.field(), param.getDefaultValue());
 
     return ImmutableList.of(new UpdateRequest()
-      .id(key.toString())
-      .script(ListUpdate.NAME)
-      .addScriptParam(ListUpdate.FIELD, RuleField.PARAMS.field())
-      .addScriptParam(ListUpdate.VALUE, newParam)
-      .addScriptParam(ListUpdate.ID_FIELD, RuleParamField.NAME.field())
-      .addScriptParam(ListUpdate.ID_VALUE, param.getName())
-      );
+        .id(key.toString())
+        .script(ListUpdate.NAME)
+        .addScriptParam(ListUpdate.FIELD, RuleField.PARAMS.field())
+        .addScriptParam(ListUpdate.VALUE, newParam)
+        .addScriptParam(ListUpdate.ID_FIELD, RuleParamField.NAME.field())
+        .addScriptParam(ListUpdate.ID_VALUE, param.getName())
+    );
   }
 
   private List<UpdateRequest> nestedDelete(RuleParamDto param, RuleKey key) {
     return ImmutableList.of(new UpdateRequest()
-      .id(key.toString())
-      .script(ListUpdate.NAME)
-      .addScriptParam(ListUpdate.FIELD, RuleField.PARAMS.field())
-      .addScriptParam(ListUpdate.VALUE, null)
-      .addScriptParam(ListUpdate.ID_FIELD, RuleParamField.NAME.field())
-      .addScriptParam(ListUpdate.ID_VALUE, param.getName())
-      );
+        .id(key.toString())
+        .script(ListUpdate.NAME)
+        .addScriptParam(ListUpdate.FIELD, RuleField.PARAMS.field())
+        .addScriptParam(ListUpdate.VALUE, null)
+        .addScriptParam(ListUpdate.ID_FIELD, RuleParamField.NAME.field())
+        .addScriptParam(ListUpdate.ID_VALUE, param.getName())
+    );
   }
 
 }
index 1882cf33f338e2d89dd40c446ac38240f8f21430..2c5ff0f035f25fe622b1586f217d82d7c1c16919 100644 (file)
@@ -23,6 +23,7 @@ import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Multimap;
 import org.junit.Before;
 import org.junit.ClassRule;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.sonar.api.rule.RuleKey;
 import org.sonar.api.rule.RuleStatus;
@@ -66,6 +67,7 @@ public class ActiveRuleBackendMediumTest {
   }
 
   @Test
+  @Ignore("To be fixed with DB Time zone sprint -- SONAR-5183")
   public void synchronize_index() throws Exception {
     QualityProfileDto profile1 = QProfileTesting.newXooP1();
     db.qualityProfileDao().insert(dbSession, profile1);