fix(webhooks): fix crash when headers is null with header auth method

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

diff --git a/apps/webhooks/lib/BackgroundJobs/WebhookCall.php b/apps/webhooks/lib/BackgroundJobs/WebhookCall.php
index 06c3a4cf5d72a3fe210590489dfdb59670957cb1..1d5eeafdc75bd51a9b40d9ab2fa6d12822b3e307 100644 (file)
--- a/apps/webhooks/lib/BackgroundJobs/WebhookCall.php
+++ b/apps/webhooks/lib/BackgroundJobs/WebhookCall.php
@@ -32,7 +32,7 @@ class WebhookCall extends QueuedJob {
                $client = $this->clientService->newClient();
                $options = [];
                $options['body'] = json_encode($data);
-               $options['headers'] = $webhookListener->getHeaders();
+               $options['headers'] = $webhookListener->getHeaders() ?? [];
                try {
                        switch ($webhookListener->getAuthMethodEnum()) {
                                case AuthMethod::None:

diff --git a/apps/webhooks/lib/Db/WebhookListener.php b/apps/webhooks/lib/Db/WebhookListener.php
index fafda909f600918b6d9b9b452df9e7c488178516..a949d93c9ea4109fcf9c5359a635bbe109f71b3c 100644 (file)
--- a/apps/webhooks/lib/Db/WebhookListener.php
+++ b/apps/webhooks/lib/Db/WebhookListener.php
@@ -15,6 +15,7 @@ use OCP\Security\ICrypto;
 /**
  * @method void setUserId(string $userId)
  * @method string getUserId()
+ * @method ?array getHeaders()
  */
 class WebhookListener extends Entity implements \JsonSerializable {
        /** @var ?string id of the app_api application who added the webhook listener */