Fix Quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndexer.java b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndexer.java
index 67e8c731d49f5eecfacf5817a56a6730c70d7325..074e7a8f4a3517a58f24f2b8fb7827c5120f6601 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndexer.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndexer.java
@@ -76,7 +76,6 @@ public class IssueIndexer extends BaseIndexer implements ProjectIndexer, NeedAut
     switch (cause) {
       case PROJECT_CREATION:
         // nothing to do, issues do not exist at project creation
-        break;
       case PROJECT_KEY_UPDATE:
         // nothing to do, project key is not used in this index
         break;

diff --git a/server/sonar-server/src/main/java/org/sonar/server/platform/BackendCleanup.java b/server/sonar-server/src/main/java/org/sonar/server/platform/BackendCleanup.java
index 77e1fcfb6dad2fbb06f6a2f45bf98f09f6e795cd..a74305d6973c3d86bc5e005dac9a12822ebe6734 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/platform/BackendCleanup.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/platform/BackendCleanup.java
@@ -120,7 +120,7 @@ public class BackendCleanup {
     clearIndex(ComponentIndexDefinition.INDEX_COMPONENTS);
   }
 
-  private void truncateAnalysisTables(Connection connection) throws SQLException {
+  private static void truncateAnalysisTables(Connection connection) throws SQLException {
     try (Statement statement = connection.createStatement()) {
       // Clear inspection tables
       for (String table : ANALYSIS_TABLES) {

diff --git a/server/sonar-server/src/main/java/org/sonar/server/test/index/TestIndexer.java b/server/sonar-server/src/main/java/org/sonar/server/test/index/TestIndexer.java
index 81decd148eca20b21c57de7479c473f56c4ba7e2..1c1aa4c443cc7c88f604729f11b8740b4e20668d 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/test/index/TestIndexer.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/test/index/TestIndexer.java
@@ -55,7 +55,6 @@ public class TestIndexer extends BaseIndexer implements ProjectIndexer {
     switch (cause) {
       case PROJECT_CREATION:
         // no need to index, not tests at that time
-        break;
       case PROJECT_KEY_UPDATE:
         // no need to index, project key is not used
         break;