]> source.dussan.org Git - jgit.git/commitdiff
pgm: Fix missing braces in Commit.run() 86/135386/1
authorMatthias Sohn <matthias.sohn@sap.com>
Sun, 20 Jan 2019 00:30:24 +0000 (01:30 +0100)
committerMatthias Sohn <matthias.sohn@sap.com>
Sun, 20 Jan 2019 00:40:01 +0000 (01:40 +0100)
Change-Id: Ia9e7e846ba1abfdb490896e5bcb82e2c0039439c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Commit.java

index ebbb932ac4d3c36e0744d900cec695b986708e6c..d1ab529deb50394c2c6abc2dcfff9c1b47092188 100644 (file)
@@ -89,10 +89,12 @@ class Commit extends TextBuiltin {
        protected void run() {
                try (Git git = new Git(db)) {
                        CommitCommand commitCmd = git.commit();
-                       if (author != null)
+                       if (author != null) {
                                commitCmd.setAuthor(RawParseUtils.parsePersonIdent(author));
-                       if (message != null)
+                       }
+                       if (message != null) {
                                commitCmd.setMessage(message);
+                       }
                        if (noGpgSign) {
                                commitCmd.setSign(Boolean.FALSE);
                        } else if (gpgSigningKey != null) {
@@ -101,13 +103,17 @@ class Commit extends TextBuiltin {
                                        commitCmd.setSigningKey(gpgSigningKey);
                                }
                        }
-                       if (only && paths.isEmpty())
+                       if (only && paths.isEmpty()) {
                                throw die(CLIText.get().pathsRequired);
-                       if (only && all)
+                       }
+                       if (only && all) {
                                throw die(CLIText.get().onlyOneOfIncludeOnlyAllInteractiveCanBeUsed);
-                       if (!paths.isEmpty())
-                               for (String p : paths)
+                       }
+                       if (!paths.isEmpty()) {
+                               for (String p : paths) {
                                        commitCmd.setOnly(p);
+                               }
+                       }
                        commitCmd.setAmend(amend);
                        commitCmd.setAll(all);
                        Ref head = db.exactRef(Constants.HEAD);
@@ -122,12 +128,13 @@ class Commit extends TextBuiltin {
                        }
 
                        String branchName;
-                       if (!head.isSymbolic())
+                       if (!head.isSymbolic()) {
                                branchName = CLIText.get().branchDetachedHEAD;
-                       else {
+                       else {
                                branchName = head.getTarget().getName();
-                               if (branchName.startsWith(Constants.R_HEADS))
+                               if (branchName.startsWith(Constants.R_HEADS)) {
                                        branchName = branchName.substring(Constants.R_HEADS.length());
+                               }
                        }
                        outw.println("[" + branchName + " " + commit.name() + "] " //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
                                        + commit.getShortMessage());