file size on non-(Linux/BSD/Windows)-installations

Determining the file size using the exec() method is implemented for Linux, BSD, and Windows. However, on systems matching neither platform name (like SunOS), the fall-through path will return a file size result constituting a zero size instead of an invalid null return value.

diff --git a/lib/private/largefilehelper.php b/lib/private/largefilehelper.php
index 806e6e767027b2c2b1954c3d52892c790262a506..750ba1d23de9a2ae26eb3f3f8e33a00d08b74abc 100644 (file)
--- a/lib/private/largefilehelper.php
+++ b/lib/private/largefilehelper.php
@@ -148,7 +148,7 @@ class LargeFileHelper {
                if (\OC_Helper::is_function_enabled('exec')) {
                        $os = strtolower(php_uname('s'));
                        $arg = escapeshellarg($filename);
-                       $result = '';
+                       $result = null;
                        if (strpos($os, 'linux') !== false) {
                                $result = $this->exec("stat -c %s $arg");
                        } else if (strpos($os, 'bsd') !== false || strpos($os, 'darwin') !== false) {