]> source.dussan.org Git - archiva.git/commitdiff
remove self assignemet
authorOlivier Lamy <olamy@apache.org>
Fri, 7 Oct 2011 10:56:07 +0000 (10:56 +0000)
committerOlivier Lamy <olamy@apache.org>
Fri, 7 Oct 2011 10:56:07 +0000 (10:56 +0000)
use StringBuilder to concate String in a loop.

git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1179997 13f79535-47bb-0310-9956-ffa450edef68

archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-api/src/main/java/org/apache/archiva/admin/model/beans/ManagedRepository.java
archiva-modules/archiva-web/archiva-applet/src/main/java/org/apache/archiva/applet/ChecksumApplet.java

index 7902f08639b3999870e5be38ef0918efed8ef56f..39463199002e30adab7ca20f8547898184e95f8e 100644 (file)
@@ -93,7 +93,6 @@ public class ManagedRepository
         this.retentionCount = retentionCount;
         this.deleteReleasedSnapshots = deleteReleasedSnapshots;
         this.stageRepoNeeded = stageRepoNeeded;
-        this.resetStats = resetStats;
     }
 
     public String getCronExpression()
index 3dc1e4c43d45d8da4f6acff08aefa5b5318e7ad0..3122ab6297d1a96b233e3d9eac9408374bb3e886 100644 (file)
@@ -119,7 +119,7 @@ public class ChecksumApplet
 
     protected static String byteArrayToHexStr( byte[] data )
     {
-        String output = "";
+        StringBuilder output = new StringBuilder( "" );
 
         for ( int cnt = 0; cnt < data.length; cnt++ )
         {
@@ -136,9 +136,9 @@ public class ChecksumApplet
             }
 
             //Concatenate the two characters to the output string.
-            output = output + tempStr;
+            output.append( tempStr );
         }
 
-        return output.toUpperCase();
+        return output.toString().toUpperCase();
     }
 }