T0003_BasicTest: Fix incorrect usage of ExpectedException

There should only be one statement after the expect(...) method.

Any additional statements after the statement that is expected to
throw will never be executed in a passing test. This can lead to
inappropriately passing tests where later incorrect assertions are
skipped by the thrown exception.

See https://errorprone.info/bugpattern/ExpectedExceptionChecker

Change-Id: I20fecf8fb7a243e9da097e6d03fbf8cd69151bf0
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>

diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/T0003_BasicTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/T0003_BasicTest.java
index 02073226d0db3a1082bb12f8ac45b368154d2886..96caa01a9ef91b724761aecb31f4fed1d19e36bd 100644 (file)
--- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/T0003_BasicTest.java
+++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/T0003_BasicTest.java
@@ -333,9 +333,9 @@ public class T0003_BasicTest extends SampleDataRepositoryTestCase {
        public void test002_CreateBadTree() throws Exception {
                // We won't create a tree entry with an empty filename
                //
+               final TreeFormatter formatter = new TreeFormatter();
                expectedException.expect(IllegalArgumentException.class);
                expectedException.expectMessage(JGitText.get().invalidTreeZeroLengthName);
-               final TreeFormatter formatter = new TreeFormatter();
                formatter.append("", FileMode.TREE,
                                ObjectId.fromString("4b825dc642cb6eb9a060e54bf8d69288fbee4904"));
        }