Fix some quality flaws

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java
index 2fa7cc9a326c7f0bbc1818e1ef7fdc0f69a87bfb..f8b135458ca9d57ec344a7a60904bf172c7e4ba6 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java
@@ -24,6 +24,8 @@ import org.apache.commons.lang.builder.ReflectionToStringBuilder;
 import org.apache.commons.lang.math.NumberUtils;
 import org.sonar.api.qualitymodel.Characteristic;
 
+import javax.annotation.Nullable;
+
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 import java.util.Date;
@@ -246,7 +248,7 @@ public class Measure {
    * @param v the measure value
    * @return the measure object instance
    */
-  public Measure setValue(Double v) {
+  public Measure setValue(@Nullable Double v) {
     return setValue(v, DEFAULT_PRECISION);
   }
 
@@ -272,7 +274,7 @@ public class Measure {
    * @param precision the measure value precision
    * @return the measure object instance
    */
-  public Measure setValue(Double v, int precision) {
+  public Measure setValue(@Nullable Double v, int precision) {
     if (v != null) {
       if (Double.isNaN(v)) {
         throw new IllegalArgumentException("Measure value can not be NaN");

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
index 081bb09df62e768294742e9cb14748658ee3fea4..56c13b2db18fb7ade71f57a3ee2c9243cde389cd 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
@@ -274,7 +274,7 @@ public class Metric implements ServerExtension, BatchExtension {
   /**
    * For internal use only
    */
-  public Metric setId(Integer id) {
+  public Metric setId(@Nullable Integer id) {
     this.id = id;
     return this;
   }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java
index cf33a84c0ffaf906af0ff27608a1123508ee5673..f4ba8db90ba4ac5d85809479ad29fde500575633 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java
@@ -121,7 +121,7 @@ public class RuleMeasure extends Measure {
   }
 
   @Override
-  public RuleMeasure setValue(Double v) {
+  public RuleMeasure setValue(@Nullable Double v) {
     return (RuleMeasure) super.setValue(v);
   }