Improve error messages to state which bounds are exceeded

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/ooxml/java/org/apache/poi/util/IdentifierManager.java b/src/ooxml/java/org/apache/poi/util/IdentifierManager.java
index 77fe79c6304669a2320c789a7d6d8e5200f5c875..4b57e77707828de3d4da7dac3de242e1e97300d5 100644 (file)
--- a/src/ooxml/java/org/apache/poi/util/IdentifierManager.java
+++ b/src/ooxml/java/org/apache/poi/util/IdentifierManager.java
@@ -54,8 +54,7 @@ public class IdentifierManager {
      */\r
     public IdentifierManager(long lowerbound, long upperbound) {\r
         if (lowerbound > upperbound) {\r
-            String message = "lowerbound must not be greater than upperbound";\r
-            throw new IllegalArgumentException(message);\r
+            throw new IllegalArgumentException("lowerbound must not be greater than upperbound, had " + lowerbound + " and " + upperbound);\r
         }\r
         else if (lowerbound < MIN_ID) { \r
             String message = "lowerbound must be greater than or equal to " + Long.toString(MIN_ID);\r
@@ -64,10 +63,9 @@ public class IdentifierManager {
         else if (upperbound > MAX_ID) {\r
             /*\r
              * while MAX_ID is Long.MAX_VALUE, this check is pointless. But if\r
-             * someone subclasses / tweaks the limits, this check if fine.\r
+             * someone subclasses / tweaks the limits, this check is fine.\r
              */\r
-            String message = "upperbound must be less thean or equal " + Long.toString(MAX_ID);\r
-            throw new IllegalArgumentException(message);\r
+            throw new IllegalArgumentException("upperbound must be less than or equal to " + Long.toString(MAX_ID) + " but had " + upperbound);\r
         }\r
         this.lowerbound = lowerbound;\r
         this.upperbound = upperbound;\r
@@ -77,7 +75,7 @@ public class IdentifierManager {
 \r
     public long reserve(long id) {\r
         if (id < lowerbound || id > upperbound) {\r
-            throw new IllegalArgumentException("Value for parameter 'id' was out of bounds");\r
+            throw new IllegalArgumentException("Value for parameter 'id' was out of bounds, had " + id + ", but should be within [" + lowerbound + ":" + upperbound + "]");\r
         }\r
         verifyIdentifiersLeft();\r
         \r
@@ -161,7 +159,7 @@ public class IdentifierManager {
      */\r
     public boolean release(long id) {\r
         if (id < lowerbound || id > upperbound) {\r
-            throw new IllegalArgumentException("Value for parameter 'id' was out of bounds");\r
+            throw new IllegalArgumentException("Value for parameter 'id' was out of bounds, had " + id + ", but should be within [" + lowerbound + ":" + upperbound + "]");\r
         }\r
 \r
         if (id == upperbound) {\r