]> source.dussan.org Git - jquery.git/commitdiff
Fix #9469. Remove semi-functional .selector property. Close gh-1006.
authorDave Methvin <dave.methvin@gmail.com>
Wed, 24 Oct 2012 00:22:34 +0000 (20:22 -0400)
committerDave Methvin <dave.methvin@gmail.com>
Thu, 25 Oct 2012 02:36:20 +0000 (22:36 -0400)
Saved 65 bytes.

src/core.js
src/manipulation.js
src/traversing.js

index fa9899682e6f5316ac94eea089122ce48a0bba25..ae514e85598c405a4fc557a61a1c3e1863d89b04 100644 (file)
@@ -203,22 +203,15 @@ jQuery.fn = jQuery.prototype = {
 
        // Take an array of elements and push it onto the stack
        // (returning the new matched element set)
-       pushStack: function( elems, name, selector ) {
+       pushStack: function( elems ) {
 
                // Build a new jQuery matched element set
                var ret = jQuery.merge( this.constructor(), elems );
 
                // Add the old object onto the stack (as a reference)
                ret.prevObject = this;
-
                ret.context = this.context;
 
-               if ( name === "find" ) {
-                       ret.selector = this.selector + ( this.selector ? " " : "" ) + selector;
-               } else if ( name ) {
-                       ret.selector = this.selector + "." + name + "(" + selector + ")";
-               }
-
                // Return the newly-formed element set
                return ret;
        },
index 43bb9a0a037d18e1d38d958799d2bca4a31f5240..f0f65ecff292077b21e1cde95034c42663c4f018 100644 (file)
@@ -564,7 +564,7 @@ jQuery.each({
                                ret = ret.concat( elems );
                        }
 
-                       return this.pushStack( ret, name, insert.selector );
+                       return this.pushStack( ret );
                }
        };
 });
index 3e04bf4fb3b5ca8b99586d4a49e7320be037bddd..1f38d68cd8eb1be5b044cd07f3cd01bda8d719ce 100644 (file)
@@ -25,7 +25,7 @@ jQuery.fn.extend({
                        });
                }
 
-               ret = this.pushStack( "", "find", selector );
+               ret = this.pushStack( [] );
 
                for ( i = 0, l = this.length; i < l; i++ ) {
                        length = ret.length;
@@ -44,6 +44,8 @@ jQuery.fn.extend({
                        }
                }
 
+               // Needed because $( "selector", context ) becomes $( context ).find( "selector" )
+               ret.selector = ( this.selector ? this.selector + " " : "" ) + selector;
                return ret;
        },
 
@@ -62,11 +64,11 @@ jQuery.fn.extend({
        },
 
        not: function( selector ) {
-               return this.pushStack( winnow(this, selector, false), "not", selector);
+               return this.pushStack( winnow(this, selector, false) );
        },
 
        filter: function( selector ) {
-               return this.pushStack( winnow(this, selector, true), "filter", selector );
+               return this.pushStack( winnow(this, selector, true) );
        },
 
        is: function( selector ) {
@@ -103,7 +105,7 @@ jQuery.fn.extend({
 
                ret = ret.length > 1 ? jQuery.unique( ret ) : ret;
 
-               return this.pushStack( ret, "closest", selectors );
+               return this.pushStack( ret );
        },
 
        // Determine the position of an element within
@@ -216,7 +218,7 @@ jQuery.each({
                        ret = ret.reverse();
                }
 
-               return this.pushStack( ret, name, core_slice.call( arguments ).join(",") );
+               return this.pushStack( ret );
        };
 });