Fix #13401: replaceWith(""). Close gh-1163.

diff --git a/src/manipulation.js b/src/manipulation.js
index d50ebddf7c5398732ea5a21a7cffdea48fd7106a..a5a1a397596ccd4ffebe85c21722cb59bba8b30b 100644 (file)
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -241,15 +241,17 @@ jQuery.fn.extend({
                        value = jQuery( value ).not( this ).detach();
                }
 
-               return this.domManip( [ value ], true, function( elem ) {
-                       var next = this.nextSibling,
-                               parent = this.parentNode;
-
-                       if ( parent ) {
-                               jQuery( this ).remove();
-                               parent.insertBefore( elem, next );
-                       }
-               });
+               return value !== "" ?
+                       this.domManip( [ value ], true, function( elem ) {
+                               var next = this.nextSibling,
+                                       parent = this.parentNode;
+
+                               if ( parent ) {
+                                       jQuery( this ).remove();
+                                       parent.insertBefore( elem, next );
+                               }
+                       }) :
+                       this.remove();
        },
 
        detach: function( selector ) {

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
index 5c994a027c1dfa0b319984905b128c6206226d3d..01d53a0a12c72f7d2554ca56ef7558e5aca6ec87 100644 (file)
--- a/test/unit/manipulation.js
+++ b/test/unit/manipulation.js
@@ -1219,6 +1219,15 @@ test( "replaceWith(string) for more than one element", function() {
        equal(jQuery("#foo p").length, 0, "verify that all the three original element have been replaced");
 });
 
+test( "replaceWith(\"\") (#13401)", 4, function() {
+       expect( 1 );
+
+       var div = jQuery("<div><p></p></div>");
+
+       div.children().replaceWith("");
+       equal( div.html().toLowerCase(), "", "Replacing with empty string removes element" );
+});
+
 test( "replaceAll(String|Element|Array<Element>|jQuery)", function() {
 
        expect( 10 );