}
public String getSheetName() {
- long sheetId = ctName.getLocalSheetId();
- if(sheetId >= 0) {
- return workbook.getSheetName((int)sheetId);
+ if(ctName.isSetLocalSheetId()) {
+ // Given as explicit sheet id
+ long sheetId = ctName.getLocalSheetId();
+ if(sheetId >= 0) {
+ return workbook.getSheetName((int)sheetId);
+ }
+ } else {
+ // Is it embeded in the reference itself?
+ int excl = getReference().indexOf('!');
+ if(excl > -1) {
+ return getReference().substring(0, excl);
+ }
}
+
+ // Not given at all
return null;
}
--- /dev/null
+/* ====================================================================
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+==================================================================== */
+
+package org.apache.poi.xssf.usermodel;
+
+import java.io.File;
+
+import junit.framework.TestCase;
+
+public class TestXSSFBugs extends TestCase {
+ private String getFilePath(String file) {
+ File xml = new File(
+ System.getProperty("HSSF.testdata.path") +
+ File.separator + file
+ );
+ assertTrue(xml.exists());
+
+ return xml.toString();
+ }
+
+ /**
+ * Named ranges had the right reference, but
+ * the wrong sheet name
+ */
+ public void test45430() throws Exception {
+ XSSFWorkbook wb = new XSSFWorkbook(getFilePath("45430.xlsx"));
+ assertEquals(3, wb.getNumberOfNames());
+
+ assertEquals(0, wb.getNameAt(0).getCTName().getLocalSheetId());
+ assertFalse(wb.getNameAt(0).getCTName().isSetLocalSheetId());
+ assertEquals("SheetA!$A$1", wb.getNameAt(0).getReference());
+ assertEquals("SheetA", wb.getNameAt(0).getSheetName());
+
+ assertEquals(0, wb.getNameAt(1).getCTName().getLocalSheetId());
+ assertFalse(wb.getNameAt(1).getCTName().isSetLocalSheetId());
+ assertEquals("SheetB!$A$1", wb.getNameAt(1).getReference());
+ assertEquals("SheetB", wb.getNameAt(1).getSheetName());
+
+ assertEquals(0, wb.getNameAt(2).getCTName().getLocalSheetId());
+ assertFalse(wb.getNameAt(2).getCTName().isSetLocalSheetId());
+ assertEquals("SheetC!$A$1", wb.getNameAt(2).getReference());
+ assertEquals("SheetC", wb.getNameAt(2).getSheetName());
+ }
+}
projects / poi.git / commitdiff