Uncapitalize errors (#18915)

- See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
index 952135eaf590a5807d8ba196293bfb72e6720faa..d0c3d3325a83c0a570f98150e7ea567795308bb0 100644 (file)
--- a/routers/web/repo/issue.go
+++ b/routers/web/repo/issue.go
@@ -2557,7 +2557,7 @@ func updateAttachments(item interface{}, files []string) error {
        case *models.Comment:
                attachments = content.Attachments
        default:
-               return fmt.Errorf("Unknown Type: %T", content)
+               return fmt.Errorf("unknown Type: %T", content)
        }
        for i := 0; i < len(attachments); i++ {
                if util.IsStringInSlice(attachments[i].UUID, files) {
@@ -2575,7 +2575,7 @@ func updateAttachments(item interface{}, files []string) error {
                case *models.Comment:
                        err = content.UpdateAttachments(files)
                default:
-                       return fmt.Errorf("Unknown Type: %T", content)
+                       return fmt.Errorf("unknown Type: %T", content)
                }
                if err != nil {
                        return err
@@ -2587,7 +2587,7 @@ func updateAttachments(item interface{}, files []string) error {
        case *models.Comment:
                content.Attachments, err = repo_model.GetAttachmentsByCommentID(content.ID)
        default:
-               return fmt.Errorf("Unknown Type: %T", content)
+               return fmt.Errorf("unknown Type: %T", content)
        }
        return err
 }

diff --git a/routers/web/repo/lfs.go b/routers/web/repo/lfs.go
index 2cb4330c082bc4e0faa15af8117f8c3239e375be..d2d62786fe7b336b106f4e35782171ee95463d22 100644 (file)
--- a/routers/web/repo/lfs.go
+++ b/routers/web/repo/lfs.go
@@ -120,14 +120,14 @@ func LFSLocks(ctx *context.Context) {
                Shared: true,
        }); err != nil {
                log.Error("Failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err)
-               ctx.ServerError("LFSLocks", fmt.Errorf("Failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err))
+               ctx.ServerError("LFSLocks", fmt.Errorf("failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err))
                return
        }
 
        gitRepo, err := git.OpenRepositoryCtx(ctx, tmpBasePath)
        if err != nil {
                log.Error("Unable to open temporary repository: %s (%v)", tmpBasePath, err)
-               ctx.ServerError("LFSLocks", fmt.Errorf("Failed to open new temporary repository in: %s %v", tmpBasePath, err))
+               ctx.ServerError("LFSLocks", fmt.Errorf("failed to open new temporary repository in: %s %v", tmpBasePath, err))
                return
        }
        defer gitRepo.Close()
@@ -140,7 +140,7 @@ func LFSLocks(ctx *context.Context) {
 
        if err := gitRepo.ReadTreeToIndex(ctx.Repo.Repository.DefaultBranch); err != nil {
                log.Error("Unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err)
-               ctx.ServerError("LFSLocks", fmt.Errorf("Unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err))
+               ctx.ServerError("LFSLocks", fmt.Errorf("unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err))
                return
        }
 
@@ -525,14 +525,14 @@ func LFSAutoAssociate(ctx *context.Context) {
        for i, oid := range oids {
                idx := strings.IndexRune(oid, ' ')
                if idx < 0 || idx+1 > len(oid) {
-                       ctx.ServerError("LFSAutoAssociate", fmt.Errorf("Illegal oid input: %s", oid))
+                       ctx.ServerError("LFSAutoAssociate", fmt.Errorf("illegal oid input: %s", oid))
                        return
                }
                var err error
                metas[i] = &models.LFSMetaObject{}
                metas[i].Size, err = strconv.ParseInt(oid[idx+1:], 10, 64)
                if err != nil {
-                       ctx.ServerError("LFSAutoAssociate", fmt.Errorf("Illegal oid input: %s %v", oid, err))
+                       ctx.ServerError("LFSAutoAssociate", fmt.Errorf("illegal oid input: %s %v", oid, err))
                        return
                }
                metas[i].Oid = oid[:idx]

diff --git a/routers/web/repo/webhook.go b/routers/web/repo/webhook.go
index fb984de7f5857e36b55595a673460a11b8b3d89d..76ebd1c485d61385f2dc3d923b283ec8dde08879 100644 (file)
--- a/routers/web/repo/webhook.go
+++ b/routers/web/repo/webhook.go
@@ -106,7 +106,7 @@ func getOrgRepoCtx(ctx *context.Context) (*orgRepoCtx, error) {
                }, nil
        }
 
-       return nil, errors.New("Unable to set OrgRepo context")
+       return nil, errors.New("unable to set OrgRepo context")
 }
 
 func checkHookType(ctx *context.Context) string {