]> source.dussan.org Git - redmine.git/commitdiff
Merged r15416 (#22808).
authorJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 21 May 2016 06:50:38 +0000 (06:50 +0000)
committerJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 21 May 2016 06:50:38 +0000 (06:50 +0000)
git-svn-id: http://svn.redmine.org/redmine/branches/3.1-stable@15420 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/models/query.rb
test/functional/issues_controller_test.rb

index 512dbfe21d411d0ee7f0791428ce907ff575df05..fd5e2753b146d42262fc38509ee387e7c2fa6032 100644 (file)
@@ -514,7 +514,7 @@ class Query < ActiveRecord::Base
     if grouped? && (column = group_by_column)
       order = (sort_criteria_order_for(column.name) || column.default_order).try(:upcase)
       column.sortable.is_a?(Array) ?
-        column.sortable.collect {|s| "#{s} #{order}"}.join(',') :
+        column.sortable.collect {|s| "#{s} #{order}"} :
         "#{column.sortable} #{order}"
     end
   end
index d196e6c7d93a1f12fc423f411e8d6cc0ec7916df..c39b1d287a0da16860a19721c577faf1bb75683f 100644 (file)
@@ -273,6 +273,22 @@ class IssuesControllerTest < ActionController::TestCase
     assert_not_nil assigns(:issue_count_by_group)
   end
 
+  def test_index_with_query_grouped_and_sorted_by_fixed_version
+    get :index, :project_id => 1, :set_filter => 1, :group_by => "fixed_version", :sort => "fixed_version"
+    assert_response :success
+    assert_template 'index'
+    assert_not_nil assigns(:issues)
+    assert_not_nil assigns(:issue_count_by_group)
+  end
+
+  def test_index_with_query_grouped_and_sorted_by_fixed_version_in_reverse_order
+    get :index, :project_id => 1, :set_filter => 1, :group_by => "fixed_version", :sort => "fixed_version:desc"
+    assert_response :success
+    assert_template 'index'
+    assert_not_nil assigns(:issues)
+    assert_not_nil assigns(:issue_count_by_group)
+  end
+
   def test_index_with_query_grouped_by_list_custom_field
     get :index, :project_id => 1, :query_id => 9
     assert_response :success