fix debian init script

- use start-stop-daemon's chuid feature insted of su
  - using `su -c` breaks if the git user has no usable shell
  - this fixes #1025
- put --test before --exec, instead it gets passed to gogs
- set cwd via --chdir

diff --git a/scripts/init/debian/gogs b/scripts/init/debian/gogs
index 13e8b8aa5b893447bf492d809f271567fed484f7..b0b52286fcf538e0cf1df28bbdef26864c195d0a 100644 (file)
--- a/scripts/init/debian/gogs
+++ b/scripts/init/debian/gogs
@@ -49,10 +49,12 @@ do_start()
        #   1 if daemon was already running
        #   2 if daemon could not be started
        sh -c "start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile \\
-                       --exec $DAEMON -- $DAEMON_ARGS --test > /dev/null \\
+                       --test --chdir $WORKINGDIR --chuid $USER \\
+                       --exec $DAEMON -- $DAEMON_ARGS > /dev/null \\
                        || return 1"
        sh -c "start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile \\
-                       --background --exec /bin/su -- - $USER -c \"cd \\\"$WORKINGDIR\\\" && $DAEMON -- $DAEMON_ARGS\" \\
+                       --background --chdir $WORKINGDIR --chuid $USER \\
+                       --exec $DAEMON -- $DAEMON_ARGS \\
                        || return 2"
 }