]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-10690 rename to newOrchestrator as it now return Orchestrator
authorSébastien Lesaint <sebastien.lesaint@sonarsource.com>
Tue, 12 Jun 2018 09:55:53 +0000 (11:55 +0200)
committerSonarTech <sonartech@sonarsource.com>
Wed, 13 Jun 2018 18:20:50 +0000 (20:20 +0200)
53 files changed:
tests/src/test/java/org/sonarqube/tests/Category1Suite.java
tests/src/test/java/org/sonarqube/tests/Category3Suite.java
tests/src/test/java/org/sonarqube/tests/Category4Suite.java
tests/src/test/java/org/sonarqube/tests/Category6Suite.java
tests/src/test/java/org/sonarqube/tests/analysis/AnalysisEsResilienceTest.java
tests/src/test/java/org/sonarqube/tests/authorization/AuthorizationSuite.java
tests/src/test/java/org/sonarqube/tests/ce/CeShutdownTest.java
tests/src/test/java/org/sonarqube/tests/ce/CeWorkersTest.java
tests/src/test/java/org/sonarqube/tests/component/ComponentSuite.java
tests/src/test/java/org/sonarqube/tests/duplication/DuplicationSuite.java
tests/src/test/java/org/sonarqube/tests/issue/ExternalIssueSuite.java
tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDatePluginChangedTest.java
tests/src/test/java/org/sonarqube/tests/issue/IssueSuite.java
tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssueSuite.java
tests/src/test/java/org/sonarqube/tests/lite/LiteTest.java
tests/src/test/java/org/sonarqube/tests/marketplace/UpdateCenterTest.java
tests/src/test/java/org/sonarqube/tests/measure/MeasureSuite.java
tests/src/test/java/org/sonarqube/tests/organization/OrganizationSuite.java
tests/src/test/java/org/sonarqube/tests/performance/scanner/ScannerPerformanceSuite.java
tests/src/test/java/org/sonarqube/tests/performance/server/ComputeEnginePerfTest.java
tests/src/test/java/org/sonarqube/tests/performance/server/ServerPerfTest.java
tests/src/test/java/org/sonarqube/tests/project/OrganizationProjectSuite.java
tests/src/test/java/org/sonarqube/tests/project/ProjectSuite.java
tests/src/test/java/org/sonarqube/tests/qualityGate/OrganizationQualityGateSuite.java
tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateSuite.java
tests/src/test/java/org/sonarqube/tests/qualityModel/QualityModelSuite.java
tests/src/test/java/org/sonarqube/tests/qualityProfile/ActiveRuleEsResilienceTest.java
tests/src/test/java/org/sonarqube/tests/qualityProfile/BuiltInQualityProfilesNotificationTest.java
tests/src/test/java/org/sonarqube/tests/qualityProfile/PluginWithoutBuiltinQualityProfileTest.java
tests/src/test/java/org/sonarqube/tests/qualityProfile/QualityProfileUpdateTest.java
tests/src/test/java/org/sonarqube/tests/rule/RuleEsResilienceTest.java
tests/src/test/java/org/sonarqube/tests/rule/RuleReKeyingTest.java
tests/src/test/java/org/sonarqube/tests/serverSystem/BlueGreenTest.java
tests/src/test/java/org/sonarqube/tests/serverSystem/RestartTest.java
tests/src/test/java/org/sonarqube/tests/serverSystem/ServerSystemRestartingOrchestrator.java
tests/src/test/java/org/sonarqube/tests/serverSystem/SystemStateTest.java
tests/src/test/java/org/sonarqube/tests/settings/SettingsSuite.java
tests/src/test/java/org/sonarqube/tests/settings/SettingsTestRestartingOrchestrator.java
tests/src/test/java/org/sonarqube/tests/source/SourceSuite.java
tests/src/test/java/org/sonarqube/tests/startup/StartupIndexationTest.java
tests/src/test/java/org/sonarqube/tests/telemetry/TelemetryOptOutTest.java
tests/src/test/java/org/sonarqube/tests/telemetry/TelemetryUploadTest.java
tests/src/test/java/org/sonarqube/tests/test/TestSuite.java
tests/src/test/java/org/sonarqube/tests/ui/UiSuite.java
tests/src/test/java/org/sonarqube/tests/upgrade/UpgradeTest.java
tests/src/test/java/org/sonarqube/tests/user/HttpHeadersAuthenticationTest.java
tests/src/test/java/org/sonarqube/tests/user/OnboardingTest.java
tests/src/test/java/org/sonarqube/tests/user/RealmAuthenticationTest.java
tests/src/test/java/org/sonarqube/tests/user/SonarCloudUserSuite.java
tests/src/test/java/org/sonarqube/tests/user/UserEsResilienceTest.java
tests/src/test/java/org/sonarqube/tests/user/UserSuite.java
tests/src/test/java/org/sonarqube/tests/webhook/WebhooksSuite.java
tests/src/test/java/util/ItUtils.java

index 0a22aa2353acbafb65bf25ceb5ec6cab73acc65a..72aa599bd2a72d7db3a1c6049b2e4dfd71cbc822 100644 (file)
@@ -28,8 +28,9 @@ import org.sonarqube.tests.settings.DeprecatedPropertiesWsTest;
 import org.sonarqube.tests.settings.EmailsTest;
 import org.sonarqube.tests.settings.PropertySetsTest;
 import org.sonarqube.tests.settings.SettingsTest;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -49,7 +50,7 @@ import static util.ItUtils.xooPlugin;
 public class Category1Suite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .setServerProperty("sonar.notifications.delay", "1")
       .addPlugin(pluginArtifact("property-sets-plugin"))
index 468dbf14999090d7d1ef28239a92f5acfe1b2738..41eccee34e73dfbc3124d8ede6fa06393dc83088 100644 (file)
@@ -40,8 +40,9 @@ import org.sonarqube.tests.analysis.ScannerTest;
 import org.sonarqube.tests.analysis.SettingsEncryptionTest;
 import org.sonarqube.tests.analysis.TempFolderTest;
 import org.sonarqube.tests.plugins.VersionPluginTest;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -73,7 +74,7 @@ import static util.ItUtils.xooPlugin;
 public class Category3Suite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       .addPlugin(MavenLocation.of("org.sonarsource.java", "sonar-java-plugin", "LATEST_RELEASE"))
index b738d047fa7665344b9bccea6ebc9d3f0d417996..46d18d78dfbad35193a3ed983c1ae1bb32894d24 100644 (file)
@@ -37,8 +37,9 @@ import org.sonarqube.tests.serverSystem.ServerSystemTest;
 import org.sonarqube.tests.serverSystem.SystemInfoTest;
 import org.sonarqube.tests.ws.WsLocalCallTest;
 import org.sonarqube.tests.ws.WsTest;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -72,7 +73,7 @@ import static util.ItUtils.xooPlugin;
 public class Category4Suite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index 123ab4aeb6f3afdd5054fa6585e3d342f6809070..e99d0ed68eae7a53ec05b4d39f48706bd38812df 100644 (file)
@@ -36,8 +36,9 @@ import org.sonarqube.tests.qualityProfile.QualityProfilesEditTest;
 import org.sonarqube.tests.qualityProfile.QualityProfilesWsTest;
 import org.sonarqube.tests.rule.RulesMarkdownTest;
 import org.sonarqube.tests.rule.RulesWsTest;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -67,7 +68,7 @@ public class Category6Suite {
   public static final int SEARCH_HTTP_PORT = NetworkUtils.getNextAvailablePort(InetAddress.getLoopbackAddress());
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       // for ES resiliency tests
       .setServerProperty("sonar.search.httpPort", "" + SEARCH_HTTP_PORT)
index 2829597e2869b974aa1dba8ccce9a7d167f8710a..f0e8310ea3156e2d913664a424b20f363568dcd3 100644 (file)
@@ -53,7 +53,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
 import static org.sonarqube.tests.Byteman.Process.CE;
 import static org.sonarqube.ws.Ce.TaskStatus.FAILED;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.projectDir;
 
 public class AnalysisEsResilienceTest {
@@ -65,7 +65,7 @@ public class AnalysisEsResilienceTest {
 
   static {
     byteman = new Byteman();
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> {
         byteman.install(builder, CE);
         builder
index 2c92f49dfb73ed5ba4bcfa19491e6d71f10159da..cca17a9383cbfb32d76901b31d890c6d605b08b0 100644 (file)
@@ -25,7 +25,7 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 
 import static util.ItUtils.installCoreExtension;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -42,7 +42,7 @@ import static util.ItUtils.xooPlugin;
 public class AuthorizationSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = newOrchestrator(
     builder -> builder
       .setServerProperty("sonar.web.systemPasscode", SystemPasscodeTest.VALID_PASSCODE)
       .addPlugin(xooPlugin()),
index a2253f43bcca45481993cc1fa2ba70324ec48a1e..c61d2db5f0330da0ca18fc03433ad8bfd8cc5fa6 100644 (file)
@@ -37,7 +37,7 @@ import util.ItUtils;
 
 import static com.google.common.base.Preconditions.checkState;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class CeShutdownTest {
 
@@ -116,7 +116,7 @@ public class CeShutdownTest {
       pauseFile = temp.newFile();
       FileUtils.touch(pauseFile);
 
-      orchestrator = newOrchestratorBuilder(
+      orchestrator = ItUtils.newOrchestrator(
         builder -> builder
           .setServerProperty("sonar.ce.pauseTask.path", pauseFile.getAbsolutePath())
           .setServerProperty("sonar.ce.gracefulStopTimeOutInMs", "" + timeOutInMs)
index 2bfb2edbbb855aeac802748db08c6076538848b3..5142d1fe9975c8328a27bf60edb6514a4fa9dc8b 100644 (file)
@@ -57,7 +57,7 @@ import static java.util.stream.Collectors.toSet;
 import static org.assertj.core.api.Assertions.assertThat;
 import static util.ItUtils.installCoreExtension;
 import static util.ItUtils.newAdminWsClient;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 public class CeWorkersTest {
@@ -81,7 +81,7 @@ public class CeWorkersTest {
   public static void setUp() throws Exception {
     sharedMemory = temporaryFolder.newFile();
 
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = newOrchestrator(
       builder -> builder
         .setServerProperty("itTests.workerLatch.sharedMemoryFile", sharedMemory.getAbsolutePath())
         // overwrite default value to display heap dump on OOM and reduce max heap
index cce0e2ad99b187af0ec299c005fe42976ca6d36a..e4e8fc699c96306adff7dec329937737cb9cf506 100644 (file)
@@ -37,7 +37,7 @@ import static util.ItUtils.xooPlugin;
 public class ComponentSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index e0f4bd3c9ba60a30dea1ad72ff493fa2d6cb3d7b..b8b8bac3ef09a59dd0663391ed9ff132ea0ef6fb 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -37,7 +38,7 @@ import static util.ItUtils.xooPlugin;
 })
 public class DuplicationSuite {
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index e5d78462f05d37ffa87b7bee2baf892eb7b322b2..39a736be8c974f6641fd036ff9e060704c630d65 100644 (file)
@@ -36,7 +36,7 @@ import util.ItUtils;
 public class ExternalIssueSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(ItUtils.xooPlugin())
 
index fcd3d9e4d4da2209c1308cf494c8e0ed152693f7..f82b3b9ea176043e2622ca84c1f6ad6f35bc5b95 100644 (file)
@@ -43,7 +43,7 @@ import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.newUserWsClient;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.projectDir;
@@ -69,7 +69,7 @@ public class IssueCreationDatePluginChangedTest {
   private static final String USER_EMAIL = "tester@example.org";
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       .addPlugin(ItUtils.pluginArtifact("backdating-plugin-v1"))
index 5d700760a77e7b46d838e0b9c77d6c136808ccc9..6ca01ce940e1da5134fdd9adad07d8918d520095 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -53,7 +54,7 @@ import static util.ItUtils.xooPlugin;
 public class IssueSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .setServerProperty("sonar.search.httpPort", "9025")
       .addPlugin(xooPlugin())
index 3cfc081c2edfd5eb03b09ea186594fe06b7d0c0a..d28b6a9af52c2a637f1be6a5ce0deb612539af86 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -34,7 +35,7 @@ import static util.ItUtils.xooPlugin;
 public class OrganizationIssueSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index 87a49287b39f4802ab68c52365cfbb00655f0ded..4ff831ede885ef873d06b6c90a176a74a9b4b85b 100644 (file)
@@ -34,11 +34,12 @@ import org.sonarqube.ws.client.issues.SearchRequest;
 import org.sonarqube.ws.client.measures.ComponentRequest;
 import org.sonarqube.ws.client.measures.ComponentTreeRequest;
 import org.sonarqube.ws.client.measures.MeasuresService;
+import util.ItUtils;
 
 import static java.util.Arrays.asList;
 import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.runProjectAnalysis;
 import static util.ItUtils.xooPlugin;
 
@@ -46,7 +47,7 @@ public class LiteTest {
 
   private static final String PROJECT_KEY = "com.sonarsource.it.samples:multi-modules-sample";
 
-  private static Orchestrator orchestrator = newOrchestratorBuilder(
+  private static Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
       .setOrchestratorProperty("sonar.web.context", "/sonarqube")
       .addPlugin(xooPlugin()));
index e64590cb23ec9d4534b8fbed2588477180382c3a..ae2339e29c0fcf5f57871b18b4d2123745a0ec0d 100644 (file)
@@ -26,9 +26,10 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.sonarqube.qa.util.pageobjects.MarketplacePage;
 import org.sonarqube.qa.util.pageobjects.Navigation;
+import util.ItUtils;
 import util.user.UserRule;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 /**
@@ -37,7 +38,7 @@ import static util.ItUtils.pluginArtifact;
 public class UpdateCenterTest {
 
   @ClassRule
-  public static final Orchestrator orchestrator = newOrchestratorBuilder(
+  public static final Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
       .setServerProperty("sonar.updatecenter.url", UpdateCenterTest.class.getResource("/marketplace/UpdateCenterTest/update-center.properties").toString())
       .addPlugin(pluginArtifact("sonar-fake-plugin"))
index ee937ed365860f4c3e2152eacf00e5bf2abdadb4..1f1be5ecfc241acf6b5b335a36f789863fb9086d 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -45,7 +46,7 @@ import static util.ItUtils.xooPlugin;
 public class MeasureSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index 0d2d51231e24a8d5f2cef717bbe1b97e3f4a10f1..20c70d4e63687b6de63a5a07869e83df1b02ee16 100644 (file)
@@ -25,7 +25,7 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 
 import static util.ItUtils.installCoreExtension;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -42,7 +42,7 @@ import static util.ItUtils.xooPlugin;
 public class OrganizationSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       .addPlugin(pluginArtifact("ui-extensions-plugin"))
index e7143961452282be84356a38e67a3c869d7de6ad..e77b53bb72e35b0a069ba072385e617444a3f6ee 100644 (file)
@@ -27,8 +27,9 @@ import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 import org.sonarqube.tests.performance.AbstractPerfTest;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -43,7 +44,7 @@ import static util.ItUtils.xooPlugin;
 public class ScannerPerformanceSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       // should not be so high, but required as long embedded h2 is used -> requires more memory on server
index 864aba6512a0739cb71a00389cc157d18a022617..5ef26f34562af08e901347cb54b3d9efa57e64c0 100644 (file)
@@ -33,8 +33,9 @@ import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
 import org.sonarqube.tests.performance.AbstractPerfTest;
 import org.sonarqube.tests.performance.ServerLogs;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 public class ComputeEnginePerfTest extends AbstractPerfTest {
@@ -44,7 +45,7 @@ public class ComputeEnginePerfTest extends AbstractPerfTest {
   public static TemporaryFolder temp = new TemporaryFolder();
 
   @ClassRule
-  public static Orchestrator orchestrator = newOrchestratorBuilder(
+  public static Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       .setServerProperty(
index 0b99aeaa36d262128386c50ed49489901e0c0caf..e5492676f0f5add8ed674ad1c6d5b178fc7ffaa9 100644 (file)
@@ -29,9 +29,10 @@ import org.junit.Test;
 import org.junit.rules.Timeout;
 import org.sonarqube.tests.performance.AbstractPerfTest;
 import org.sonarqube.tests.performance.ServerLogs;
+import util.ItUtils;
 
 import static org.apache.commons.io.FileUtils.readLines;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 public class ServerPerfTest extends AbstractPerfTest {
@@ -44,7 +45,7 @@ public class ServerPerfTest extends AbstractPerfTest {
   @Test
   public void server_startup_and_shutdown() throws Exception {
     String defaultWebJavaOptions = "-Xmx768m -XX:+HeapDumpOnOutOfMemoryError -Djava.awt.headless=true -Dfile.encoding=UTF-8";
-    Orchestrator orchestrator = newOrchestratorBuilder(
+    Orchestrator orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(xooPlugin())
 
index 7aae5bd8be34b69d518280c9b7a8ba05b05844c5..2d7472fecbb42a822c8b45f6e25b7409eb68abe3 100644 (file)
@@ -25,8 +25,9 @@ import java.net.InetAddress;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -52,7 +53,7 @@ public class OrganizationProjectSuite {
   static final int SEARCH_HTTP_PORT = NetworkUtils.getNextAvailablePort(InetAddress.getLoopbackAddress());
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       // for ES resiliency tests
       .setServerProperty("sonar.search.httpPort", "" + SEARCH_HTTP_PORT)
index 79975d347155c5f745592871700f14987449b6e6..431791d7b96a6897cdd3dfc8882afd917763b4e6 100644 (file)
@@ -25,8 +25,9 @@ import java.net.InetAddress;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -40,7 +41,7 @@ public class ProjectSuite {
   static final int SEARCH_HTTP_PORT = NetworkUtils.getNextAvailablePort(InetAddress.getLoopbackAddress());
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       // for ES resiliency tests
       .setServerProperty("sonar.search.httpPort", "" + SEARCH_HTTP_PORT)
index d3c1a816e6a9d471c790a2bb5efa6b325c5c741c..c6550b2f9c45368f00511eec0cb43080c705d3c3 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -37,7 +38,7 @@ import static util.ItUtils.xooPlugin;
 public class OrganizationQualityGateSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       // required for notification tests
       .setServerProperty("sonar.notifications.delay", "1")
index 3cb1b8a9205974321f6160bf0b7e296d0463049a..79e3563df35fd3e20206415f8bfa8ab26be50fad 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -39,7 +40,7 @@ import static util.ItUtils.xooPlugin;
 public class QualityGateSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       // required for notification tests
       .setServerProperty("sonar.notifications.delay", "1")
index ee286940e76b8e56080f9b30ac7d208f6abb2d09..29fa2d7d85ab6dfd880467c1d3b7fef6d5ead4e1 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -41,7 +42,7 @@ import static util.ItUtils.xooPlugin;
 public class QualityModelSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index 9ba5c3505c7adb58c8a8b4e76188c3c324cdac19..406dd4caa6d15c99d19ed493321a874fe67ef218 100644 (file)
@@ -38,7 +38,7 @@ import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.sonarqube.tests.Byteman.Process.WEB;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class ActiveRuleEsResilienceTest {
   private static final String RULE_ONE_BUG_PER_LINE = "xoo:OneBugIssuePerLine";
@@ -49,7 +49,7 @@ public class ActiveRuleEsResilienceTest {
 
   static {
     byteman = new Byteman();
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> {
         byteman.install(builder, WEB);
         builder.setServerProperty("sonar.search.recovery.delayInMs", "1000")
index 4001581cc8fbb64d3c9f553b5a8d8af3214f4786..4dd554ff32704c35d840d2b56b21ff6f1a52ac9b 100644 (file)
@@ -41,7 +41,7 @@ import util.user.UserRule;
 
 import static org.apache.commons.lang.RandomStringUtils.randomAlphanumeric;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 public class BuiltInQualityProfilesNotificationTest {
@@ -68,7 +68,7 @@ public class BuiltInQualityProfilesNotificationTest {
 
   @Test
   public void does_not_send_mail_if_no_quality_profile_is_updated() throws Exception {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("foo-plugin-v1"))
         .setServerProperty("email.smtp_host.secured", "localhost")
@@ -87,7 +87,7 @@ public class BuiltInQualityProfilesNotificationTest {
 
   @Test
   public void send_mail_if_quality_profile_is_updated() throws Exception {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("foo-plugin-v1"))
         .setServerProperty("sonar.notifications.delay", "1")
@@ -174,7 +174,7 @@ public class BuiltInQualityProfilesNotificationTest {
 
   @Test
   public void do_not_send_mail_if_notifications_are_disabled_in_settings() throws Exception {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("foo-plugin-v1"))
         .setServerProperty("sonar.builtInQualityProfiles.disableNotificationOnUpdate", "true")
index f6ed25067fed9921616c892f6cb91f50f787932b..ece31deeac88e633ee21f381bdb315c253430b9d 100644 (file)
@@ -25,10 +25,11 @@ import java.nio.charset.StandardCharsets;
 import org.apache.commons.io.FileUtils;
 import org.junit.After;
 import org.junit.Test;
+import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.fail;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 public class PluginWithoutBuiltinQualityProfileTest {
@@ -36,7 +37,7 @@ public class PluginWithoutBuiltinQualityProfileTest {
 
   @Test
   public void should_fail_if_plugin_defines_language_and_no_builtin_qprofile() throws IOException {
-    orchestrator = newOrchestratorBuilder(b -> b.addPlugin(pluginArtifact("foo-plugin-without-qprofile")));
+    orchestrator = ItUtils.newOrchestrator(b -> b.addPlugin(pluginArtifact("foo-plugin-without-qprofile")));
 
     try {
       orchestrator.start();
index f0a66d8ca5e97570ac9dd599d6ffac78d7daeaf2..832857027858b4a7ae0f01816eb1cb420df13011 100644 (file)
@@ -31,10 +31,11 @@ import org.sonarqube.ws.Qualityprofiles.SearchWsResponse.QualityProfile;
 import org.sonarqube.ws.Rules;
 import org.sonarqube.ws.client.PostRequest;
 import org.sonarqube.ws.client.qualityprofiles.SearchRequest;
+import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 public class QualityProfileUpdateTest {
@@ -54,7 +55,7 @@ public class QualityProfileUpdateTest {
   @Test
   // SONAR-10363
   public void updating_an_analyzer_must_update_default_quality_profile() {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("foo-plugin-v1"))
     // .setServerProperty("sonar.sonarcloud.enabled", "true"))
index 4749cb897905c24d526936b81a998689ae50cd31..c0fc140d87432d129fce1f73ef82a568e0a42767 100644 (file)
@@ -38,7 +38,7 @@ import util.ItUtils;
 import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.sonarqube.tests.Byteman.Process.WEB;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class RuleEsResilienceTest {
 
@@ -48,7 +48,7 @@ public class RuleEsResilienceTest {
 
   static {
     byteman = new Byteman();
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> {
         byteman.install(builder, WEB);
         builder
index 7508cdd8a3764a4f2c5696b2702f92dbc1e9ce5c..c6e0522a08f9d17c3c9aa5758506b1f78aa671b0 100644 (file)
@@ -36,11 +36,12 @@ import org.sonarqube.ws.Issues;
 import org.sonarqube.ws.Rules;
 import org.sonarqube.ws.client.PostRequest;
 import org.sonarqube.ws.client.issues.SearchRequest;
+import util.ItUtils;
 
 import static java.util.Collections.singletonList;
 import static java.util.stream.Collectors.toSet;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.projectDir;
 
@@ -61,7 +62,7 @@ public class RuleReKeyingTest {
 
   @Test
   public void rules_are_re_keyed_when_upgrading_and_downgrading_plugin() {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("foo-plugin-v1")));
     orchestrator.start();
index 041bc71e12868d71cec7810ca94dbbdc2fb716b7..65e84687552de8a48b9a04e6b3c4b9f3aae69c66 100644 (file)
@@ -42,7 +42,7 @@ import org.sonarqube.ws.client.qualityprofiles.AddProjectRequest;
 import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -69,7 +69,7 @@ public class BlueGreenTest {
 
   @Test
   public void upgrade_analyzer_when_analysis_is_pending_in_compute_engine_queue() throws Exception {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
       .addPlugin(pluginArtifact("blue-green-plugin-v1"))
       .addPlugin(xooPlugin()));
index 52d45e8193314ec98e4130d2bc918fd7fc3cb473..c61e16b4194b18827f52ad55bd15ab9bb0badfbc 100644 (file)
@@ -38,7 +38,7 @@ import util.ItUtils;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.fail;
 import static util.ItUtils.newAdminWsClient;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.newWsClient;
 
 /**
@@ -64,7 +64,7 @@ public class RestartTest {
   public void restart_in_prod_mode_requires_sysadmin_permission_and_restarts() throws Exception {
     // server classloader locks Jar files on Windows
     if (!SystemUtils.IS_OS_WINDOWS) {
-      orchestrator = newOrchestratorBuilder(
+      orchestrator = ItUtils.newOrchestrator(
         builder -> builder
           .setOrchestratorProperty("orchestrator.keepWorkspace", "true"));
       orchestrator.start();
index 593a06215e30cd1ac6600d0ffc8b89e284fd68fc..d49a64117651db1d550a6cd15324f7572d04d35f 100644 (file)
@@ -33,7 +33,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.fail;
 import static util.ItUtils.locationOf;
 import static util.ItUtils.newAdminWsClient;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 /**
  * This class start a new orchestrator on each test case
@@ -58,7 +58,7 @@ public class ServerSystemRestartingOrchestrator {
   @Test
   public void check_minimal_sonar_version_at_startup() throws Exception {
     try {
-      orchestrator = newOrchestratorBuilder(
+      orchestrator = ItUtils.newOrchestrator(
         builder -> builder
           .addPlugin(locationOf(ServerSystemRestartingOrchestrator.class.getResource("/serverSystem/ServerSystemTest/incompatible-plugin-1.0.jar"))));
       orchestrator.start();
@@ -73,7 +73,7 @@ public class ServerSystemRestartingOrchestrator {
   public void support_install_dir_with_whitespaces() throws Exception {
     String dirName = "build/distributions/has space";
     FileUtils.deleteDirectory(new File(dirName));
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .setOrchestratorProperty("orchestrator.workspaceDir", dirName));
     orchestrator.start();
@@ -84,7 +84,7 @@ public class ServerSystemRestartingOrchestrator {
   // SONAR-4748
   @Test
   public void should_create_in_temp_folder() throws Exception {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(ItUtils.pluginArtifact("server-plugin"))
         .setServerProperty("sonar.createTempFiles", "true"));
index 14cf8137b5fccbba8e42e5ee11e0d96ca4f85cee..57fe4ecca3aee4fd847739aef788e4676760ff46 100644 (file)
@@ -38,10 +38,11 @@ import org.junit.rules.Timeout;
 import org.sonarqube.qa.util.Elasticsearch;
 import org.sonarqube.ws.System;
 import org.sonarqube.ws.client.WsClient;
+import util.ItUtils;
 
 import static com.google.common.base.Preconditions.checkState;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.newSystemUserWsClient;
 import static util.ItUtils.newWsClient;
 import static util.ItUtils.pluginArtifact;
@@ -129,7 +130,7 @@ public class SystemStateTest {
 
     void start(Lock lock) {
       checkState(orchestrator == null);
-      orchestrator = newOrchestratorBuilder(
+      orchestrator = ItUtils.newOrchestrator(
         builder -> builder
           .addPlugin(pluginArtifact("server-plugin"))
           .setServerProperty("sonar.web.startupLock.path", lock.webFile.getAbsolutePath())
index d987479b1d0947dfd99b68447dc4bab45a6ac72c..4701557275b4fe4f9ca996a512bd12225797bd4c 100644 (file)
@@ -34,7 +34,7 @@ import static util.ItUtils.xooPlugin;
 public class SettingsSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin()));
 
index 5360e463b55a2f456bf5eb66e74e80fb044f542b..d8d95ec6a43c1fb4bf6fbbc7f8ea98a94b598ea6 100644 (file)
@@ -28,11 +28,12 @@ import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.sonarqube.qa.util.pageobjects.EncryptionPage;
 import org.sonarqube.qa.util.pageobjects.Navigation;
+import util.ItUtils;
 import util.user.UserRule;
 
 import static com.codeborne.selenide.Condition.visible;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.projectDir;
 import static util.ItUtils.xooPlugin;
@@ -60,7 +61,7 @@ public class SettingsTestRestartingOrchestrator {
   @Test
   public void test_settings() {
     URL secretKeyUrl = getClass().getResource("/settings/SettingsTest/sonar-secret.txt");
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(pluginArtifact("settings-plugin"))
         .addPlugin(pluginArtifact("license-plugin"))
@@ -86,7 +87,7 @@ public class SettingsTestRestartingOrchestrator {
 
   @Test
   public void property_relocation() {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
       .addPlugin(pluginArtifact("property-relocation-plugin"))
       .addPlugin(xooPlugin())
index 075ffdf6d64c2b50e26748d43b4e007f68556f46..cffc1cd3c32a3b016b1259496066c0aa9bc6a20b 100644 (file)
@@ -24,8 +24,9 @@ import com.sonar.orchestrator.locator.MavenLocation;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -39,7 +40,7 @@ import static util.ItUtils.xooPlugin;
 public class SourceSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       .addPlugin(MavenLocation.of("org.sonarsource.scm.git", "sonar-scm-git-plugin", "LATEST_RELEASE")));
index 47a5eb16fe6614505c1176991bc20dc091b4b447..a5c0c5620ab2fad7657e8ecb0ade48376d6a7bed 100644 (file)
@@ -36,9 +36,10 @@ import org.sonarqube.qa.util.LogsTailer;
 import org.sonarqube.qa.util.Tester;
 import org.sonarqube.ws.Users;
 import org.sonarqube.ws.client.users.SearchRequest;
+import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 public class StartupIndexationTest {
@@ -82,7 +83,7 @@ public class StartupIndexationTest {
       pauseFile = temp.newFile();
       FileUtils.touch(pauseFile);
 
-      orchestrator = newOrchestratorBuilder(
+      orchestrator = ItUtils.newOrchestrator(
         builder -> builder
           .setServerProperty("sonar.web.pause.path", pauseFile.getAbsolutePath())
           .addPlugin(pluginArtifact("wait-at-platform-level4-plugin"))
index 120e4e55f3da89ebb57c2e2e0c68b5fafc9e800d..d859cd7c5a47ef0ca555b76c529752d611289305 100644 (file)
@@ -29,17 +29,18 @@ import org.junit.Test;
 import org.junit.rules.RuleChain;
 import org.sonarqube.qa.util.Tester;
 import org.sonarqube.ws.client.GetRequest;
+import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static util.ItUtils.jsonToMap;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 public class TelemetryOptOutTest {
 
   public static MockWebServer server = new MockWebServer();
 
-  private static Orchestrator orchestrator = newOrchestratorBuilder(
+  private static Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
     .addPlugin(xooPlugin())
     .setServerProperty("sonar.telemetry.enable", "false")
index 56790db2bdb7019022ec406cf395a47c8eef92be..15bc9cbe41c769092977dd164d42be2d55aefc4e 100644 (file)
@@ -37,7 +37,7 @@ import util.ItUtils;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
 import static util.ItUtils.jsonToMap;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.runProjectAnalysis;
 import static util.ItUtils.xooPlugin;
 
@@ -61,7 +61,7 @@ public class TelemetryUploadTest {
   @Test
   public void sent_telemetry_data() throws Exception {
     telemetryServer.enqueue(new MockResponse().setResponseCode(200));
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(xooPlugin())
         .setServerProperty("sonar.telemetry.url", telemetryServer.url("").toString())
@@ -105,7 +105,7 @@ public class TelemetryUploadTest {
 
   @Test
   public void does_not_send_telemetry_data_right_away_by_Default() {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .addPlugin(xooPlugin())
         .setServerProperty("sonar.telemetry.url", telemetryServer.url("").toString()));
index e4177ca8ab15a4e70c5269177477b7051bcaf2e2..c9f1c39382e568ff213a9b40016a13b4a975cc98 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -37,7 +38,7 @@ import static util.ItUtils.xooPlugin;
 public class TestSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin()));
 
index 31338ac30310b5a0a10bcf9a540c017479bcad49..678201c7f7a151cba5143933c7b9b0a7a4a9bb70 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -37,7 +38,7 @@ import static util.ItUtils.xooPlugin;
 public class UiSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
       // Used in UiExtensionsTest
index 2ec884365d3ba456f5266948c38623f085e2e36c..41284247d7853caf542ac80c555187680c562344 100644 (file)
@@ -44,13 +44,14 @@ import org.sonarqube.ws.client.WsClient;
 import org.sonarqube.ws.client.WsClientFactories;
 import org.sonarqube.ws.client.WsResponse;
 import org.sonarqube.ws.client.measures.ComponentRequest;
+import util.ItUtils;
 
 import static com.codeborne.selenide.Condition.hasText;
 import static com.codeborne.selenide.Selenide.$;
 import static java.lang.Integer.parseInt;
 import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class UpgradeTest {
 
@@ -156,7 +157,7 @@ public class UpgradeTest {
   }
 
   private void startAndUpgradeDevServer() {
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> builder
         .setOrchestratorProperty("orchestrator.keepDatabase", "true")
         .keepBundledPlugins()
index 61659c545d57b06d02372c5f88b45c3e49c7d4c4..30032d53f2e93ebd0968c3754d710867666e0231 100644 (file)
@@ -33,6 +33,7 @@ import org.sonarqube.ws.UserGroups.Group;
 import org.sonarqube.ws.Users.CreateWsResponse.User;
 import org.sonarqube.ws.Users.SearchWsResponse;
 import org.sonarqube.ws.client.users.SearchRequest;
+import util.ItUtils;
 
 import static java.lang.String.format;
 import static java.nio.charset.StandardCharsets.UTF_8;
@@ -40,7 +41,7 @@ import static java.util.Arrays.asList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.groups.Tuple.tuple;
 import static util.ItUtils.call;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 /**
  * Test authentication using HTTP headers.
@@ -55,7 +56,7 @@ public class HttpHeadersAuthenticationTest {
   private static final String GROUPS_HEADER = "H-Groups";
 
   @ClassRule
-  public static final Orchestrator orchestrator = newOrchestratorBuilder(
+  public static final Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
       .setServerProperty("sonar.web.sso.enable", "true")
       .setServerProperty("sonar.web.sso.loginHeader", LOGIN_HEADER)
index 515f813f2de716b3cb70b7eb7cc1182876a3d760..a93681186bf21a59a0ac8cc426eb315d3da66728 100644 (file)
@@ -30,14 +30,14 @@ import org.sonarqube.ws.client.users.DeactivateRequest;
 import util.ItUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class OnboardingTest {
 
   private static final String ONBOARDING_TUTORIAL_SHOW_TO_NEW_USERS = "sonar.onboardingTutorial.showToNewUsers";
 
   @ClassRule
-  public static final Orchestrator orchestrator = newOrchestratorBuilder();
+  public static final Orchestrator orchestrator = ItUtils.newOrchestrator();
 
   @Rule
   public Tester tester = new Tester(orchestrator).disableOrganizations();
index 45f5c23eb97c8d622a7faabf0f4717675ab0a9d8..b1e64b15b4e4cb48a181d6c229ec3c1ddeacad08 100644 (file)
@@ -38,12 +38,13 @@ import org.sonarqube.ws.Users;
 import org.sonarqube.ws.Users.SearchWsResponse.User;
 import org.sonarqube.ws.client.users.ChangePasswordRequest;
 import org.sonarqube.ws.client.users.SearchRequest;
+import util.ItUtils;
 
 import static java.util.Arrays.asList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.groups.Tuple.tuple;
 import static util.ItUtils.expectHttpError;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 
 /**
@@ -57,7 +58,7 @@ public class RealmAuthenticationTest {
   public ExpectedException thrown = ExpectedException.none();
 
   @ClassRule
-  public static final Orchestrator orchestrator = newOrchestratorBuilder(
+  public static final Orchestrator orchestrator = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(pluginArtifact("security-plugin"))
       .setServerProperty("sonar.security.realm", "FakeRealm"));
index 45c3e1436cd5bd3318b385b20ed86b9e803e2ece..a8ffc366be251c61352fcfda5a285cf329ca8ec1 100644 (file)
@@ -24,8 +24,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -40,7 +41,7 @@ import static util.ItUtils.xooPlugin;
 public class SonarCloudUserSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index c0205324ebf254beb696389c8894e6396be816d4..b36ed86d3734c6b303c00fe21827d46d95823904 100644 (file)
@@ -39,7 +39,7 @@ import util.ItUtils;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.sonarqube.tests.Byteman.Process.WEB;
 import static util.ItUtils.expectHttpError;
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 
 public class UserEsResilienceTest {
 
@@ -49,7 +49,7 @@ public class UserEsResilienceTest {
 
   static {
     byteman = new Byteman();
-    orchestrator = newOrchestratorBuilder(
+    orchestrator = ItUtils.newOrchestrator(
       builder -> {
         byteman.install(builder, WEB);
         builder
index 8e07ffe84048675f73a34bdc0933ee035219e775..502aaafdf28d95507617fde8458777edd8932f75 100644 (file)
@@ -24,8 +24,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.pluginArtifact;
 import static util.ItUtils.xooPlugin;
 
@@ -46,7 +47,7 @@ import static util.ItUtils.xooPlugin;
 public class UserSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index ae1048dc5eb24603132be8f3f30ac18c78ce956f..f99ccf9ab5067881058c3ee3106e2c9f98edcc91 100644 (file)
@@ -23,8 +23,9 @@ import com.sonar.orchestrator.Orchestrator;
 import org.junit.ClassRule;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import util.ItUtils;
 
-import static util.ItUtils.newOrchestratorBuilder;
+import static util.ItUtils.newOrchestrator;
 import static util.ItUtils.xooPlugin;
 
 @RunWith(Suite.class)
@@ -35,7 +36,7 @@ import static util.ItUtils.xooPlugin;
 public class WebhooksSuite {
 
   @ClassRule
-  public static final Orchestrator ORCHESTRATOR = newOrchestratorBuilder(
+  public static final Orchestrator ORCHESTRATOR = ItUtils.newOrchestrator(
     builder -> builder
       .addPlugin(xooPlugin())
 
index 6daaeefcfd6851b3908e53af56ad582102372bb3..926db82c68415254f1c35254536870d970abb1a7 100644 (file)
@@ -100,16 +100,16 @@ public class ItUtils {
   private ItUtils() {
   }
 
-  public static Orchestrator newOrchestratorBuilder() {
-    return newOrchestratorBuilder(t -> {}, server -> {});
+  public static Orchestrator newOrchestrator() {
+    return newOrchestrator(t -> {}, server -> {});
   }
 
-  public static Orchestrator newOrchestratorBuilder(Consumer<OrchestratorBuilder> beforeInstall) {
-    return newOrchestratorBuilder(beforeInstall, server -> {
+  public static Orchestrator newOrchestrator(Consumer<OrchestratorBuilder> beforeInstall) {
+    return newOrchestrator(beforeInstall, server -> {
     });
   }
 
-  public static Orchestrator newOrchestratorBuilder(Consumer<OrchestratorBuilder> beforeInstall, Consumer<Server> afterInstall) {
+  public static Orchestrator newOrchestrator(Consumer<OrchestratorBuilder> beforeInstall, Consumer<Server> afterInstall) {
     OrchestratorBuilder builder = Orchestrator.builderEnv()
       .setEdition(COMMUNITY)
       // reduce memory for Elasticsearch