Use prop to retrieve boolean properties (so the selected hook will be used)

diff --git a/src/attributes.js b/src/attributes.js
index bc26d735aa4a80c34057aa7ae4ae6a0ed8635c78..f1d2944e2a6d4b264541a2a7cdd08f756b0c2e6d 100644 (file)
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -466,7 +466,7 @@ jQuery.extend({
 boolHook = {
        get: function( elem, name ) {
                // Align boolean attributes with corresponding properties
-               return elem[ jQuery.propFix[ name ] || name ] ?
+               return jQuery.prop( elem, name ) ?
                        name.toLowerCase() :
                        undefined;
        },

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index d2d43475dcfaecd044c4b43f2797d611ec56fa2b..efeb46e486b2dbb9809cb0396b103e5931e1617a 100644 (file)
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -40,7 +40,7 @@ test("jQuery.attrFix/jQuery.propFix integrity test", function() {
 });
 
 test("attr(String)", function() {
-       expect(37);
+       expect(38);
 
        equals( jQuery("#text1").attr("type"), "text", "Check for type attribute" );
        equals( jQuery("#radio1").attr("type"), "radio", "Check for type attribute" );
@@ -92,6 +92,12 @@ test("attr(String)", function() {
 
        body.removeAttribute("foo"); // Cleanup
 
+       var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
+       optgroup.appendChild( option );
+       select.appendChild( optgroup );
+
+       equal( jQuery( option ).attr("selected"), "selected", "Make sure that a single option is selected, even when in an optgroup." );
+
        var $img = jQuery("<img style='display:none' width='215' height='53' src='http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif'/>").appendTo("body");
        equals( $img.attr("width"), "215", "Retrieve width attribute an an element with display:none." );
        equals( $img.attr("height"), "53", "Retrieve height attribute an an element with display:none." );