]> source.dussan.org Git - poi.git/commitdiff
replace more StringBuffers
authorPJ Fanning <fanningpj@apache.org>
Thu, 21 Nov 2019 22:01:20 +0000 (22:01 +0000)
committerPJ Fanning <fanningpj@apache.org>
Thu, 21 Nov 2019 22:01:20 +0000 (22:01 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870121 13f79535-47bb-0310-9956-ffa450edef68

14 files changed:
src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java
src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
src/java/org/apache/poi/hssf/model/InternalSheet.java
src/java/org/apache/poi/hssf/record/MergeCellsRecord.java
src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java
src/java/org/apache/poi/hssf/usermodel/FontDetails.java
src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java
src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java
src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java
src/java/org/apache/poi/util/HexRead.java
src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java
src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java

index e6e55c0a27e790fb5ac7aaf7c831a58f2be99e3f..153dc5e205065bfc245675483ffd8d629dbdb3d5 100644 (file)
@@ -108,7 +108,7 @@ public class PropertySetDescriptorRenderer extends DocumentDescriptorRenderer
      */
     protected String sectionsToString(final List<Section> sections)
     {
-        final StringBuffer b = new StringBuffer();
+        final StringBuilder b = new StringBuilder();
         int count = 1;
         for (Iterator<Section>  i = sections.iterator(); i.hasNext();)
         {
@@ -129,7 +129,7 @@ public class PropertySetDescriptorRenderer extends DocumentDescriptorRenderer
      */
     protected String toString(final Section s, final String name)
     {
-        final StringBuffer b = new StringBuffer();
+        final StringBuilder b = new StringBuilder();
         b.append("\n" + name + " Format ID: ");
         b.append(HexDump.toHex(s.getFormatID().getBytes()));
         b.append("\n" + name + " Offset: " + s.getOffset());
index e49a66b2fe8b4ae38323ad4c3797e76ee0e09970..11f2d46369ff7d91161614686f89d851a6ee1ed7 100644 (file)
@@ -162,7 +162,7 @@ public class EventBasedExcelExtractor extends POIOLE2TextExtractor implements or
        private SSTRecord sstRecord;
 
        private final List<String> sheetNames;
-       final StringBuffer _text = new StringBuffer();
+       final StringBuilder _text = new StringBuilder();
        private int sheetNum = -1;
        private int rowNum;
 
index 4e8798e8866c6310d2c76d0e621e521301dd00df..1b2531aee7a3f9b109df1e104e7d4a2f5b07fd6e 100644 (file)
@@ -553,7 +553,7 @@ public final class InternalSheet {
         {
             log.log(POILogger.DEBUG, "Sheet.setDimensions");
             log.log(POILogger.DEBUG,
-                    (new StringBuffer("firstrow")).append(firstrow)
+                    (new StringBuilder("firstrow")).append(firstrow)
                         .append("firstcol").append(firstcol).append("lastrow")
                         .append(lastrow).append("lastcol").append(lastcol)
                         .toString());
index d1e5121154b3ea28be68002c7042c73cf5fa22a5..c71cbb2b66ca310c9b2cf0f406cabc251851969a 100644 (file)
@@ -90,7 +90,7 @@ public final class MergeCellsRecord extends StandardRecord implements Cloneable
 
     @Override
     public String toString() {
-        StringBuffer retval = new StringBuffer();
+        StringBuilder retval = new StringBuilder();
 
         retval.append("[MERGEDCELLS]").append("\n");
         retval.append("     .numregions =").append(getNumAreas()).append("\n");
index a41d2ca031e8680bcdab71b6347083f3f3f4e0a5..8d8a059cd4d6e1193e2fc5a142120913fe2cb733 100644 (file)
@@ -52,7 +52,7 @@ public final class PageItemRecord extends StandardRecord {
                        out.writeShort(_idObj);
                }
 
-               public void appendDebugInfo(StringBuffer sb) {
+               public void appendDebugInfo(StringBuilder sb) {
                        sb.append('(');
                        sb.append( "isxvi=").append(HexDump.shortToHex(_isxvi));
                        sb.append(" isxvd=").append(HexDump.shortToHex(_isxvd));
@@ -97,7 +97,7 @@ public final class PageItemRecord extends StandardRecord {
 
        @Override
        public String toString() {
-               StringBuffer sb = new StringBuffer();
+               StringBuilder sb = new StringBuilder();
 
                sb.append("[SXPI]\n");
                for (int i = 0; i < _fieldInfos.length; i++) {
index d40ec07fcd7c1eefb567503f65e5024221ae9be4..d9fc1d54c23edb5707c38cab4e7bb40b25634b45 100644 (file)
@@ -156,7 +156,7 @@ public class FontDetails
         {
             if(max != -1 && i == listSize - 1)
             {
-                StringBuffer buf = new StringBuffer((text.length() * (listSize - i)) / listSize);
+                StringBuilder buf = new StringBuilder((text.length() * (listSize - i)) / listSize);
                 while(tok.hasMoreTokens())
                 {
                     buf.append(tok.nextToken());
index 46ab79b10f355d1a59bc732300569af85f367c84..b9c7efc678a164c4820b82250518f8c27f21bc1e 100644 (file)
@@ -40,7 +40,7 @@ final class CellEvaluationFrame {
        }
 
        public String toString() {
-               StringBuffer sb = new StringBuffer(64);
+               StringBuilder sb = new StringBuilder(64);
                sb.append(getClass().getName()).append(" [");
                sb.append("]");
                return sb.toString();
index 0bb94659ee02f907bd3492a919a5e3f27a05cdda..005c91dface8a1d5dbbf3544574a9978f39f01f7 100644 (file)
@@ -158,7 +158,7 @@ final class FormulaUsedBlankCellSet {
                }
                @Override
         public String toString() {
-                       StringBuffer sb = new StringBuffer(64);
+                       StringBuilder sb = new StringBuilder(64);
                        CellReference crA = new CellReference(_firstRowIndex, _firstColumnIndex, false, false);
                        CellReference crB = new CellReference(_lastRowIndex, _lastColumnIndex, false, false);
                        sb.append(getClass().getName());
index 79dd23b92a24f170d736e739c158a6fead388251..b39c3223315164e3c9f5421a999bb7ff94af6774 100644 (file)
@@ -71,7 +71,7 @@ public class ErrorConstant {
        }
 
        public String toString() {
-               StringBuffer sb = new StringBuffer(64);
+               StringBuilder sb = new StringBuilder(64);
                sb.append(getClass().getName()).append(" [");
                sb.append(getText());
                sb.append("]");
index 0acaef6e278c576b32817af8612cfb61af754b7f..a7bec002f9269bf30e05667270cc4f9139175234 100644 (file)
@@ -55,7 +55,7 @@ public class HexRead {
      */
     public static byte[] readData(InputStream stream, String section ) throws IOException {
         try {
-            StringBuffer sectionText = new StringBuffer();
+            StringBuilder sectionText = new StringBuilder();
             boolean inSection = false;
             int c = stream.read();
             while ( c != -1 ) {
@@ -66,12 +66,12 @@ public class HexRead {
                     case '\n':
                     case '\r':
                         inSection = false;
-                        sectionText = new StringBuffer();
+                        sectionText = new StringBuilder();
                         break;
                     case ']':
                         inSection = false;
                         if ( sectionText.toString().equals( section ) ) return readData( stream, '[' );
-                        sectionText = new StringBuffer();
+                        sectionText = new StringBuilder();
                         break;
                     default:
                         if ( inSection ) sectionText.append( (char) c );
index ec1dc82b750194596152011ec16aa105c72927a8..27f62aeeec9aa3713e65bb6c0dcf2aa4efc84598 100644 (file)
@@ -61,7 +61,7 @@ public final class PublisherTextExtractor extends POIOLE2TextExtractor {
 
 
        public String getText() {
-               StringBuffer text = new StringBuffer();
+               StringBuilder text = new StringBuilder();
 
                // Get the text from the Quill Contents
                QCBit[] bits = doc.getQuillContents().getBits();
index 372c52d9ad6b8f2649bc04786619203e7dfad840..c0d13c0e64f484f9bad0ae47294e802311e33ff2 100644 (file)
@@ -369,13 +369,11 @@ public final class StyleTextPropAtom extends RecordAtom {
 
 
     /**
-     * Dump the record content into <code>StringBuffer</code>
-     *
      * @return the string representation of the record data
      */
     @Override
     public String toString(){
-        StringBuffer out = new StringBuffer();
+        StringBuilder out = new StringBuilder();
 
         out.append("StyleTextPropAtom:\n");
         if (!initialised) {
index 9d9c277def30fc4f5c30a1b7610a2c1a5715eb0f..46056ff82e7d02f5e0bbec057dc255103742bc80 100644 (file)
@@ -359,16 +359,6 @@ public final class TestBugs extends BaseTestBugzillaIssues {
         assertEquals(a.getRichStringCellValue().getString(), b.getRichStringCellValue().getString());
     }
 
-    /*private static String unicodeString(HSSFCell cell) {
-        String ss = cell.getRichStringCellValue().getString();
-        char s[] = ss.toCharArray();
-        StringBuffer sb = new StringBuffer();
-        for (int x=0;x<s.length;x++) {
-            sb.append("\\u").append(Integer.toHexString(s[x]));
-        }
-        return sb.toString();
-    }*/
-
     /**
      * Error in opening wb
      */
index fe868dbdd92274c72f70c44e3af23c98403b1d6d..ac2551665dd798447eecc1e914ee74972907e018 100644 (file)
@@ -111,7 +111,7 @@ public final class ExcelFileFormatDocFunctionExtractor {
                        _isVolatile = isVolatile;
                }
                private static String convertSpecialChars(String ss) {
-                       StringBuffer sb = new StringBuffer(ss.length() + 4);
+                       StringBuilder sb = new StringBuilder(ss.length() + 4);
                        for(int i=0; i<ss.length(); i++) {
                                char c = ss.charAt(i);
                                if (isSimpleAscii(c)) {
@@ -256,7 +256,7 @@ public final class ExcelFileFormatDocFunctionExtractor {
                private boolean _isInsideTable;
 
                private final List<String> _rowData;
-               private final StringBuffer _textNodeBuffer;
+               private final StringBuilder _textNodeBuffer;
                private final List<Boolean> _rowNoteFlags;
                private boolean _cellHasNote;
 
@@ -268,7 +268,7 @@ public final class ExcelFileFormatDocFunctionExtractor {
                        _elemNameStack = new Stack<>();
                        _isInsideTable = false;
                        _rowData = new ArrayList<>();
-                       _textNodeBuffer = new StringBuffer();
+                       _textNodeBuffer = new StringBuilder();
                        _rowNoteFlags = new ArrayList<>();
                }