]> source.dussan.org Git - vaadin-framework.git/commitdiff
Remove unused caption from Column constructor (#8077)
authorPekka Hyvönen <pekka@vaadin.com>
Thu, 22 Dec 2016 14:04:48 +0000 (16:04 +0200)
committerGitHub <noreply@github.com>
Thu, 22 Dec 2016 14:04:48 +0000 (16:04 +0200)
* Remove unused caption from Column constructor

Fixes #8063

server/src/main/java/com/vaadin/ui/Grid.java

index 8b07501f079caa83f5bebec749cfc3c8e3b6d1fb..592a811f212142e91835bb8f64e4f8db52a7a339 100644 (file)
@@ -796,8 +796,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
          * @param renderer
          *            the type of value
          */
-        protected Column(String caption,
-                ValueProvider<T, ? extends V> valueProvider,
+        protected Column(ValueProvider<T, ? extends V> valueProvider,
                 Renderer<V> renderer) {
             Objects.requireNonNull(valueProvider,
                     "Value provider can't be null");
@@ -1882,8 +1881,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
             ValueProvider<T, ? extends V> valueProvider,
             AbstractRenderer<? super T, V> renderer) {
         String generatedIdentifier = getGeneratedIdentifier();
-        Column<T, V> column = new Column<>("Column " + generatedIdentifier,
-                valueProvider, renderer);
+        Column<T, V> column = new Column<>(valueProvider, renderer);
         addColumn(generatedIdentifier, column);
         return column;
     }
@@ -3023,7 +3021,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
             String id = DesignAttributeHandler.readAttribute("column-id",
                     col.attributes(), null, String.class);
             DeclarativeValueProvider<T> provider = new DeclarativeValueProvider<>();
-            Column<T, String> column = new Column<>("", provider,
+            Column<T, String> column = new Column<>(provider,
                     new HtmlRenderer());
             addColumn(getGeneratedIdentifier(), column);
             if (id != null) {