Fix bug #46664 - When creating HSSF Print Areas, ensure the named range is reference...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1069780 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml
index 9d8639c9c019eeaceca64ca1a1dd879235846c2f..ef158f1f93f93184fc0d4e588201250d40c532b3 100644 (file)
--- a/src/documentation/content/xdocs/status.xml
+++ b/src/documentation/content/xdocs/status.xml
@@ -34,6 +34,7 @@
 
     <changes>
         <release version="3.8-beta1" date="2010-??-??">
+           <action dev="poi-developers" type="fix">46664 - When creating HSSF Print Areas, ensure the named range is reference based not value based</action>
            <action dev="poi-developers" type="fix">50756 - When formatting numbers based on their Cell Style, treat GENERAL the same as the more typical General</action>
            <action dev="poi-developers" type="fix">fixed HSSFWorkbook.createCellStyle to throw exception if the maximum number of cell styles was exceeded</action>
            <action dev="poi-developers" type="fix">50539 - Better fix for html-style br tags (invalid XML) inside XSSF documents</action>

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
index 20b5712f18438e2513939dd081017b9781350878..53867ecf952e69ede920d1a53322a9a4e5dacbbc 100644 (file)
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
@@ -1389,7 +1389,7 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss
             sb.append("!");
             sb.append(parts[i]);
         }
-        name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.CELL, sheetIndex));
+        name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.NAMEDRANGE, sheetIndex));
     }
 
     /**

diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
index 440f3a3953c6791b5f59c80bfffb52fa986399c1..ae54b4aaac1396a8961dd6905614372d16f57a58 100644 (file)
--- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
+++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
@@ -1650,10 +1650,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
              "new_sheet!$A$1:$C$1", 
              ((Area3DPtg)nr.getNameDefinition()[0]).toFormulaString(HSSFEvaluationWorkbook.create(wb))
        );
-       // TODO - fix me to be Reference not Value!
-if(1==2) {       
        assertEquals('R', nr.getNameDefinition()[0].getRVAType());
-}
     }
     
     /**