Only use realpath for real directories (#26060)

In some cross-local-storage use cases, the Local storage is
instantiated with "/" as data directory. In such cases, calling
realpath() would cause PHP warnings when open_basedir is set.

This fix bypasses the realpath() call when dealing with a root storage.

Downstreaming of https://github.com/owncloud/core/pull/26060

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php
index 19674fc9413745a86a1da7b009307e4a0849e81a..0d63fd46ecca8587cb82de8b79a3330c78500c11 100644 (file)
--- a/lib/private/Files/Storage/Local.php
+++ b/lib/private/Files/Storage/Local.php
@@ -54,7 +54,12 @@ class Local extends \OC\Files\Storage\Common {
                        throw new \InvalidArgumentException('No data directory set for local storage');
                }
                $this->datadir = $arguments['datadir'];
-               $this->realDataDir = rtrim(realpath($this->datadir), '/') . '/';
+               // some crazy code uses a local storage on root...
+               if ($this->datadir === '/') {
+                       $this->realDataDir = $this->datadir;
+               } else {
+                       $this->realDataDir = rtrim(realpath($this->datadir), '/') . '/';
+               }
                if (substr($this->datadir, -1) !== '/') {
                        $this->datadir .= '/';
                }