SONAR-3054 Change some Findbugs rule titles

diff --git a/plugins/sonar-findbugs-plugin/src/main/resources/org/sonar/plugins/findbugs/rules.xml b/plugins/sonar-findbugs-plugin/src/main/resources/org/sonar/plugins/findbugs/rules.xml
index 21354a6c85222b7953c639af1877099909a34e15..4c2de7efcbda0da15cb3ee3be1975aa6b3fdfcf9 100644 (file)
--- a/plugins/sonar-findbugs-plugin/src/main/resources/org/sonar/plugins/findbugs/rules.xml
+++ b/plugins/sonar-findbugs-plugin/src/main/resources/org/sonar/plugins/findbugs/rules.xml
@@ -1475,7 +1475,7 @@
   </rule>
   <rule key="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Method call passes null for nonnull parameter]]></name>
+    <name><![CDATA[Correctness - Method call passes null for nonnull parameter (ALL_TARGETS_DANGEROUS)]]></name>
     <configKey><![CDATA[NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS]]></configKey>
 
 
@@ -1825,7 +1825,7 @@
   </rule>
   <rule key="BIT_AND">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Incompatible bit masks]]></name>
+    <name><![CDATA[Correctness - Incompatible bit masks (BIT_AND)]]></name>
     <configKey><![CDATA[BIT_AND]]></configKey>
 
 
@@ -1853,7 +1853,7 @@
   </rule>
   <rule key="BIT_IOR">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Incompatible bit masks]]></name>
+    <name><![CDATA[Correctness - Incompatible bit masks (BIT_IOR)]]></name>
     <configKey><![CDATA[BIT_IOR]]></configKey>
 
 
@@ -2373,7 +2373,7 @@
   </rule>
   <rule key="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Invocation of toString on an array]]></name>
+    <name><![CDATA[Correctness - Invocation of toString on an anonymous array]]></name>
     <configKey><![CDATA[DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY]]></configKey>
 
 
@@ -2559,14 +2559,14 @@
   </rule>
   <rule key="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Explicit annotation inconsistent with use]]></name>
+    <name><![CDATA[Correctness -  Value required to not have type qualifier, but marked as unknown]]></name>
     <configKey><![CDATA[TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK]]></configKey>
 
 
   </rule>
   <rule key="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">
     <priority>CRITICAL</priority>
-    <name><![CDATA[Correctness - Explicit annotation inconsistent with use]]></name>
+    <name><![CDATA[Correctness - Value required to have type qualifier, but marked as unknown]]></name>
     <configKey><![CDATA[TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK]]></configKey>
 
 

diff --git a/plugins/sonar-l10n-en-plugin/src/main/resources/org/sonar/l10n/findbugs.properties b/plugins/sonar-l10n-en-plugin/src/main/resources/org/sonar/l10n/findbugs.properties
index 17249fb96abc8b2413ec630ebf9ba7677fd7476e..fd373090b7548c813c33d0e60beb86971d226d05 100644 (file)
--- a/plugins/sonar-l10n-en-plugin/src/main/resources/org/sonar/l10n/findbugs.properties
+++ b/plugins/sonar-l10n-en-plugin/src/main/resources/org/sonar/l10n/findbugs.properties
@@ -29,7 +29,7 @@ rule.findbugs.FI_EMPTY.name=Bad practice - Empty finalizer should be deleted
 rule.findbugs.CD_CIRCULAR_DEPENDENCY.name=Experimental - Test for circular dependencies among classes
 rule.findbugs.EC_UNRELATED_TYPES.name=Correctness - Call to equals() comparing different types
 rule.findbugs.EI_EXPOSE_STATIC_REP2.name=Malicious code vulnerability - May expose internal static state by storing a mutable object into a static field
-rule.findbugs.DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY.name=Correctness - Invocation of toString on an array
+rule.findbugs.DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY.name=Correctness - Invocation of toString on an anonymous array
 rule.findbugs.SIC_INNER_SHOULD_BE_STATIC_ANON.name=Performance - Could be refactored into a named static inner class
 rule.findbugs.STI_INTERRUPTED_ON_UNKNOWNTHREAD.name=Correctness - Static Thread.interrupted() method invoked on thread instance
 rule.findbugs.CN_IDIOM_NO_SUPER_CALL.name=Bad practice - clone method does not call super.clone()
@@ -37,7 +37,7 @@ rule.findbugs.VA_FORMAT_STRING_BAD_ARGUMENT.name=Correctness - Format string pla
 rule.findbugs.EQ_DOESNT_OVERRIDE_EQUALS.name=Dodgy - Class doesn't override equals in superclass
 rule.findbugs.BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY.name=Correctness - Impossible downcast of toArray() result
 rule.findbugs.SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION.name=Bad practice - Class is Externalizable but doesn't define a void constructor
-rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK.name=Correctness - Explicit annotation inconsistent with use
+rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK.name=Correctness - Value required to have type qualifier, but marked as unknown
 rule.findbugs.SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS.name=Performance - Could be refactored into a static inner class
 rule.findbugs.EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS.name=Bad practice - Equals checks for noncompatible operand
 rule.findbugs.RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED.name=Correctness - Return value of putIfAbsent ignored, value passed to putIfAbsent reused
@@ -93,9 +93,9 @@ rule.findbugs.ML_SYNC_ON_UPDATED_FIELD.name=Multithreaded correctness - Method s
 rule.findbugs.CO_SELF_NO_OBJECT.name=Bad practice - Covariant compareTo() method defined
 rule.findbugs.BC_UNCONFIRMED_CAST.name=Dodgy - Unchecked/unconfirmed cast
 rule.findbugs.FI_FINALIZER_NULLS_FIELDS.name=Bad practice - Finalizer nulls fields
-rule.findbugs.BIT_AND.name=Correctness - Incompatible bit masks
+rule.findbugs.BIT_AND.name=Correctness - Incompatible bit masks (BIT_AND)
 rule.findbugs.FE_FLOATING_POINT_EQUALITY.name=Dodgy - Test for floating point equality
-rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK.name=Correctness - Explicit annotation inconsistent with use
+rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK.name=Correctness - Value required to not have type qualifier, but marked as unknown
 rule.findbugs.NP_NULL_PARAM_DEREF.name=Correctness - Method call passes null for nonnull parameter
 rule.findbugs.FB_MISSING_EXPECTED_WARNING.name=Experimental - Missing expected or desired warning from FindBugs
 rule.findbugs.DMI_INVOKING_HASHCODE_ON_ARRAY.name=Correctness - Invocation of hashCode on an array
@@ -170,7 +170,7 @@ rule.findbugs.EQ_ALWAYS_FALSE.name=Correctness - equals method always returns fa
 rule.findbugs.DMI_RANDOM_USED_ONLY_ONCE.name=Bad practice - Random object created and used only once
 rule.findbugs.NM_CLASS_NOT_EXCEPTION.name=Bad practice - Class is not derived from an Exception, even though it is named as such
 rule.findbugs.SA_LOCAL_DOUBLE_ASSIGNMENT.name=Dodgy - Double assignment of local variable
-rule.findbugs.NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS.name=Correctness - Method call passes null for nonnull parameter
+rule.findbugs.NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS.name=Correctness - Method call passes null for nonnull parameter (ALL_TARGETS_DANGEROUS)
 rule.findbugs.NP_TOSTRING_COULD_RETURN_NULL.name=Bad practice - toString method may return null
 rule.findbugs.BC_BAD_CAST_TO_ABSTRACT_COLLECTION.name=Dodgy - Questionable cast to abstract collection
 rule.findbugs.NM_LCASE_HASHCODE.name=Class defines hashcode(); should it be hashCode()?
@@ -285,7 +285,7 @@ rule.findbugs.SR_NOT_CHECKED.name=Bad practice - Method ignores results of Input
 rule.findbugs.LI_LAZY_INIT_STATIC.name=Multithreaded correctness - Incorrect lazy initialization of static field
 rule.findbugs.DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION.name=Correctness - Can't use reflection to check for presence of annotation without runtime retention
 rule.findbugs.ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH.name=Bad practice - Method may fail to close database resource on exception
-rule.findbugs.BIT_IOR.name=Correctness - Incompatible bit masks
+rule.findbugs.BIT_IOR.name=Correctness - Incompatible bit masks (BIT_IOR)
 rule.findbugs.ODR_OPEN_DATABASE_RESOURCE.name=Bad practice - Method may fail to close database resource
 rule.findbugs.IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN.name=Correctness - A parameter is dead upon entry to a method but overwritten
 rule.findbugs.SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING.name=Security - A prepared statement is generated from a nonconstant String