]> source.dussan.org Git - poi.git/commitdiff
try to fix broken sxssf tests
authorPJ Fanning <fanningpj@apache.org>
Tue, 7 Nov 2023 12:23:53 +0000 (12:23 +0000)
committerPJ Fanning <fanningpj@apache.org>
Tue, 7 Nov 2023 12:23:53 +0000 (12:23 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913651 13f79535-47bb-0310-9956-ffa450edef68

poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java
poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java
poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java

index 2670a6e291908311c8cad6a96bd3c79d19feab5c..894bc5c9941c43a5c361d602cd79638d6fc869b7 100644 (file)
@@ -165,10 +165,7 @@ class TestSXSSFCell extends BaseTestXCell {
     protected void setCellFormula_onASingleCellArrayFormulaCell_preservesTheValue() {
     }
 
-    @Disabled
-    protected void setCellFormula_isExceptionSafe_onBlankCell() {
-    }
-
+    @Override
     @Disabled
     protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() {
     }
index ac5f209146ddb0c022942b411e8bb5f3b7c5486d..63d5f4fcee875fc45c23e8ff8defb1e8c3c3cb47 100644 (file)
@@ -48,7 +48,10 @@ public final class TestSXSSFFormulaEvaluation  extends BaseTestFormulaEvaluator
         super(SXSSFITestDataProvider.instance);
     }
 
-    void testSharedFormulas() throws IOException {
+
+    @Override
+    @Disabled
+    protected void testSharedFormulas() throws IOException {
         /* not implemented */
     }
 
index 71cbfbb7e9826b639f5ae36ce0572c5c48ac1ae3..e69b5abbb2d972a2fe09d86ec2849e5fa271237e 100644 (file)
@@ -1408,7 +1408,7 @@ public abstract class BaseTestCell {
     }
 
     @Test
-    void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() throws IOException {
+    protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() throws IOException {
         try (Workbook wb = _testDataProvider.createWorkbook()) {
             Cell cell = getInstance(wb);
             cell.getSheet().setArrayFormula("3", CellRangeAddress.valueOf("A1:A2"));
index 8f621a14280eb9b8ef8a7e5ca055bd54e34df27c..def6e2c18514e8fb76cf353988f2cdc00158e65e 100644 (file)
@@ -117,7 +117,7 @@ public abstract class BaseTestFormulaEvaluator {
     }
 
     @Test
-    void testSharedFormulas() throws IOException {
+    protected void testSharedFormulas() throws IOException {
         String fileName = "shared_formulas.xls" + (getClass().getName().contains("xssf") ? "x" : "");
         try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) {