]> source.dussan.org Git - redmine.git/commitdiff
Backported r15196 to 2.6-stable (#22072).
authorJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 12 Mar 2016 10:10:04 +0000 (10:10 +0000)
committerJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 12 Mar 2016 10:10:04 +0000 (10:10 +0000)
git-svn-id: http://svn.redmine.org/redmine/branches/2.6-stable@15209 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/models/issue.rb
test/unit/issue_test.rb

index 0d52c8f0e9b747585e703b7bbdc9b2a1ebe88086..d8f2cadcf5edb353be4ffef06d022e33050256b5 100644 (file)
@@ -1484,6 +1484,7 @@ class Issue < ActiveRecord::Base
         # Same user and notes
         if @current_journal
           duplicate.init_journal(@current_journal.user, @current_journal.notes)
+          duplicate.private_notes = @current_journal.private_notes
         end
         duplicate.update_attribute :status, self.status
       end
index a5804af722b9617b74f01077174c415aa76e5932..10a003b56e9c9a364bb579c25493b3008cb15575 100644 (file)
@@ -1120,6 +1120,25 @@ class IssueTest < ActiveSupport::TestCase
     assert issue3.reload.closed?
   end
 
+  def test_should_close_duplicates_with_private_notes
+    issue = Issue.generate!
+    duplicate = Issue.generate!
+    IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
+                          :relation_type => IssueRelation::TYPE_DUPLICATES)
+    assert issue.reload.duplicates.include?(duplicate)
+
+    # Closing issue with private notes
+    issue = Issue.find(issue.id)
+    issue.init_journal(User.first, "Private notes")
+    issue.private_notes = true
+    issue.status = IssueStatus.where(:is_closed => true).first
+    assert_save issue
+
+    duplicate.reload
+    assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
+    assert_equal true, journal.private_notes
+  end
+
   def test_should_not_close_duplicated_issue
     issue1 = Issue.generate!
     issue2 = Issue.generate!