]> source.dussan.org Git - vaadin-framework.git/commitdiff
Simplify lambda expressions (#10198)
authorAhmed Ashour <asashour@yahoo.com>
Fri, 20 Oct 2017 06:59:17 +0000 (08:59 +0200)
committerPéter Török <31210544+torok-peter@users.noreply.github.com>
Fri, 20 Oct 2017 06:59:17 +0000 (09:59 +0300)
* Simplify lambda expressions

And remove unneeded 'return' keyword.

* Format

82 files changed:
client/src/main/java/com/vaadin/client/ResourceLoader.java
client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
client/src/main/java/com/vaadin/client/extensions/DragSourceExtensionConnector.java
client/src/main/java/com/vaadin/client/ui/VRichTextArea.java
client/src/main/java/com/vaadin/client/ui/richtextarea/RichTextAreaConnector.java
client/src/main/java/com/vaadin/client/ui/textarea/TextAreaConnector.java
client/src/main/java/com/vaadin/client/ui/textfield/TextFieldConnector.java
client/src/main/java/com/vaadin/client/ui/treegrid/TreeGridConnector.java
liferay-integration/src/main/java/com/vaadin/osgi/liferay/OsgiUIProvider.java
server/src/main/java/com/vaadin/data/Validator.java
server/src/main/java/com/vaadin/data/converter/StringToBigIntegerConverter.java
server/src/main/java/com/vaadin/data/converter/StringToDoubleConverter.java
server/src/main/java/com/vaadin/data/converter/StringToFloatConverter.java
server/src/main/java/com/vaadin/data/converter/StringToIntegerConverter.java
server/src/main/java/com/vaadin/data/converter/StringToLongConverter.java
server/src/main/java/com/vaadin/data/provider/InMemoryDataProviderHelpers.java
server/src/main/java/com/vaadin/navigator/Navigator.java
server/src/main/java/com/vaadin/server/communication/FileUploadHandler.java
server/src/main/java/com/vaadin/server/communication/PushRequestHandler.java
server/src/main/java/com/vaadin/ui/AbstractComponent.java
server/src/main/java/com/vaadin/ui/ComboBox.java
server/src/main/java/com/vaadin/ui/CssLayout.java
server/src/main/java/com/vaadin/ui/Grid.java
server/src/main/java/com/vaadin/ui/GridLayout.java
server/src/main/java/com/vaadin/ui/Image.java
server/src/main/java/com/vaadin/ui/Notification.java
server/src/main/java/com/vaadin/ui/Panel.java
server/src/main/java/com/vaadin/ui/components/grid/GridDragSource.java
server/src/main/java/com/vaadin/ui/declarative/Design.java
server/src/main/java/com/vaadin/ui/dnd/DropTargetExtension.java
server/src/test/java/com/vaadin/data/BinderConverterValidatorTest.java
server/src/test/java/com/vaadin/data/BinderTest.java
server/src/test/java/com/vaadin/data/BinderValidationStatusTest.java
server/src/test/java/com/vaadin/data/ValidatorTest.java
server/src/test/java/com/vaadin/server/VaadinServiceTest.java
server/src/test/java/com/vaadin/tests/data/converter/ConverterTest.java
server/src/test/java/com/vaadin/tests/design/designroot/ExtendedDesignWithEmptyAnnotation.java
server/src/test/java/com/vaadin/tests/server/component/button/ButtonClickTest.java
server/src/test/java/com/vaadin/tests/server/component/window/AttachDetachWindowTest.java
server/src/test/java/com/vaadin/tests/server/navigator/NavigatorTest.java
server/src/test/java/com/vaadin/ui/CheckBoxTest.java
test/servlet-containers/karaf/vaadin-karaf-bundle1/src/main/java/com/vaadin/test/osgi/myapplication1/MyUI.java
test/servlet-containers/karaf/vaadin-karaf-bundle2/src/main/java/com/vaadin/test/osgi/myapplication/MyUI.java
uitest/src/main/java/com/vaadin/tests/components/abstractlisting/AbstractListingTestUI.java
uitest/src/main/java/com/vaadin/tests/components/abstractlisting/AbstractSingleSelectTestUI.java
uitest/src/main/java/com/vaadin/tests/components/abstractsingleselect/AbstractSingleSelection.java
uitest/src/main/java/com/vaadin/tests/components/composite/CompositeChainUI.java
uitest/src/main/java/com/vaadin/tests/components/datefield/DateFieldElementUI.java
uitest/src/main/java/com/vaadin/tests/components/datefield/DateTimeFieldElementUI.java
uitest/src/main/java/com/vaadin/tests/components/draganddropwrapper/DragAndDropFocusObtain.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridAriaMultiselectable.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridAriaRowcount.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridColspans.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridColumnWidthsWithoutData.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridDetailsLayoutExpand.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridHeaderFooterComponents.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridResizeHiddenColumn.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridRowHeightChange.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridScrollToLineWhileResizing.java
uitest/src/main/java/com/vaadin/tests/components/grid/basics/GridBasics.java
uitest/src/main/java/com/vaadin/tests/components/gridlayout/GridLayoutWithLabel.java
uitest/src/main/java/com/vaadin/tests/components/javascriptcomponent/DuplicateJavascriptDependencies.java
uitest/src/main/java/com/vaadin/tests/components/loginform/LoginFormUI.java
uitest/src/main/java/com/vaadin/tests/components/richtextarea/ConfigurableRichTextAreaUI.java
uitest/src/main/java/com/vaadin/tests/components/textfield/TextFieldEmptyingPrompt.java
uitest/src/main/java/com/vaadin/tests/components/tree/TreeBasicFeatures.java
uitest/src/main/java/com/vaadin/tests/components/treegrid/TreeGridAriaRowcount.java
uitest/src/main/java/com/vaadin/tests/components/treegrid/TreeGridDragAndDrop.java
uitest/src/main/java/com/vaadin/tests/components/treegrid/TreeGridInWindow.java
uitest/src/main/java/com/vaadin/tests/data/DummyData.java
uitest/src/main/java/com/vaadin/tests/data/GridRefreshWithGetId.java
uitest/src/main/java/com/vaadin/tests/dnd/DragAndDropCardShuffle.java
uitest/src/main/java/com/vaadin/tests/dnd/Html5FileDragAndDropUpload.java
uitest/src/main/java/com/vaadin/tests/elements/ComponentElementGetValue.java
uitest/src/main/java/com/vaadin/tests/elements/combobox/ComboBoxInputNotAllowed.java
uitest/src/main/java/com/vaadin/tests/elements/combobox/ComboBoxUI.java
uitest/src/main/java/com/vaadin/tests/elements/combobox/SelectByText.java
uitest/src/main/java/com/vaadin/tests/elements/grid/GridUI.java
uitest/src/main/java/com/vaadin/tests/layouts/gridlayout/GridLayoutCaptionOnBottomAlignedComponent.java
uitest/src/main/java/com/vaadin/tests/navigator/DelayedViewLeaveConfirmation.java
uitest/src/main/java/com/vaadin/tests/resources/FrontendLaterLoadedResourceUI.java
uitest/src/test/java/com/vaadin/tests/components/tree/TreeBasicFeaturesTest.java

index ebd0ecbb17f9d70cff88a2ebe75a66d6ca5223a3..62c41b60674426cd5f83a37c04af55f81d2c6cb3 100644 (file)
@@ -492,9 +492,7 @@ public class ResourceLoader {
      */
     protected void runWhenHtmlImportsReady(Runnable runnable) {
         if (GWT.isClient() && supportsHtmlWhenReady()) {
-            addHtmlImportsReadyHandler(() -> {
-                runnable.run();
-            });
+            addHtmlImportsReadyHandler(() -> runnable.run());
         } else {
             runnable.run();
         }
index 41602fbcef6137f0cdf2dce3358fad6490089f37..4e7055677eb35cbdff505ca706f4eb4bce35d855 100644 (file)
@@ -254,7 +254,8 @@ public class GridConnector extends AbstractListingConnector
         getWidget().setRowStyleGenerator(rowRef -> {
             JsonObject json = rowRef.getRow();
             return json.hasKey(GridState.JSONKEY_ROWSTYLE)
-                    ? json.getString(GridState.JSONKEY_ROWSTYLE) : null;
+                    ? json.getString(GridState.JSONKEY_ROWSTYLE)
+                    : null;
         });
         getWidget().setCellStyleGenerator(cellRef -> {
             JsonObject row = cellRef.getRow();
@@ -401,10 +402,9 @@ public class GridConnector extends AbstractListingConnector
 
     private void updateStaticRow(RowState rowState,
             Grid.StaticSection.StaticRow row) {
-        rowState.cells.forEach((columnId, cellState) -> {
-            updateStaticCellFromState(row.getCell(getColumn(columnId)),
-                    cellState);
-        });
+        rowState.cells
+                .forEach((columnId, cellState) -> updateStaticCellFromState(
+                        row.getCell(getColumn(columnId)), cellState));
         for (Map.Entry<CellState, Set<String>> cellGroupEntry : rowState.cellGroups
                 .entrySet()) {
             Set<String> group = cellGroupEntry.getValue();
index b91b0aace0da0bf17339e4793abd794ab4357001..cb2870cf7a370ef8e42e91693c1d7801474d8917 100644 (file)
@@ -277,9 +277,8 @@ public class DragSourceExtensionConnector extends AbstractExtensionConnector {
                 WidgetUtil.getRelativeX(draggedElement, dragStartEvent)
                         - transformXOffset,
                 WidgetUtil.getRelativeY(draggedElement, dragStartEvent));
-        AnimationScheduler.get().requestAnimationFrame(timestamp -> {
-            clonedElement.removeFromParent();
-        }, clonedElement);
+        AnimationScheduler.get().requestAnimationFrame(
+                timestamp -> clonedElement.removeFromParent(), clonedElement);
     }
 
     /**
@@ -362,10 +361,10 @@ public class DragSourceExtensionConnector extends AbstractExtensionConnector {
                     .trim();
             return Integer.parseInt(x);
         } catch (NumberFormatException nfe) {
-            Logger.getLogger(DragSourceExtensionConnector.class.getName())
-                    .info("Unable to parse \"transform: translate(...)\" matrix "
-                            + n + ". value from computed style, matrix \""
-                            + matrix + "\", drag image might not be visible");
+            Logger.getLogger(DragSourceExtensionConnector.class.getName()).info(
+                    "Unable to parse \"transform: translate(...)\" matrix " + n
+                            + ". value from computed style, matrix \"" + matrix
+                            + "\", drag image might not be visible");
         }
         return 0;
     }
@@ -393,9 +392,11 @@ public class DragSourceExtensionConnector extends AbstractExtensionConnector {
             return;
         }
         style.clearProperty("transform");
-        AnimationScheduler.get().requestAnimationFrame(timestamp -> {
-            draggedElement.getStyle().setProperty("transform", transition);
-        }, draggedElement);
+        AnimationScheduler.get()
+                .requestAnimationFrame(
+                        timestamp -> draggedElement.getStyle()
+                                .setProperty("transform", transition),
+                        draggedElement);
     }
 
     /**
index b0f9a6a5103655871b86fe9c6fe3615661dd9fa2..a4d8147f8111aeb2866f43a699fc146c8e4b45f4 100644 (file)
@@ -120,9 +120,8 @@ public class VRichTextArea extends Composite implements Field, KeyPressHandler,
             // Must wait until iframe is attached to be able to access body
             BodyElement rtaBody = IFrameElement.as(rta.getElement())
                     .getContentDocument().getBody();
-            addInputListener(rtaBody, event -> {
-                inputHandlers.forEach(handler -> handler.execute());
-            });
+            addInputListener(rtaBody, event -> inputHandlers
+                    .forEach(handler -> handler.execute()));
         });
 
         formatter = new VRichTextToolbar(rta);
index 8911682e0a55d38ec59d2e50bfbb5b3590a53109..0e117a81c0f1a4b7e390093c24bd2221429f97b7 100644 (file)
@@ -54,9 +54,8 @@ public class RichTextAreaConnector extends AbstractFieldConnector
                 flush();
             }
         });
-        getWidget().addInputHandler(() -> {
-            valueChangeHandler.scheduleValueChange();
-        });
+        getWidget().addInputHandler(
+                () -> valueChangeHandler.scheduleValueChange());
 
         registerRpc(RichTextAreaClientRpc.class,
                 new RichTextAreaClientRpcImpl());
index 79f529ae5e8f49edbd29c29abbf5a5db205f4bb2..9a044f0e5c0b7633e0f5edacb6f0cb74c1375261 100644 (file)
@@ -44,9 +44,9 @@ public class TextAreaConnector extends AbstractTextFieldConnector {
     protected void init() {
         super.init();
         getWidget().addChangeHandler(event -> sendValueChange());
-        getWidget().addDomHandler(event -> {
-            getValueChangeHandler().scheduleValueChange();
-        }, InputEvent.getType());
+        getWidget().addDomHandler(
+                event -> getValueChangeHandler().scheduleValueChange(),
+                InputEvent.getType());
 
         getWidget().addMouseUpHandler(new ResizeMouseUpHandler());
     }
index 84e8e7401b3c3444896fcf360654a13ff97aa1df..e08f67093ff315275b7e649cd9e3295326a38fe4 100644 (file)
@@ -32,9 +32,9 @@ public class TextFieldConnector extends AbstractTextFieldConnector {
     protected void init() {
         super.init();
         getWidget().addChangeHandler(event -> sendValueChange());
-        getWidget().addDomHandler(event -> {
-            getValueChangeHandler().scheduleValueChange();
-        }, InputEvent.getType());
+        getWidget().addDomHandler(
+                event -> getValueChangeHandler().scheduleValueChange(),
+                InputEvent.getType());
     }
 
     @Override
index c50da18e53c4f9069fbf31b41f2c3fa009a915a9..847b55630a613f78432c5a4d090b39b333b640a5 100644 (file)
@@ -64,9 +64,8 @@ public class TreeGridConnector extends GridConnector {
     }
 
     public TreeGridConnector() {
-        registerRpc(FocusRpc.class, (rowIndex, cellIndex) -> {
-            getWidget().focusCell(rowIndex, cellIndex);
-        });
+        registerRpc(FocusRpc.class, (rowIndex, cellIndex) -> getWidget()
+                .focusCell(rowIndex, cellIndex));
     }
 
     private String hierarchyColumnId;
@@ -237,7 +236,7 @@ public class TreeGridConnector extends GridConnector {
             GridEventHandler<?> eventHandler)
     /*-{
         var browserEventHandlers = grid.@com.vaadin.client.widgets.Grid::browserEventHandlers;
-    
+
         // FocusEventHandler is initially 5th in the list of browser event handlers
         browserEventHandlers.@java.util.List::set(*)(5, eventHandler);
     }-*/;
index bdf50aa0d1a5333569df012c4a6aa7c5869432d7..ccbb28581f689ecacb12b2437f064df59ee1dfe7 100644 (file)
@@ -72,15 +72,11 @@ public class OsgiUIProvider extends UIProvider {
     public UI createInstance(UICreateEvent event) {
         if (prototype) {
             UI ui = serviceObjects.getService();
-            ui.addDetachListener(e -> {
-                serviceObjects.ungetService(ui);
-            });
+            ui.addDetachListener(e -> serviceObjects.ungetService(ui));
             return ui;
         }
-        logService.ifPresent(log -> {
-            log.log(LogService.LOG_WARNING,
-                    "UI services should have a prototype scope! Creating UI instance using the default constructor!");
-        });
+        logService.ifPresent(log -> log.log(LogService.LOG_WARNING,
+                "UI services should have a prototype scope! Creating UI instance using the default constructor!"));
         return super.createInstance(event);
     }
 
index 4f8f4dc8ca2a1784c5fec773cc3d5f0fb509c25e..be6b89188ab754cc2e0a0d41169737ceb05acfc1 100644 (file)
@@ -186,10 +186,9 @@ public interface Validator<T>
             try {
                 if (guard.test(value)) {
                     return ValidationResult.ok();
-                } else {
-                    return ValidationResult.create(
-                            errorMessageProvider.apply(context), errorLevel);
                 }
+                return ValidationResult.create(
+                        errorMessageProvider.apply(context), errorLevel);
             } catch (Exception e) {
                 return ValidationResult.create(
                         errorMessageProvider.apply(context), errorLevel);
index 40683abb22f43aa928d6cfb74a56fd4ce333fbeb..840f6ae8c0d7a0c682afad1cdd2d8c47a08ce87c 100644 (file)
@@ -84,13 +84,12 @@ public class StringToBigIntegerConverter
                 .map(number -> {
                     if (number == null) {
                         return null;
-                    } else {
-                        // Empty value will be a BigInteger
-                        if (number instanceof BigInteger) {
-                            return (BigInteger) number;
-                        }
-                        return ((BigDecimal) number).toBigInteger();
                     }
+                    // Empty value will be a BigInteger
+                    if (number instanceof BigInteger) {
+                        return (BigInteger) number;
+                    }
+                    return ((BigDecimal) number).toBigInteger();
                 });
     }
 
index a2eb45dce1173da67e4ca3ea24ec47f534adbabb..627775fbba818981a3afe5b2fd5faf04dd702400 100644 (file)
@@ -72,9 +72,8 @@ public class StringToDoubleConverter
         return n.map(number -> {
             if (number == null) {
                 return null;
-            } else {
-                return number.doubleValue();
             }
+            return number.doubleValue();
         });
     }
 
index 6598c0f6fdb72882931599ad8176058071672766..37e159f844608a31bc623a3d0f2d3f534e3cc3d2 100644 (file)
@@ -70,9 +70,8 @@ public class StringToFloatConverter
         return n.map(number -> {
             if (number == null) {
                 return null;
-            } else {
-                return number.floatValue();
             }
+            return number.floatValue();
         });
     }
 
index 71709e99278a0f7c5026133516238071a4fbddf0..88f2c2912611a2bc2eaa0bace83d53557d0a86a1 100644 (file)
@@ -85,18 +85,16 @@ public class StringToIntegerConverter
         return n.flatMap(number -> {
             if (number == null) {
                 return Result.ok(null);
-            } else {
-                int intValue = number.intValue();
-                if (intValue == number.longValue()) {
-                    // If the value of n is outside the range of long, the
-                    // return value of longValue() is either Long.MIN_VALUE or
-                    // Long.MAX_VALUE. The/ above comparison promotes int to
-                    // long and thus does not need to consider wrap-around.
-                    return Result.ok(intValue);
-                } else {
-                    return Result.error(getErrorMessage());
-                }
             }
+            int intValue = number.intValue();
+            if (intValue == number.longValue()) {
+                // If the value of n is outside the range of long, the
+                // return value of longValue() is either Long.MIN_VALUE or
+                // Long.MAX_VALUE. The/ above comparison promotes int to
+                // long and thus does not need to consider wrap-around.
+                return Result.ok(intValue);
+            }
+            return Result.error(getErrorMessage());
         });
     }
 
index 00364dbbc952a11e8d19cbab2506bb8c2acd2d76..4e652963165abc4830391e17eb829fb548fae740 100644 (file)
@@ -85,9 +85,8 @@ public class StringToLongConverter
         return n.map(number -> {
             if (number == null) {
                 return null;
-            } else {
-                return number.longValue();
             }
+            return number.longValue();
         });
     }
 
index 556404911c15adbddfe2863840e43e6b73bc7df2..785079bb0dc8526450da92ffde2947fecf07215d 100644 (file)
@@ -46,9 +46,8 @@ public class InMemoryDataProviderHelpers {
         UI currentUi = UI.getCurrent();
         if (currentUi != null) {
             return currentUi.getLocale();
-        } else {
-            return Locale.getDefault();
         }
+        return Locale.getDefault();
     };
 
     /**
index 81e141319de448533b58c93e45d976e2570a66e0..22b22678b06a2a7339583d3a5df9cfca4372b2be 100644 (file)
@@ -120,10 +120,8 @@ public class Navigator implements Serializable {
                 popStateListenerRegistration = null;
             }
             if (navigator != null) {
-                popStateListenerRegistration = ui.getPage()
-                        .addPopStateListener(e -> {
-                            navigator.navigateTo(getState());
-                        });
+                popStateListenerRegistration = ui.getPage().addPopStateListener(
+                        e -> navigator.navigateTo(getState()));
             }
         }
 
@@ -700,10 +698,8 @@ public class Navigator implements Serializable {
      *            parameters passed in the navigation state to the view
      */
     protected void navigateTo(View view, String viewName, String parameters) {
-        runAfterLeaveConfirmation(() -> {
-            performNavigateTo(view, viewName, parameters);
-        });
-
+        runAfterLeaveConfirmation(
+                () -> performNavigateTo(view, viewName, parameters));
     }
 
     /**
index b54c9622d6e0623c41085fea427aa5623501328c..c0221af38e047ac53568bbb3600c80d0f0052e08 100644 (file)
@@ -694,9 +694,7 @@ public class FileUploadHandler implements RequestHandler {
 
     private void cleanStreamVariable(VaadinSession session, final UI ui,
             final ClientConnector owner, final String variableName) {
-        session.accessSynchronously(() -> {
-            ui.getConnectorTracker().cleanStreamVariable(owner.getConnectorId(),
-                    variableName);
-        });
+        session.accessSynchronously(() -> ui.getConnectorTracker()
+                .cleanStreamVariable(owner.getConnectorId(), variableName));
     }
 }
index 9e15d5c0fe3ef9bfdadcac44d78fd03a9bdf59b5..04fcbd0c801ca62ace9c4ac068dda8c9f7fc0bed 100644 (file)
@@ -36,7 +36,6 @@ import org.atmosphere.interceptor.HeartbeatInterceptor;
 import org.atmosphere.util.VoidAnnotationProcessor;
 
 import com.vaadin.server.RequestHandler;
-import com.vaadin.server.ServiceDestroyEvent;
 import com.vaadin.server.ServiceException;
 import com.vaadin.server.ServletPortletHelper;
 import com.vaadin.server.SessionExpiredHandler;
@@ -66,9 +65,7 @@ public class PushRequestHandler
     public PushRequestHandler(VaadinServletService service)
             throws ServiceException {
 
-        service.addServiceDestroyListener((ServiceDestroyEvent event) -> {
-            destroy();
-        });
+        service.addServiceDestroyListener(e -> destroy());
 
         final ServletConfig vaadinServletConfig = service.getServlet()
                 .getServletConfig();
index 2c9c40e668927595663c3820b4430b82dc7223e8..88b42d5757bbe77192076b776b1561a707a855dc 100644 (file)
@@ -1388,10 +1388,10 @@ public abstract class AbstractComponent extends AbstractClientConnector
         // called if there are no listeners on the server-side. A client-side
         // connector can override this and use a different RPC channel.
         if (getRpcManager(ContextClickRpc.class.getName()) == null) {
-            registerRpc((ContextClickRpc) (MouseEventDetails details) -> {
-                fireEvent(
-                        new ContextClickEvent(AbstractComponent.this, details));
-            });
+            registerRpc(
+                    (ContextClickRpc) (MouseEventDetails details) -> fireEvent(
+                            new ContextClickEvent(AbstractComponent.this,
+                                    details)));
         }
 
         return addListener(EventId.CONTEXT_CLICK, ContextClickEvent.class,
index 6e03ed35e99f91f5e3500775a2ec5a01a202ec20..c6765dde1a13c0fdeb89ba80c6e26050db1fb09d 100644 (file)
@@ -678,10 +678,9 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
     @Override
     public Registration addValueChangeListener(
             HasValue.ValueChangeListener<T> listener) {
-        return addSelectionListener(event -> {
-            listener.valueChange(new ValueChangeEvent<>(event.getComponent(),
-                    this, event.getOldValue(), event.isUserOriginated()));
-        });
+        return addSelectionListener(event -> listener
+                .valueChange(new ValueChangeEvent<>(event.getComponent(), this,
+                        event.getOldValue(), event.isUserOriginated())));
     }
 
     @Override
index a407859d08074c1bacd4e56da1975758832756b7..4540a9feb957fe523fc186c6f6cdc60da917b78e 100644 (file)
@@ -76,10 +76,10 @@ import com.vaadin.ui.declarative.DesignContext;
 public class CssLayout extends AbstractLayout implements LayoutClickNotifier {
 
     private CssLayoutServerRpc rpc = (MouseEventDetails mouseDetails,
-            Connector clickedConnector) -> {
-        fireEvent(LayoutClickEvent.createEvent(CssLayout.this, mouseDetails,
-                clickedConnector));
-    };
+            Connector clickedConnector) -> fireEvent(
+                    LayoutClickEvent.createEvent(CssLayout.this, mouseDetails,
+                            clickedConnector));
+
     /**
      * Custom layout slots containing the components.
      */
index 2b4723eaaa0067e7be18a16e3f4a33925f1eda88..de8f66ee58d61f3e73c2b4910218179c8bba4e77 100644 (file)
@@ -403,12 +403,12 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
      *
      * <p>
      * Usage:
-     * 
+     *
      * <pre>
      * grid.addContextClickListener(event -&gt; Notification.show(
      *         ((GridContextClickEvent&lt;Person&gt;) event).getItem() + " Clicked"));
      * </pre>
-     * 
+     *
      * @param <T>
      *            the grid bean type
      */
@@ -836,9 +836,8 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
             String id = getId();
             if (id == null) {
                 return Stream.empty();
-            } else {
-                return Stream.of(new QuerySortOrder(id, direction));
             }
+            return Stream.of(new QuerySortOrder(id, direction));
         };
 
         private SerializableComparator<T> comparator;
@@ -3018,7 +3017,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
      * Note that all header, body and footer rows get the same height if
      * explicitly set. In automatic mode, each section is calculated separately
      * based on an empty row of that type.
-     * 
+     *
      * @see #setBodyRowHeight(double)
      * @see #setHeaderRowHeight(double)
      * @see #setFooterRowHeight(double)
@@ -3036,7 +3035,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
      * Sets the height of a body row. If -1 (default), the row height is
      * calculated based on the theme for an empty row before the Grid is
      * displayed.
-     * 
+     *
      * @param rowHeight
      *            The height of a row in pixels or -1 for automatic calculation
      * @since 8.2
@@ -3293,10 +3292,10 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
 
     /**
      * Sets the visibility of the Header in this Grid.
-     * 
+     *
      * @param headerVisible
      *            {@code true} if visible; {@code false} if not
-     * 
+     *
      * @since 8.1.1
      */
     public void setHeaderVisible(boolean headerVisible) {
@@ -3305,9 +3304,9 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
 
     /**
      * Gets the visibility of the Header in this Grid.
-     * 
+     *
      * @return {@code true} if visible; {@code false} if not
-     * 
+     *
      * @since 8.1.1
      */
     public boolean isHeaderVisible() {
@@ -3466,10 +3465,10 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
 
     /**
      * Sets the visibility of the Footer in this Grid.
-     * 
+     *
      * @param footerVisible
      *            {@code true} if visible; {@code false} if not
-     * 
+     *
      * @since 8.1.1
      */
     public void setFooterVisible(boolean footerVisible) {
@@ -3478,9 +3477,9 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
 
     /**
      * Gets the visibility of the Footer in this Grid.
-     * 
+     *
      * @return {@code true} if visible; {@code false} if not
-     * 
+     *
      * @since 8.1.1
      */
     public boolean isFooterVisible() {
@@ -3651,7 +3650,6 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
                         "setColumnOrder should not be called "
                                 + "with columns that are not in the grid.");
             }
-
         });
 
         List<String> stateColumnOrder = getState().columnOrder;
@@ -4572,14 +4570,13 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
      * @return the comparator based on column sorting information.
      */
     protected SerializableComparator<T> createSortingComparator() {
+        /*
+         * thenComparing is defined to return a serializable comparator as long
+         * as both original comparators are also serializable
+         */
         BinaryOperator<SerializableComparator<T>> operator = (comparator1,
-                comparator2) -> {
-            /*
-             * thenComparing is defined to return a serializable comparator as
-             * long as both original comparators are also serializable
-             */
-            return comparator1.thenComparing(comparator2)::compare;
-        };
+                comparator2) ->
+        comparator1.thenComparing(comparator2)::compare;
         return sortOrder.stream().map(
                 order -> order.getSorted().getComparator(order.getDirection()))
                 .reduce((x, y) -> 0, operator);
index 27e1835b57744731d47eed97aad435e454e94ffe..ebffa061e8760664e047245f3e1652d9909b48fb 100644 (file)
@@ -77,10 +77,10 @@ public class GridLayout extends AbstractLayout
         Layout.MarginHandler, LayoutClickNotifier {
 
     private GridLayoutServerRpc rpc = (MouseEventDetails mouseDetails,
-            Connector clickedConnector) -> {
-        fireEvent(LayoutClickEvent.createEvent(GridLayout.this, mouseDetails,
-                clickedConnector));
-    };
+            Connector clickedConnector) -> fireEvent(
+                    LayoutClickEvent.createEvent(GridLayout.this, mouseDetails,
+                            clickedConnector));
+
     /**
      * Cursor X position: this is where the next component with unspecified x,y
      * is inserted
index 4f3650a9f2ceae86932cdde9f1061860d90f0540..4b1d7dae00375d0f6f1d314cb0fb01658284c5be 100644 (file)
@@ -33,9 +33,9 @@ import com.vaadin.shared.ui.image.ImageState;
 @SuppressWarnings("serial")
 public class Image extends AbstractEmbedded {
 
-    protected ImageServerRpc rpc = (MouseEventDetails mouseDetails) -> {
-        fireEvent(new ClickEvent(Image.this, mouseDetails));
-    };
+    protected ImageServerRpc rpc = (
+            MouseEventDetails mouseDetails) -> fireEvent(
+                    new ClickEvent(Image.this, mouseDetails));
 
     /**
      * Creates a new empty Image.
index 83c145ec7018220c9b757ebfa05d44d9b0bcc1f8..0c3158bf97314484310c14e684a4735d14cb61ac 100644 (file)
@@ -74,9 +74,8 @@ public class Notification extends AbstractExtension implements Serializable {
      *
      * @since 8.2
      */
-    protected NotificationServerRpc rpc = () -> {
-        fireEvent(new CloseEvent(Notification.this));
-    };
+    protected NotificationServerRpc rpc = () -> fireEvent(
+            new CloseEvent(Notification.this));
 
     public enum Type {
         HUMANIZED_MESSAGE("humanized"), WARNING_MESSAGE(
index def58939465c0aeb4cf8aa635cf666b6b5184c6c..6b06b02fe4014c4ff416e6a4f1b2e55862af359a 100644 (file)
@@ -53,9 +53,8 @@ public class Panel extends AbstractSingleComponentContainer
      */
     protected ActionManager actionManager;
 
-    private PanelServerRpc rpc = (MouseEventDetails mouseDetails) -> {
-        fireEvent(new ClickEvent(Panel.this, mouseDetails));
-    };
+    private PanelServerRpc rpc = (MouseEventDetails mouseDetails) -> fireEvent(
+            new ClickEvent(Panel.this, mouseDetails));
 
     /**
      * Creates a new empty panel.
index cf5051abb4b79c13f324e96b178aea3dc8ad0a5b..c84cc9534da3542ed7578d3844f62e456e7bab3c 100644 (file)
@@ -149,9 +149,8 @@ public class GridDragSource<T> extends DragSourceExtension<Grid<T>> {
     private void generateDragData(T item, JsonObject jsonObject) {
         JsonObject generatedValues = Json.createObject();
 
-        generatorFunctions.forEach((type, generator) -> {
-            generatedValues.put(type, generator.apply(item));
-        });
+        generatorFunctions.forEach((type, generator) -> generatedValues
+                .put(type, generator.apply(item)));
 
         jsonObject.put(GridDragSourceState.JSONKEY_DRAG_DATA, generatedValues);
     }
index 8d723ef47e54f85af7e6d991d76397e97cfb3b94..61d35297d01e71c113361fef4f79a8cbc518116b 100644 (file)
@@ -490,9 +490,8 @@ public class Design implements Serializable {
             // create listener for component creations that binds the created
             // components to the componentRoot instance fields
             ComponentCreationListener creationListener = (
-                    ComponentCreatedEvent event) -> {
-                binder.bindField(event.getComponent(), event.getLocalId());
-            };
+                    ComponentCreatedEvent event) -> binder.bindField(
+                            event.getComponent(), event.getLocalId());
             designContext.addComponentCreationListener(creationListener);
 
             // create subtree
index 4cff2545e8cc365d89a80e1c725fb591ad4a4f4e..76c7195f60e0da511ebc7904551b979959fe58af 100644 (file)
@@ -24,10 +24,10 @@ import java.util.Objects;
 import com.vaadin.server.AbstractExtension;
 import com.vaadin.shared.MouseEventDetails;
 import com.vaadin.shared.Registration;
-import com.vaadin.shared.ui.dnd.criteria.ComparisonOperator;
 import com.vaadin.shared.ui.dnd.DropEffect;
 import com.vaadin.shared.ui.dnd.DropTargetRpc;
 import com.vaadin.shared.ui.dnd.DropTargetState;
+import com.vaadin.shared.ui.dnd.criteria.ComparisonOperator;
 import com.vaadin.shared.ui.dnd.criteria.Criterion;
 import com.vaadin.ui.AbstractComponent;
 import com.vaadin.ui.dnd.event.DropEvent;
@@ -73,11 +73,10 @@ public class DropTargetExtension<T extends AbstractComponent>
      */
     protected void registerDropTargetRpc() {
         registerRpc(
-                (DropTargetRpc) (types, data, dropEffect, mouseEventDetails) -> {
-                    onDrop(types, data,
-                            DropEffect.valueOf(dropEffect.toUpperCase()),
-                            mouseEventDetails);
-                });
+                (DropTargetRpc) (types, data, dropEffect, mouseEventDetails) ->
+                onDrop(types, data,
+                        DropEffect.valueOf(dropEffect.toUpperCase()),
+                        mouseEventDetails));
     }
 
     /**
index 734aa5b194bdd0e9e520c7db819c35f9a198c70a..a451e2b9be99c0ee8312c76f3ecd15801198ccd5 100644 (file)
@@ -127,9 +127,8 @@ public class BinderConverterValidatorTest
         Validator<Number> positiveNumberValidator = (value, context) -> {
             if (value.doubleValue() >= 0) {
                 return ValidationResult.ok();
-            } else {
-                return ValidationResult.error(NEGATIVE_ERROR_MESSAGE);
             }
+            return ValidationResult.error(NEGATIVE_ERROR_MESSAGE);
         };
         binder.forField(salaryField)
                 .withConverter(Double::valueOf, String::valueOf)
@@ -227,7 +226,8 @@ public class BinderConverterValidatorTest
                 .withConverter(presentation -> {
                     if (presentation.equals("OK")) {
                         return "1";
-                    } else if (presentation.equals("NOTOK")) {
+                    }
+                    if (presentation.equals("NOTOK")) {
                         return "2";
                     }
                     throw new IllegalArgumentException(
@@ -235,12 +235,12 @@ public class BinderConverterValidatorTest
                 }, model -> {
                     if (model.equals("1")) {
                         return "OK";
-                    } else if (model.equals("2")) {
+                    }
+                    if (model.equals("2")) {
                         return "NOTOK";
-                    } else {
-                        throw new IllegalArgumentException(
-                                "Value in model must be 1 or 2");
                     }
+                    throw new IllegalArgumentException(
+                            "Value in model must be 1 or 2");
                 });
         binding.bind(StatusBean::getStatus, StatusBean::setStatus);
         binder.setBean(bean);
@@ -535,12 +535,9 @@ public class BinderConverterValidatorTest
         binder.forField(nameField).withConverter(fieldValue -> {
             if ("null".equals(fieldValue)) {
                 return null;
-            } else {
-                return fieldValue;
             }
-        }, model -> {
-            return model;
-        }).bind(Person::getFirstName, Person::setFirstName);
+            return fieldValue;
+        }, model -> model).bind(Person::getFirstName, Person::setFirstName);
 
         Person person = new Person();
         person.setFirstName("foo");
index 032ce9958094915f7d3e5705a2e197d8b63b1345..7b45ee95e0701dbc8fd34270b13aae78c29e2cf0 100644 (file)
@@ -394,8 +394,9 @@ public class BinderTest extends BinderTestBase<Binder<Person>, Person> {
         String customNullPointerRepresentation = "foo";
         Binder<Person> binder = new Binder<>(Person.class);
         binder.forField(nameField)
-                .withConverter(value -> value, value -> value == null
-                        ? customNullPointerRepresentation : value)
+                .withConverter(value -> value,
+                        value -> value == null ? customNullPointerRepresentation
+                                : value)
                 .bind("firstName");
 
         Person person = new Person();
@@ -892,9 +893,8 @@ public class BinderTest extends BinderTestBase<Binder<Person>, Person> {
                 .withConverter(new StringToIntegerConverter(ageError))
                 .bind(Person::getAge, Person::setAge);
 
-        binder.setValidationStatusHandler(status -> {
-            status.notifyBindingValidationStatusHandlers();
-        });
+        binder.setValidationStatusHandler(
+                status -> status.notifyBindingValidationStatusHandlers());
 
         String initialName = item.getFirstName();
         int initialAge = item.getAge();
index dcf568cafcc6ee37190a15d50cdb2384a996e22b..7df1537bd0f4dbc0fccd10f6be9e37050994c75a 100644 (file)
@@ -215,17 +215,16 @@ public class BinderValidationStatusTest
     public void binderWithStatusHandler_fieldValidationNoBeanValidation_handlerGetsStatusUpdates() {
         AtomicReference<BinderValidationStatus<?>> statusCapture = new AtomicReference<>();
         binder.forField(nameField).withValidator(notEmpty)
-                .withValidationStatusHandler(evt -> {
-                    fail("Using a custom status change handler so no change should end up here");
-                }).bind(Person::getFirstName, Person::setFirstName);
+                .withValidationStatusHandler(evt -> fail(
+                        "Using a custom status change handler so no change should end up here"))
+                .bind(Person::getFirstName, Person::setFirstName);
         binder.forField(ageField).withConverter(stringToInteger)
-                .withValidator(notNegative).withValidationStatusHandler(evt -> {
-                    fail("Using a custom status change handler so no change should end up here");
-                }).bind(Person::getAge, Person::setAge);
+                .withValidator(notNegative)
+                .withValidationStatusHandler(evt -> fail(
+                        "Using a custom status change handler so no change should end up here"))
+                .bind(Person::getAge, Person::setAge);
 
-        binder.setValidationStatusHandler(r -> {
-            statusCapture.set(r);
-        });
+        binder.setValidationStatusHandler(r -> statusCapture.set(r));
         binder.setBean(item);
         assertNull(nameField.getComponentError());
 
@@ -303,20 +302,19 @@ public class BinderValidationStatusTest
     public void binderWithStatusHandler_fieldAndBeanLevelValidation_handlerGetsStatusUpdates() {
         AtomicReference<BinderValidationStatus<?>> statusCapture = new AtomicReference<>();
         binder.forField(nameField).withValidator(notEmpty)
-                .withValidationStatusHandler(evt -> {
-                    fail("Using a custom status change handler so no change should end up here");
-                }).bind(Person::getFirstName, Person::setFirstName);
+                .withValidationStatusHandler(evt -> fail(
+                        "Using a custom status change handler so no change should end up here"))
+                .bind(Person::getFirstName, Person::setFirstName);
         binder.forField(ageField).withConverter(stringToInteger)
-                .withValidator(notNegative).withValidationStatusHandler(evt -> {
-                    fail("Using a custom status change handler so no change should end up here");
-                }).bind(Person::getAge, Person::setAge);
+                .withValidator(notNegative)
+                .withValidationStatusHandler(evt -> fail(
+                        "Using a custom status change handler so no change should end up here"))
+                .bind(Person::getAge, Person::setAge);
         binder.withValidator(
                 bean -> !bean.getFirstName().isEmpty() && bean.getAge() > 0,
                 "Need first name and age");
 
-        binder.setValidationStatusHandler(r -> {
-            statusCapture.set(r);
-        });
+        binder.setValidationStatusHandler(r -> statusCapture.set(r));
         binder.setBean(item);
         assertNull(nameField.getComponentError());
 
@@ -489,13 +487,9 @@ public class BinderValidationStatusTest
         BindingBuilder<Person, String> binding = binder.forField(nameField);
         binding.bind(Person::getFirstName, Person::setFirstName);
 
-        binder.setValidationStatusHandler(results -> {
-            fail();
-        });
+        binder.setValidationStatusHandler(results -> fail());
 
-        binder.setValidationStatusHandler(results -> {
-            capture.set(results);
-        });
+        binder.setValidationStatusHandler(results -> capture.set(results));
 
         nameField.setValue("foo");
         binder.validate();
index 7d29b6941e2a8b1fedc9ab57b8b55e849af53174..b2c21581f51cd0c34e4140d2cae8566353d9b318 100644 (file)
@@ -61,7 +61,8 @@ public class ValidatorTest extends ValidatorTestBase {
 
                     if (locale.getLanguage().equals("fi")) {
                         return finnishError;
-                    } else if (locale.getLanguage().equals("en")) {
+                    }
+                    if (locale.getLanguage().equals("en")) {
                         return englishError;
                     }
                     return notTranslatableError;
index 6219be0a29ad586a0c75c4ffabda9d01d37e529a..6e40fdf0ceff67f4af4d0ead68b72ea6fa82da97 100644 (file)
@@ -158,9 +158,8 @@ public class VaadinServiceTest {
 
         MockVaadinSession session = new MockVaadinSession(service);
         session.lock();
-        service.accessSession(session, () -> {
-            CurrentInstance.set(String.class, "Set in task");
-        });
+        service.accessSession(session,
+                () -> CurrentInstance.set(String.class, "Set in task"));
 
         CurrentInstance.set(String.class, "Original value");
         service.runPendingAccessTasks(session);
index 3c31fddd7e9c5e2b3ce5556cc91a979867eecc09..81304885c37710f40d018b441bf1ca11ea21ab9c 100644 (file)
@@ -14,9 +14,8 @@ public class ConverterTest {
     SerializableFunction<String, Result<String>> toModel = presentation -> {
         if (presentation.startsWith("presentation-")) {
             return Result.ok(presentation.substring("presentation-".length()));
-        } else {
-            return Result.error("invalid prefix: " + presentation);
         }
+        return Result.error("invalid prefix: " + presentation);
     };
 
     SerializableFunction<String, String> toPresentation = model -> "presentation-"
index f3a44a7bf2457cb99567907066091c5e9b308db4..5a21e7e793f380fffacd634deef382066dc76276 100644 (file)
@@ -15,7 +15,6 @@
  */
 package com.vaadin.tests.design.designroot;
 
-import com.vaadin.ui.Button.ClickEvent;
 import com.vaadin.ui.Notification;
 import com.vaadin.ui.TextField;
 
@@ -29,12 +28,8 @@ public class ExtendedDesignWithEmptyAnnotation
         customField.setPlaceholder("Something");
         addComponent(customField);
 
-        ok.addClickListener((ClickEvent event) -> {
-            Notification.show("OK");
-        });
+        ok.addClickListener(e -> Notification.show("OK"));
 
-        CaNCEL.addClickListener((ClickEvent event) -> {
-            Notification.show("cancel");
-        });
+        CaNCEL.addClickListener(e -> Notification.show("cancel"));
     }
 }
index 2adbfe2df83377e8b6dc8038c1df9a7fef613246..45844bee25ca985e55e1b4936847c044da75007c 100644 (file)
@@ -10,7 +10,6 @@ import org.junit.Test;
 
 import com.vaadin.server.VaadinRequest;
 import com.vaadin.ui.Button;
-import com.vaadin.ui.Button.ClickEvent;
 import com.vaadin.ui.UI;
 
 /**
@@ -23,9 +22,7 @@ public class ButtonClickTest {
     public void clickDetachedButton() {
         Button b = new Button();
         AtomicInteger counter = new AtomicInteger(0);
-        b.addClickListener((ClickEvent event) -> {
-            counter.incrementAndGet();
-        });
+        b.addClickListener(e -> counter.incrementAndGet());
 
         b.click();
         assertEquals(1, counter.get());
@@ -65,8 +62,6 @@ public class ButtonClickTest {
 
     private void addClickListener(Button b) {
         clicked = false;
-        b.addClickListener((ClickEvent ev) -> {
-            clicked = true;
-        });
+        b.addClickListener(e -> clicked = true);
     }
 }
index cd7570e7b6dbfe5b60986d20132c215102826d39..50385c5aedec3cbcb4025402d9787ed1235d2195 100644 (file)
@@ -3,15 +3,12 @@ package com.vaadin.tests.server.component.window;
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 
-import org.junit.Assert;
 import org.junit.Test;
 
 import com.vaadin.server.ClientConnector;
 import com.vaadin.server.VaadinRequest;
 import com.vaadin.server.VaadinSession;
 import com.vaadin.tests.util.AlwaysLockedVaadinSession;
-import com.vaadin.ui.HasComponents.ComponentAttachEvent;
-import com.vaadin.ui.HasComponents.ComponentDetachEvent;
 import com.vaadin.ui.Label;
 import com.vaadin.ui.UI;
 import com.vaadin.ui.VerticalLayout;
@@ -222,12 +219,10 @@ public class AttachDetachWindowTest {
         final Window window = new Window();
 
         final boolean[] eventFired = new boolean[1];
-        ui.addComponentAttachListener((ComponentAttachEvent event) -> {
-            eventFired[0] = event.getAttachedComponent().equals(window);
-        });
+        ui.addComponentAttachListener(
+                e -> eventFired[0] = e.getAttachedComponent().equals(window));
         ui.addWindow(window);
-        assertTrue("Attach event is not fired for added window",
-                eventFired[0]);
+        assertTrue("Attach event is not fired for added window", eventFired[0]);
     }
 
     @Test
@@ -236,9 +231,8 @@ public class AttachDetachWindowTest {
         final Window window = new Window();
 
         final boolean[] eventFired = new boolean[1];
-        ui.addComponentDetachListener((ComponentDetachEvent event) -> {
-            eventFired[0] = event.getDetachedComponent().equals(window);
-        });
+        ui.addComponentDetachListener(
+                e -> eventFired[0] = e.getDetachedComponent().equals(window));
         ui.addWindow(window);
         ui.removeWindow(window);
 
index 2a756da1cb7a6c99198a45309e8a7a0d6ac541f9..ee520a78f9d93c67ad42f96c777d4cb2cb31fda3 100644 (file)
@@ -1283,9 +1283,7 @@ public class NavigatorTest {
         navigator.navigateTo("view1");
 
         AtomicInteger leaveCount = new AtomicInteger(0);
-        navigator.runAfterLeaveConfirmation(() -> {
-            leaveCount.incrementAndGet();
-        });
+        navigator.runAfterLeaveConfirmation(() -> leaveCount.incrementAndGet());
         assertEquals(0, leaveCount.get());
         eventRef.get().navigate();
         assertEquals(1, leaveCount.get());
index d2c280f12da5c3a238d9161a3061a9af296c23f0..076c1299141e1a02bee01badec65a942f60d3207 100644 (file)
@@ -49,9 +49,8 @@ public class CheckBoxTest {
         CheckBox cb = new CheckBox();
         ui.setContent(cb);
         AtomicBoolean userOriginated = new AtomicBoolean(false);
-        cb.addValueChangeListener(e -> {
-            userOriginated.set(e.isUserOriginated());
-        });
+        cb.addValueChangeListener(
+                e -> userOriginated.set(e.isUserOriginated()));
         ComponentTest.syncToClient(cb);
         ServerRpcManager.getRpcProxy(cb, CheckBoxServerRpc.class)
                 .setChecked(true, new MouseEventDetails());
@@ -69,9 +68,8 @@ public class CheckBoxTest {
         CheckBox cb = new CheckBox();
         ui.setContent(cb);
         AtomicBoolean userOriginated = new AtomicBoolean(true);
-        cb.addValueChangeListener(e -> {
-            userOriginated.set(e.isUserOriginated());
-        });
+        cb.addValueChangeListener(
+                e -> userOriginated.set(e.isUserOriginated()));
         cb.setValue(true);
         assertFalse(userOriginated.get());
         userOriginated.set(true);
index 1da8cc51ff19cb96e639c0ba2ffa9d268a720351..26cf31628a122cbc02fda6d785cd70e3099f52ff 100644 (file)
@@ -2,11 +2,11 @@ package com.vaadin.test.osgi.myapplication1;
 
 import javax.servlet.annotation.WebServlet;
 
-import com.vaadin.annotations.Theme;
-import com.vaadin.annotations.Widgetset;
 import org.osgi.service.component.annotations.Component;
 
+import com.vaadin.annotations.Theme;
 import com.vaadin.annotations.VaadinServletConfiguration;
+import com.vaadin.annotations.Widgetset;
 import com.vaadin.server.VaadinRequest;
 import com.vaadin.server.VaadinServlet;
 import com.vaadin.ui.Button;
@@ -27,9 +27,8 @@ public class MyUI extends UI {
         name.setCaption("Type your name here:");
 
         Button button = new Button("Click Me");
-        button.addClickListener(e -> {
-            layout.addComponent(new Label("Thanks " + name.getValue() + ", it works!"));
-        });
+        button.addClickListener(e -> layout.addComponent(
+                new Label("Thanks " + name.getValue() + ", it works!")));
 
         layout.addComponents(name, button);
 
index 14529ecea1a703de33b27c1930d3623a02df0026..6a83b7b611588aacd4f5dfe3bc997f839e741309 100644 (file)
@@ -23,9 +23,8 @@ public class MyUI extends UI {
         name.setCaption("Type your name here:");
 
         Button button = new Button("Click Me");
-        button.addClickListener(e -> {
-            layout.addComponent(new Label("Thanks " + name.getValue() + ", it works!"));
-        });
+        button.addClickListener(e -> layout.addComponent(
+                new Label("Thanks " + name.getValue() + ", it works!")));
 
         layout.addComponents(name, button);
 
index 9d2ca4f6ea609a248475a6fdc3871751b2d72e8a..30086a110fdfdcaa6ac20040619db73338bc30ab 100644 (file)
@@ -29,9 +29,7 @@ public abstract class AbstractListingTestUI<T extends AbstractListing<Object>>
         options.put("100000", 100000);
 
         createSelectAction("Items", "Data provider", options, "20",
-                (c, number, data) -> {
-                    c.setItems(createItems(number));
-                });
+                (c, number, data) -> c.setItems(createItems(number)));
     }
 
     protected Object[] createItems(int number) {
index 4c773283ecd67a77445f54bb6df195f334e4b6e7..f4da372996b8f39099e0ba75a9e7d7569eeab72b 100644 (file)
@@ -45,9 +45,7 @@ public abstract class AbstractSingleSelectTestUI<T extends AbstractSingleSelect<
         options.put("Item 100", "Item 100");
 
         createSelectAction("Select", "Selection", options, "None",
-                (component, selected, data) -> {
-                    component.setValue(selected);
-                });
+                (component, selected, data) -> component.setValue(selected));
     }
 
 }
index 55f61b41340b12d25c24938d619a5e8e4b91067d..48a505583ed3e0a232e0a823ebd39e332a2d0438 100644 (file)
@@ -25,9 +25,9 @@ public class AbstractSingleSelection extends AbstractTestUI {
         componentSelect.setItemCaptionGenerator(Class::getSimpleName);
 
         componentSelect.setEmptySelectionAllowed(false);
-        componentSelect.addValueChangeListener(singleSelectClass -> {
-            createComponent(singleSelectClass.getValue());
-        });
+        componentSelect
+                .addValueChangeListener(singleSelectClass -> createComponent(
+                        singleSelectClass.getValue()));
 
         addComponent(componentSelect);
         addComponent(component); // This will be replaced in createComponent
index bfb3bf0bfc935623e0d924fe95938ae11232b484..f4e7a9bc44795ce3275839e885333af361e34ef6 100644 (file)
@@ -46,10 +46,8 @@ public class CompositeChainUI extends AbstractTestUIWithLog {
         addComponent(container);
 
         Button updateCaption = new Button("Update caption");
-        updateCaption.addClickListener(e -> {
-            innermostComponent
-                    .setCaption(innermostComponent.getCaption() + " - updated");
-        });
+        updateCaption.addClickListener(e -> innermostComponent
+                .setCaption(innermostComponent.getCaption() + " - updated"));
         addComponent(updateCaption);
         Button replaceWithAnotherComposite = new Button(
                 "Replace with another Composite", e -> {
index bd1fda52014c47f7f222d4b56901e5de6195c187..4a578de91fbbd7a790676cdb9205effec617964d 100644 (file)
@@ -20,31 +20,27 @@ public class DateFieldElementUI extends AbstractReindeerTestUIWithLog {
     protected void setup(VaadinRequest request) {
         log.setNumberLogRows(false);
         DateField df = new DateField();
-        df.addValueChangeListener(event -> {
-            log("Default date field value set to " + event.getValue());
-        });
+        df.addValueChangeListener(event -> log(
+                "Default date field value set to " + event.getValue()));
         addComponent(df);
         InlineDateField inlineDateField = new InlineDateField();
-        inlineDateField.addValueChangeListener(event -> {
-            log("Default inline date field value set to " + event.getValue());
-        });
+        inlineDateField.addValueChangeListener(event -> log(
+                "Default inline date field value set to " + event.getValue()));
         addComponent(inlineDateField);
 
         DateField finnishDatefield = new DateField("Finnish");
         finnishDatefield.setId("fi");
         finnishDatefield.setLocale(new Locale("fi", "FI"));
         finnishDatefield.setValue(TEST_DATE_TIME);
-        finnishDatefield.addValueChangeListener(event -> {
-            log("Finnish date field value set to " + event.getValue());
-        });
+        finnishDatefield.addValueChangeListener(event -> log(
+                "Finnish date field value set to " + event.getValue()));
         addComponent(finnishDatefield);
         DateField usDatefield = new DateField("US");
         usDatefield.setId("us");
         usDatefield.setLocale(Locale.US);
         usDatefield.setValue(TEST_DATE_TIME);
-        usDatefield.addValueChangeListener(event -> {
-            log("US date field value set to " + event.getValue());
-        });
+        usDatefield.addValueChangeListener(
+                event -> log("US date field value set to " + event.getValue()));
         addComponent(usDatefield);
     }
 
index 1bd5ddd1f65a3e3650e8522728ee1ffa80a05152..f7f8e4473662d880a1f8299f11b15efbda0a97b4 100644 (file)
@@ -20,31 +20,27 @@ public class DateTimeFieldElementUI extends AbstractReindeerTestUIWithLog {
     protected void setup(VaadinRequest request) {
         log.setNumberLogRows(false);
         DateTimeField df = new DateTimeField();
-        df.addValueChangeListener(event -> {
-            log("Default date field value set to " + event.getValue());
-        });
+        df.addValueChangeListener(event -> log(
+                "Default date field value set to " + event.getValue()));
         addComponent(df);
         InlineDateTimeField inlineDateTimeField = new InlineDateTimeField();
-        inlineDateTimeField.addValueChangeListener(event -> {
-            log("Default inline date field value set to " + event.getValue());
-        });
+        inlineDateTimeField.addValueChangeListener(event -> log(
+                "Default inline date field value set to " + event.getValue()));
         addComponent(inlineDateTimeField);
 
         DateTimeField finnishDateTimeField = new DateTimeField("Finnish");
         finnishDateTimeField.setId("fi");
         finnishDateTimeField.setLocale(new Locale("fi", "FI"));
         finnishDateTimeField.setValue(TEST_DATE_TIME);
-        finnishDateTimeField.addValueChangeListener(event -> {
-            log("Finnish date field value set to " + event.getValue());
-        });
+        finnishDateTimeField.addValueChangeListener(event -> log(
+                "Finnish date field value set to " + event.getValue()));
         addComponent(finnishDateTimeField);
         DateTimeField usDateTimeField = new DateTimeField("US");
         usDateTimeField.setId("us");
         usDateTimeField.setLocale(Locale.US);
         usDateTimeField.setValue(TEST_DATE_TIME);
-        usDateTimeField.addValueChangeListener(event -> {
-            log("US date field value set to " + event.getValue());
-        });
+        usDateTimeField.addValueChangeListener(
+                event -> log("US date field value set to " + event.getValue()));
         addComponent(usDateTimeField);
     }
 
index 4838409134e95cab4dd1627e3b566e7df3dd1f8c..47ac69587833f41afaeb8f6de91a630de5f34f03 100644 (file)
@@ -49,10 +49,9 @@ public class DragAndDropFocusObtain extends AbstractTestUIWithLog {
         }
     };
 
-    private ValueChangeListener<String> listener = event -> {
-        log("Value of " + ((AbstractTextField) event.getSource()).getCaption()
-                + " changed to " + event.getValue());
-    };
+    private ValueChangeListener<String> listener = event -> log(
+            "Value of " + ((AbstractTextField) event.getSource()).getCaption()
+                    + " changed to " + event.getValue());
 
     @Override
     protected void setup(VaadinRequest request) {
index 0841c5f3b1573d617db3b93157aa56724ca0dfdd..a44143b4c6951afe705199099f074369e7dc66dc 100644 (file)
@@ -37,14 +37,12 @@ public class GridAriaMultiselectable extends AbstractTestUI {
 
         addComponent(grid);
 
-        Button singleSelectBtn = new Button("SingleSelect", event -> {
-            grid.setSelectionMode(SelectionMode.SINGLE);
-        });
+        Button singleSelectBtn = new Button("SingleSelect",
+                event -> grid.setSelectionMode(SelectionMode.SINGLE));
         addComponent(singleSelectBtn);
 
-        Button multiSelectBtn = new Button("MultiSelect", event -> {
-            grid.setSelectionMode(SelectionMode.MULTI);
-        });
+        Button multiSelectBtn = new Button("MultiSelect",
+                event -> grid.setSelectionMode(SelectionMode.MULTI));
         addComponent(multiSelectBtn);
     }
 }
index 2f67a63031438148e11b9fa1762fbec3c23499bc..c9b54f734a3d8623de533f3e1a3a1ee01af47c06 100644 (file)
@@ -20,7 +20,6 @@ import com.vaadin.server.VaadinRequest;
 import com.vaadin.tests.components.AbstractTestUI;
 import com.vaadin.ui.Button;
 import com.vaadin.ui.Grid;
-import com.vaadin.ui.Grid.SelectionMode;
 
 /**
  * @author Vaadin Ltd
@@ -36,19 +35,22 @@ public class GridAriaRowcount extends AbstractTestUI {
         addComponent(grid);
 
         addComponent(new Button("addFooter", event -> grid.addFooterRowAt(0)));
-        addComponent(new Button("removeFooter", event -> grid.removeFooterRow(0)));
+        addComponent(
+                new Button("removeFooter", event -> grid.removeFooterRow(0)));
 
         addComponent(new Button("addHeader", event -> grid.addHeaderRowAt(1)));
-        addComponent(new Button("removeHeader", event -> grid.removeHeaderRow(1)));
+        addComponent(
+                new Button("removeHeader", event -> grid.removeHeaderRow(1)));
 
-        addComponent(new Button("setItemsTo3", event -> grid.setItems("a", "b", "c")));
-        addComponent(new Button("setItemsTo6", event -> grid.setItems("a", "b", "c", "d", "e", "f")));
+        addComponent(new Button("setItemsTo3",
+                event -> grid.setItems("a", "b", "c")));
+        addComponent(new Button("setItemsTo6",
+                event -> grid.setItems("a", "b", "c", "d", "e", "f")));
 
         addComponent(new Button("updateAll", event -> {
             grid.addFooterRowAt(0);
             grid.addHeaderRowAt(0);
             grid.setItems("a", "b", "c", "d");
         }));
-
     }
 }
index 961e44593a42b48b76fce6da047fb99404ad53e7..40ab90c7d12d1ecb4870aa63bb16df8831313e3d 100644 (file)
@@ -85,14 +85,14 @@ public class GridColspans extends AbstractTestUI {
             if (column != null) {
                 grid.removeColumn(column);
             } else {
-                grid.addColumn(Person::getFirstName).setId("firstName").setCaption("First name");
+                grid.addColumn(Person::getFirstName).setId("firstName")
+                        .setCaption("First name");
             }
         }));
 
-        addComponent(new Button("Change column order", event -> {
-            grid.setColumnOrder(grid.getColumn("ageColumn"),
-                    grid.getColumn("firstName"));
-        }));
+        addComponent(new Button("Change column order",
+                event -> grid.setColumnOrder(grid.getColumn("ageColumn"),
+                        grid.getColumn("firstName"))));
     }
 
     @Override
index 851e16473185cccd802af4f08545096b8fd9d1ab..0d06485f87642a63881dec8e43fa4c5c130f11da 100644 (file)
@@ -63,7 +63,6 @@ public class GridColumnWidthsWithoutData extends AbstractTestUI {
             items.clear();
             provider.refreshAll();
         }));
-
     }
 
     private void replaceGrid(Grid<Person> newGrid) {
index 9bd3ed8af25f8c2143769e94fdbbd09abeec1b60..f53202a3a37ce3601d31ed3f4de3527b32659c3e 100644 (file)
@@ -75,7 +75,6 @@ public class GridDetailsLayoutExpand extends SimpleGridUI {
             final Person itemId = event.getItem();
             grid.setDetailsVisible(itemId, !grid.isDetailsVisible(itemId));
         });
-
     }
 
     @Override
index cdaf3fed813bdc295659f68e57260002ba2699e0..04925a0d6371fb33070934414fae2c0c0c1251cc 100644 (file)
@@ -115,10 +115,9 @@ public class GridHeaderFooterComponents extends AbstractTestUIWithLog {
         TextField filterField = new TextField();
         filterField.setWidth("8em");
         filterField.setValue("Filter: " + pid);
-        filterField.addValueChangeListener(listener -> {
-            log("value change for field in " + pid + " to "
-                    + listener.getValue());
-        });
+        filterField.addValueChangeListener(
+                listener -> log("value change for field in " + pid + " to "
+                        + listener.getValue()));
         return filterField;
     }
 
index 2c6a2cda1d2ef6108b89f6628a3024ea2ca7415e..4c0ee07868724c0ea24ff4ec1fdd8013e24dea04 100644 (file)
@@ -36,10 +36,10 @@ public class GridResizeHiddenColumn extends GridEditorUI {
 
         addComponent(grid);
 
-        grid.addColumnResizeListener(event -> {
-            log(String.format("Column resized: id=%s, width=%s",
-                    event.getColumn().getId(), event.getColumn().getWidth()));
-        });
+        grid.addColumnResizeListener(
+                event -> log(String.format("Column resized: id=%s, width=%s",
+                        event.getColumn().getId(),
+                        event.getColumn().getWidth())));
     }
 
     @Override
index 1b3a7a0ab27b28631749af9e6066d7dcc5f49d1c..c0985ef688a30d47854e090076b55007c700f1ce 100644 (file)
@@ -46,9 +46,8 @@ public class GridRowHeightChange extends AbstractReindeerTestUI {
                 "Theme selector", themes);
         themeSelector.setSelectedItem("reindeer");
         themeSelector.setEmptySelectionAllowed(false);
-        themeSelector.addValueChangeListener(event -> {
-            setTheme(event.getValue());
-        });
+        themeSelector
+                .addValueChangeListener(event -> setTheme(event.getValue()));
 
         VerticalLayout layout = new VerticalLayout();
         layout.setSpacing(true);
index 76ece763d268a51b97bee6c42a5bf2308d619f73..ccbb5ba7b0ec2e385daed61dd06a621ce3c12b26 100644 (file)
@@ -46,7 +46,6 @@ public class GridScrollToLineWhileResizing extends AbstractReindeerTestUI {
         });
 
         vsp.setFirstComponent(grid);
-
     }
 
     @Override
index 85ab5ab5770f9199240a776f1add9fda58a00167..4d550d41ff1c304b5103f9bdf8448d274fca397c 100644 (file)
@@ -378,10 +378,10 @@ public class GridBasics extends AbstractTestUIWithLog {
                 3.67, 4.00, 4.33, 4.67)
                 .forEach(d -> addGridMethodMenu(heightByRows,
                         df.format(d) + " rows", d, grid::setHeightByRows));
-        sizeMenu.addItem("HeightMode Row", item -> {
-            grid.setHeightMode(
-                    item.isChecked() ? HeightMode.ROW : HeightMode.CSS);
-        }).setCheckable(true);
+        sizeMenu.addItem("HeightMode Row",
+                item -> grid.setHeightMode(
+                        item.isChecked() ? HeightMode.ROW : HeightMode.CSS))
+                .setCheckable(true);
 
         MenuItem heightMenu = sizeMenu.addItem("Height", null);
         Stream.of(50, 100, 200, 400).map(i -> i + "px").forEach(
@@ -514,7 +514,8 @@ public class GridBasics extends AbstractTestUIWithLog {
                 sg -> grid.getColumns().forEach(c -> c.setStyleGenerator(t -> {
                     if (t.getRowNumber() % 4 == 1) {
                         return null;
-                    } else if (t.getRowNumber() % 4 == 3
+                    }
+                    if (t.getRowNumber() % 4 == 3
                             && c.getCaption().equals("Column 1")) {
                         return null;
                     }
@@ -539,9 +540,8 @@ public class GridBasics extends AbstractTestUIWithLog {
                 grid.getSelectionModel().select(item);
             }
         });
-        rowMenu.addItem("Deselect all", menuItem -> {
-            grid.getSelectionModel().deselectAll();
-        });
+        rowMenu.addItem("Deselect all",
+                menuItem -> grid.getSelectionModel().deselectAll());
 
         MenuItem rowHeight = rowMenu.addItem("Body Row Height", null);
         Stream.of(-1, 20, 50, 100).forEach(i -> rowHeight.addItem("" + i,
@@ -559,9 +559,7 @@ public class GridBasics extends AbstractTestUIWithLog {
                             .addSingleSelectionListener(this::onSingleSelect);
             grid.asSingleSelect().setReadOnly(isUserSelectionDisallowed);
         });
-        selectionModelItem.addItem("multi", menuItem -> {
-            switchToMultiSelect();
-        });
+        selectionModelItem.addItem("multi", menuItem -> switchToMultiSelect());
         selectionModelItem.addItem("none", menuItem -> {
             selectionListenerRegistration.remove();
             grid.setSelectionMode(SelectionMode.NONE);
@@ -629,24 +627,18 @@ public class GridBasics extends AbstractTestUIWithLog {
                 row.getCell(column).setText("Header cell " + i++);
             }
         });
-        headerMenu.addItem("Remove first header row", menuItem -> {
-            grid.removeHeaderRow(0);
-        });
-        headerMenu.addItem("Set first row as default", menuItem -> {
-            grid.setDefaultHeaderRow(grid.getHeaderRow(0));
-        });
-        headerMenu.addItem("Set no default row", menuItem -> {
-            grid.setDefaultHeaderRow(null);
-        });
-        headerMenu.addItem("Merge Header Cells [0,0..1]", menuItem -> {
-            mergeHeaderСells(0, "0+1", 0, 1);
-        });
-        headerMenu.addItem("Merge Header Cells [1,1..3]", menuItem -> {
-            mergeHeaderСells(1, "1+2+3", 1, 2, 3);
-        });
-        headerMenu.addItem("Merge Header Cells [0,6..7]", menuItem -> {
-            mergeHeaderСells(0, "6+7", 6, 7);
-        });
+        headerMenu.addItem("Remove first header row",
+                menuItem -> grid.removeHeaderRow(0));
+        headerMenu.addItem("Set first row as default",
+                menuItem -> grid.setDefaultHeaderRow(grid.getHeaderRow(0)));
+        headerMenu.addItem("Set no default row",
+                menuItem -> grid.setDefaultHeaderRow(null));
+        headerMenu.addItem("Merge Header Cells [0,0..1]",
+                menuItem -> mergeHeaderСells(0, "0+1", 0, 1));
+        headerMenu.addItem("Merge Header Cells [1,1..3]",
+                menuItem -> mergeHeaderСells(1, "1+2+3", 1, 2, 3));
+        headerMenu.addItem("Merge Header Cells [0,6..7]",
+                menuItem -> mergeHeaderСells(0, "6+7", 6, 7));
 
         MenuItem rowHeight = headerMenu.addItem("Header Row Height", null);
         Stream.of(-1, 20, 50, 100).forEach(i -> rowHeight.addItem("" + i,
@@ -702,18 +694,14 @@ public class GridBasics extends AbstractTestUIWithLog {
                 row.getCell(column).setText("Footer cell " + i++);
             }
         });
-        footerMenu.addItem("Remove first footer row", menuItem -> {
-            grid.removeFooterRow(0);
-        });
-        footerMenu.addItem("Merge Footer Cells [0,0..1]", menuItem -> {
-            mergeFooterСells(0, "0+1", 0, 1);
-        });
-        footerMenu.addItem("Merge Footer Cells [1,1..3]", menuItem -> {
-            mergeFooterСells(1, "1+2+3", 1, 2, 3);
-        });
-        footerMenu.addItem("Merge Footer Cells [0,6..7]", menuItem -> {
-            mergeFooterСells(0, "6+7", 6, 7);
-        });
+        footerMenu.addItem("Remove first footer row",
+                menuItem -> grid.removeFooterRow(0));
+        footerMenu.addItem("Merge Footer Cells [0,0..1]",
+                menuItem -> mergeFooterСells(0, "0+1", 0, 1));
+        footerMenu.addItem("Merge Footer Cells [1,1..3]",
+                menuItem -> mergeFooterСells(1, "1+2+3", 1, 2, 3));
+        footerMenu.addItem("Merge Footer Cells [0,6..7]",
+                menuItem -> mergeFooterСells(0, "6+7", 6, 7));
 
         MenuItem rowHeight = footerMenu.addItem("Footer Row Height", null);
         Stream.of(-1, 20, 50, 100).forEach(i -> rowHeight.addItem("" + i,
index c1ed6a5e42071848c4c50ebb9b3b27ea00cb0f48..d6c5a481ab8a7aebd967ab1756d6ab76fbefe679 100644 (file)
@@ -16,9 +16,8 @@ public class GridLayoutWithLabel extends AbstractTestUI {
         layout.addComponent(new Label("This is the label"), 0, 0);
 
         CheckBox cb = new CheckBox("Unchecked");
-        cb.addValueChangeListener(evt -> {
-            cb.setCaption(evt.getValue() ? "Checked" : "Unchecked");
-        });
+        cb.addValueChangeListener(
+                evt -> cb.setCaption(evt.getValue() ? "Checked" : "Unchecked"));
 
         layout.addComponent(cb, 1, 0);
 
index caffe145f2145290e40cbe2c8070cfe06f1bcd03..93dbd2bb124cde82337b2e46b5ae9932689d3b0d 100644 (file)
@@ -37,9 +37,8 @@ public class DuplicateJavascriptDependencies extends AbstractTestUIWithLog {
 
     @Override
     protected void setup(VaadinRequest request) {
-        addComponent(new Button("Test", e -> {
-            addComponent(new ResultLabel("It works"));
-        }));
+        addComponent(new Button("Test",
+                e -> addComponent(new ResultLabel("It works"))));
     }
 
 }
index 058d4a1cfb06de813ef859f757dabfe46af4ce0e..ffd1a2fb0584326a3e82810e4fd5d5ae6c8c79e1 100644 (file)
@@ -26,10 +26,9 @@ public class LoginFormUI extends AbstractReindeerTestUI {
         getPasswordCaption().ifPresent(loginForm::setPasswordCaption);
         getLoginCaption().ifPresent(loginForm::setLoginButtonCaption);
         updateCaption();
-        loginForm.addLoginListener(event -> {
-            login(event.getSource(), event.getLoginParameter("username"),
-                    event.getLoginParameter("password"));
-        });
+        loginForm.addLoginListener(event -> login(event.getSource(),
+                event.getLoginParameter("username"),
+                event.getLoginParameter("password")));
 
         loginFormLayout.addComponent(loginForm);
 
index 7f4f3c855b91e7a39babd9554361a1b171c65fcc..a6769bfa04d472da2c459c552cf1f1350a627010 100644 (file)
@@ -14,9 +14,8 @@ public class ConfigurableRichTextAreaUI
     @Override
     protected void createActions() {
         super.createActions();
-        createClickAction("Select all", CATEGORY_FEATURES, (rta, a, b) -> {
-            rta.selectAll();
-        }, null);
+        createClickAction("Select all", CATEGORY_FEATURES,
+                (rta, a, b) -> rta.selectAll(), null);
     }
 
 }
index 21be5201bca1f0a1bf55f05ac26d08ab37a2dc88..fc75a27de8857e5198f3e23c91397b11726a7ddf 100644 (file)
@@ -47,9 +47,8 @@ public class TextFieldEmptyingPrompt extends AbstractReindeerTestUI {
         addComponent(label);
 
         textField.setPlaceholder(RANDOM_PROMPT);
-        textField.addValueChangeListener(listener -> {
-            label.setValue("Textfield value: " + listener.getValue());
-        });
+        textField.addValueChangeListener(listener -> label
+                .setValue("Textfield value: " + listener.getValue()));
         addComponent(textField);
 
         Button button = new Button("Click To Remove Prompt");
index fd1528f8d47aa577941064aba7796901fdc79ea4..104b313a1fbf30eb25d3a5b6fd61b93e888cfa55 100644 (file)
@@ -149,12 +149,10 @@ public class TreeBasicFeatures extends AbstractTestUIWithLog {
     }
 
     private void createDescriptionMenu(MenuItem descriptionMenu) {
-        descriptionMenu.addItem("No Description", menu -> {
-            tree.setItemDescriptionGenerator(t -> null);
-        });
-        descriptionMenu.addItem("String.valueOf", menu -> {
-            tree.setItemDescriptionGenerator(String::valueOf);
-        });
+        descriptionMenu.addItem("No Description",
+                menu -> tree.setItemDescriptionGenerator(t -> null));
+        descriptionMenu.addItem("String.valueOf",
+                menu -> tree.setItemDescriptionGenerator(String::valueOf));
     }
 
     private void createContentModeMenu(MenuItem contentModeMenu) {
index ed0a89274ac4651f56ab0079a6ce2330306ba684..a915f6e0bddc3fff4ed66516e7e8897de415b7cb 100644 (file)
@@ -35,19 +35,22 @@ public class TreeGridAriaRowcount extends AbstractTestUI {
         addComponent(grid);
 
         addComponent(new Button("addFooter", event -> grid.addFooterRowAt(0)));
-        addComponent(new Button("removeFooter", event -> grid.removeFooterRow(0)));
+        addComponent(
+                new Button("removeFooter", event -> grid.removeFooterRow(0)));
 
         addComponent(new Button("addHeader", event -> grid.addHeaderRowAt(1)));
-        addComponent(new Button("removeHeader", event -> grid.removeHeaderRow(1)));
+        addComponent(
+                new Button("removeHeader", event -> grid.removeHeaderRow(1)));
 
-        addComponent(new Button("setItemsTo3", event -> grid.setItems("a", "b", "c")));
-        addComponent(new Button("setItemsTo6", event -> grid.setItems("a", "b", "c", "d", "e", "f")));
+        addComponent(new Button("setItemsTo3",
+                event -> grid.setItems("a", "b", "c")));
+        addComponent(new Button("setItemsTo6",
+                event -> grid.setItems("a", "b", "c", "d", "e", "f")));
 
         addComponent(new Button("updateAll", event -> {
             grid.addFooterRowAt(0);
             grid.addHeaderRowAt(0);
             grid.setItems("a", "b", "c", "d");
         }));
-
     }
 }
index 2ed2c4f1f4d03620faa5f50524144c9c545482a5..03accaf0c0b25d5ebbe08559a2576e88a0b4a159 100644 (file)
@@ -24,7 +24,7 @@ public class TreeGridDragAndDrop extends AbstractTestUIWithLog {
                 .setId("string");
         grid.addColumn(HierarchicalTestBean::getDepth).setCaption("Depth")
                 .setId("depth").setDescriptionGenerator(
-                t -> "Hierarchy depth: " + t.getDepth());
+                        t -> "Hierarchy depth: " + t.getDepth());
         grid.addColumn(HierarchicalTestBean::getIndex)
                 .setCaption("Index on this depth").setId("index");
         grid.setHierarchyColumn("string");
@@ -37,11 +37,9 @@ public class TreeGridDragAndDrop extends AbstractTestUIWithLog {
         TreeGridDropTarget<HierarchicalTestBean> dropTarget = new TreeGridDropTarget<>(
                 grid, DropMode.ON_TOP_OR_BETWEEN);
 
-        dropTarget.addTreeGridDropListener(event -> {
-            log("depth=" + event.getDropTargetRowDepth().orElse(null)
-                    + ", collapsed=" + event.isDropTargetRowCollapsed()
-                    .orElse(null));
-        });
+        dropTarget.addTreeGridDropListener(event -> log("depth="
+                + event.getDropTargetRowDepth().orElse(null) + ", collapsed="
+                + event.isDropTargetRowCollapsed().orElse(null)));
 
         addComponent(grid);
     }
index 11afe6ba0a35d8365e4f9ba7eef19247480bbbe7..68d5fe87d9e5bf9aaf2ccb292ca0a11a54049bd0 100644 (file)
@@ -26,9 +26,8 @@ public class TreeGridInWindow extends AbstractTestUI {
 
         Window window = new Window("Window", treeGrid);
 
-        Button openWindow = new Button("Open window", event -> {
-            UI.getCurrent().addWindow(window);
-        });
+        Button openWindow = new Button("Open window",
+                event -> UI.getCurrent().addWindow(window));
 
         getLayout().addComponent(openWindow);
     }
index f31348863a530e64ce44d12761c9fbfb54e7cc7a..127a831274b851081af2b4fccdd990283106f282 100644 (file)
@@ -98,16 +98,13 @@ public class DummyData extends AbstractTestUIWithLog {
 
         HorizontalLayout controls = new HorizontalLayout();
         addComponent(controls);
-        controls.addComponent(new Button("Select Foo 20", e -> {
-            dummy.setValue("Foo " + 20);
-        }));
-        controls.addComponent(new Button("Reset data provider", e -> {
-            dummy.setDataProvider(new LoggingDataProvider(items));
-        }));
-        controls.addComponent(new Button("Remove all data", e -> {
-            dummy.setDataProvider(
-                    new LoggingDataProvider(Collections.emptyList()));
-        }));
+        controls.addComponent(
+                new Button("Select Foo 20", e -> dummy.setValue("Foo " + 20)));
+        controls.addComponent(new Button("Reset data provider",
+                e -> dummy.setDataProvider(new LoggingDataProvider(items))));
+        controls.addComponent(
+                new Button("Remove all data", e -> dummy.setDataProvider(
+                        new LoggingDataProvider(Collections.emptyList()))));
         addComponent(dummy);
     }
 }
index b37956d126d85a59b32c20550ab214417ac677f9..509aee84950d43e3990685b02d2ecb790e91703d 100644 (file)
@@ -36,9 +36,9 @@ public class GridRefreshWithGetId extends AbstractTestUI {
         }
 
         /**
-         * The class intentionally has strange {@code hashCode()} and {@code equals()}
-         * implementation to ensure if {@code Grid} relies on bean id rather than on
-         * bean hashcode/equals identification.
+         * The class intentionally has strange {@code hashCode()} and
+         * {@code equals()} implementation to ensure if {@code Grid} relies on
+         * bean id rather than on bean hashcode/equals identification.
          *
          * {@see Object.equals}
          */
@@ -58,9 +58,9 @@ public class GridRefreshWithGetId extends AbstractTestUI {
         }
 
         /**
-         * The class intentionally has strange {@code hashCode()} and {@code equals()}
-         * implementation to ensure if {@code Grid} relies on bean id rather than on
-         * bean hashcode/equals identification.
+         * The class intentionally has strange {@code hashCode()} and
+         * {@code equals()} implementation to ensure if {@code Grid} relies on
+         * bean id rather than on bean hashcode/equals identification.
          *
          * {@see Object.hashCode}
          */
@@ -94,9 +94,7 @@ public class GridRefreshWithGetId extends AbstractTestUI {
         grid.setDataProvider(dataProvider);
         addComponent(grid);
 
-        grid.addColumn(myObject -> {
-            return myObject.getName();
-        });
+        grid.addColumn(TestObject::getName);
 
         Button button = new Button("Change green to black");
         button.addClickListener(event1 -> {
index 8f04ed18359c410feac983a74f8adf571e91adb2..6f5c3173d2c8c2431bd1aff1716b6ee23930f3f5 100644 (file)
@@ -22,9 +22,9 @@ import com.vaadin.annotations.Theme;
 import com.vaadin.annotations.Widgetset;
 import com.vaadin.server.Page;
 import com.vaadin.server.VaadinRequest;
-import com.vaadin.shared.ui.dnd.criteria.ComparisonOperator;
 import com.vaadin.shared.ui.dnd.DropEffect;
 import com.vaadin.shared.ui.dnd.EffectAllowed;
+import com.vaadin.shared.ui.dnd.criteria.ComparisonOperator;
 import com.vaadin.tests.components.AbstractTestUIWithLog;
 import com.vaadin.ui.CheckBox;
 import com.vaadin.ui.HorizontalLayout;
@@ -126,15 +126,12 @@ public class DragAndDropCardShuffle extends AbstractTestUIWithLog {
         dragSource.setPayload("card_value", cardValue);
 
         // Add listeners
-        dragSource.addDragStartListener(event -> {
-            log(event.getComponent().getValue() + " dragstart, effectsAllowed="
-                    + event.getEffectAllowed());
-        });
+        dragSource.addDragStartListener(e -> log(
+                e.getComponent().getValue() + " dragstart, effectsAllowed="
+                        + e.getEffectAllowed()));
 
-        dragSource.addDragEndListener(event -> {
-            log(event.getComponent().getValue() + " dragend, dropEffect="
-                    + event.getDropEffect());
-        });
+        dragSource.addDragEndListener(e -> log(e.getComponent().getValue()
+                        + " dragend, dropEffect=" + e.getDropEffect()));
 
         sources.add(dragSource);
     }
@@ -145,28 +142,27 @@ public class DragAndDropCardShuffle extends AbstractTestUIWithLog {
                 target);
 
         // Cards can be dropped onto others with smaller value
-        dropTarget.setDropCriterion("card_value", ComparisonOperator.SMALLER_THAN,
-                cardValue);
+        dropTarget.setDropCriterion("card_value",
+                ComparisonOperator.SMALLER_THAN, cardValue);
 
         // Add listener
-        dropTarget.addDropListener(event -> {
-            event.getDragSourceExtension().ifPresent(dragSource -> {
-                if (dragSource.getParent() instanceof Label) {
-                    Label source = (Label) dragSource.getParent();
-
-                    // Swap source and target components
-                    desk.replaceComponent(target, source);
-
-                    log(event.getComponent().getValue() + " drop received "
-                            + source.getValue() + ", dropEffect="
-                            + event.getDropEffect() + ", mouseEventDetails="
-                            + event.getMouseEventDetails());
-                } else {
-                    log(event.getComponent().getValue()
-                            + " drop received something else than card");
-                }
-            });
-        });
+        dropTarget.addDropListener(event -> event.getDragSourceExtension()
+                .ifPresent(dragSource -> {
+                    if (dragSource.getParent() instanceof Label) {
+                        Label source = (Label) dragSource.getParent();
+
+                        // Swap source and target components
+                        desk.replaceComponent(target, source);
+
+                        log(event.getComponent().getValue() + " drop received "
+                                + source.getValue() + ", dropEffect="
+                                + event.getDropEffect() + ", mouseEventDetails="
+                                + event.getMouseEventDetails());
+                    } else {
+                        log(event.getComponent().getValue()
+                                + " drop received something else than card");
+                    }
+                }));
 
         targets.add(dropTarget);
     }
index 708f259615f5a7a12d3c12627a2d5944ca71d8a4..70b520705ae5f0efb5e1c56435e55f7fbb6b42ac 100644 (file)
@@ -39,69 +39,74 @@ public class Html5FileDragAndDropUpload extends AbstractTestUIWithLog {
     @Override
     protected void setup(VaadinRequest request) {
 
-        Grid<FileParameters> grid = new Grid<>("Drop files or text on the Grid");
+        Grid<FileParameters> grid = new Grid<>(
+                "Drop files or text on the Grid");
         grid.addColumn(FileParameters::getName).setCaption("File name");
         grid.addColumn(FileParameters::getSize).setCaption("File size");
         grid.addColumn(FileParameters::getMime).setCaption("Mime type");
 
         List<FileParameters> gridItems = new ArrayList<>();
 
-        new FileDropTarget<Grid<FileParameters>>(grid, event -> {
-            event.getFiles().forEach(html5File -> {
-                if (html5File.getFileSize() > FILE_SIZE_LIMIT) {
-                    Notification.show(html5File.getFileName()
-                            + " is too large (max 5 MB)");
-                    return;
-                }
-
-                html5File.setStreamVariable(new StreamVariable() {
-                    @Override
-                    public OutputStream getOutputStream() {
-                        return new OutputStream() {
-                            @Override
-                            public void write(int b) throws IOException {
-                                // NOP
-                            }
-                        };
+        new FileDropTarget<Grid<FileParameters>>(grid,
+                event -> event.getFiles().forEach(html5File -> {
+                    if (html5File.getFileSize() > FILE_SIZE_LIMIT) {
+                        Notification.show(html5File.getFileName()
+                                + " is too large (max 5 MB)");
+                        return;
                     }
 
-                    @Override
-                    public boolean listenProgress() {
-                        return true;
-                    }
-
-                    @Override
-                    public void onProgress(StreamingProgressEvent event) {
-                        log("Progress, bytesReceived=" + event
-                                .getBytesReceived());
-                    }
-
-                    @Override
-                    public void streamingStarted(StreamingStartEvent event) {
-                        log("Stream started, fileName=" + event.getFileName());
-                    }
-
-                    @Override
-                    public void streamingFinished(StreamingEndEvent event) {
-                        gridItems.add(new FileParameters(event.getFileName(),
-                                event.getContentLength(), event.getMimeType()));
-                        grid.setItems(gridItems);
-
-                        log("Stream finished, fileName=" + event.getFileName());
-                    }
-
-                    @Override
-                    public void streamingFailed(StreamingErrorEvent event) {
-                        log("Stream failed, fileName=" + event.getFileName());
-                    }
-
-                    @Override
-                    public boolean isInterrupted() {
-                        return false;
-                    }
-                });
-            });
-        });
+                    html5File.setStreamVariable(new StreamVariable() {
+                        @Override
+                        public OutputStream getOutputStream() {
+                            return new OutputStream() {
+                                @Override
+                                public void write(int b) throws IOException {
+                                    // NOP
+                                }
+                            };
+                        }
+
+                        @Override
+                        public boolean listenProgress() {
+                            return true;
+                        }
+
+                        @Override
+                        public void onProgress(StreamingProgressEvent event) {
+                            log("Progress, bytesReceived="
+                                    + event.getBytesReceived());
+                        }
+
+                        @Override
+                        public void streamingStarted(
+                                StreamingStartEvent event) {
+                            log("Stream started, fileName="
+                                    + event.getFileName());
+                        }
+
+                        @Override
+                        public void streamingFinished(StreamingEndEvent event) {
+                            gridItems.add(new FileParameters(event.getFileName(),
+                                            event.getContentLength(),
+                                            event.getMimeType()));
+                            grid.setItems(gridItems);
+
+                            log("Stream finished, fileName="
+                                    + event.getFileName());
+                        }
+
+                        @Override
+                        public void streamingFailed(StreamingErrorEvent event) {
+                            log("Stream failed, fileName="
+                                    + event.getFileName());
+                        }
+
+                        @Override
+                        public boolean isInterrupted() {
+                            return false;
+                        }
+                    });
+                }));
 
         GridDropTarget<FileParameters> dropTarget = new GridDropTarget<>(grid,
                 DropMode.ON_TOP);
index 0b4a110ef7d41e9562f238cae0d60ba5b1732ec3..2bfc9540a351c1b191c86d40225a060140f76357 100644 (file)
@@ -99,9 +99,8 @@ public class ComponentElementGetValue extends AbstractTestUI {
         components.add(new TwinColSelect<>("", createData()));
         components.forEach(c -> {
             c.select(TEST_STRING_VALUE);
-            c.addValueChangeListener(event -> {
-                valueChangeLabel.setValue(MULTI_SELECT_VALUE_CHANGE);
-            });
+            c.addValueChangeListener(event -> valueChangeLabel
+                    .setValue(MULTI_SELECT_VALUE_CHANGE));
             addComponent((Component) c);
         });
     }
@@ -118,9 +117,8 @@ public class ComponentElementGetValue extends AbstractTestUI {
             AbstractTextField field = fieldComponents[i];
             field.setValue(TEST_STRING_VALUE);
             String value = FIELD_VALUES[i];
-            field.addValueChangeListener(event -> {
-                valueChangeLabel.setValue(value);
-            });
+            field.addValueChangeListener(
+                    event -> valueChangeLabel.setValue(value));
             addComponent(field);
         }
 
@@ -135,9 +133,8 @@ public class ComponentElementGetValue extends AbstractTestUI {
         DateField df = new DateField();
         df.setDateFormat("yyyy-MM-dd");
         df.setValue(TEST_DATE_VALUE);
-        df.addValueChangeListener(event -> {
-            valueChangeLabel.setValue(DATEFIELD_VALUE_CHANGE);
-        });
+        df.addValueChangeListener(
+                event -> valueChangeLabel.setValue(DATEFIELD_VALUE_CHANGE));
         return df;
     }
 
@@ -151,9 +148,8 @@ public class ComponentElementGetValue extends AbstractTestUI {
     private CheckBox createCheckBox() {
         CheckBox cb = new CheckBox();
         cb.setValue(true);
-        cb.addValueChangeListener(event -> {
-            valueChangeLabel.setValue(CHECKBOX_VALUE_CHANGE);
-        });
+        cb.addValueChangeListener(
+                event -> valueChangeLabel.setValue(CHECKBOX_VALUE_CHANGE));
         return cb;
     }
 
index 12b117c3a0f4fdb0dfa9534d321059a20e954503..0e7dcf2e161a622b16cdb6769122fbe3b6e32269 100644 (file)
@@ -27,9 +27,8 @@ public class ComboBoxInputNotAllowed extends AbstractTestUI {
     protected void setup(VaadinRequest request) {
         ComboBox<String> comboBox = new ComboBox<>("", ITEMS);
         comboBox.setTextInputAllowed(false);
-        comboBox.addValueChangeListener(e -> {
-            addComponent(new Label("Value is now: " + e.getValue()));
-        });
+        comboBox.addValueChangeListener(
+                e -> addComponent(new Label("Value is now: " + e.getValue())));
 
         addComponent(comboBox);
     }
index 08c1a51a7b9b39cdf01a31af9c6381da1bbc7e39..68a7d21e39ad880dd28176f0925aedb50e89f1ea 100644 (file)
@@ -49,9 +49,8 @@ public class ComboBoxUI extends AbstractTestUI {
         comboBox.setItemIconGenerator(item -> {
             if (item.equals("EUR")) {
                 return new ThemeResource("shared/img/spinner.gif");
-            } else {
-                return new ThemeResource("notfound.png");
             }
+            return new ThemeResource("notfound.png");
         });
         addComponent(comboBox);
     }
index d4f1bfd8be88c85739f957f32f176ef88612a886..4055a26ec23bfeffa0d730a01fc6c9451312b7a7 100644 (file)
@@ -53,11 +53,8 @@ public class SelectByText extends AbstractTestUI {
         combobox.setItems(options);
 
         layout.addComponent(combobox);
-        combobox.addValueChangeListener(e -> {
-            layout.addComponent(
-                    new Label("Value is now '" + e.getValue() + "'"));
-        });
-
+        combobox.addValueChangeListener(e -> layout.addComponent(
+                new Label("Value is now '" + e.getValue() + "'")));
     }
 
     @Override
index a90072c31f83f36e4de3a895f612ad884ad9b5dc..4c42cc00d40f51a1a706ffbd9fbd7052309201bc 100644 (file)
@@ -26,10 +26,8 @@ public class GridUI extends AbstractTestUI {
         row.getCell(column).setText("extra row");
         grid.addColumn(Item::getBar).setCaption("bar");
 
-        grid.setDetailsGenerator(item -> {
-            return new Label(
-                    "Foo = " + item.getFoo() + " Bar = " + item.getBar());
-        });
+        grid.setDetailsGenerator(item -> new Label(
+                "Foo = " + item.getFoo() + " Bar = " + item.getBar()));
         grid.addItemClickListener(event -> {
             if (event.getMouseEventDetails().isDoubleClick()) {
                 grid.setDetailsVisible(event.getItem(),
index e71ff3d9d64a8091c2076e68b3c6599079989679..aa51a1480cb440a17dd09835b0aa745ae168be05 100644 (file)
@@ -21,9 +21,8 @@ public class GridLayoutCaptionOnBottomAlignedComponent extends AbstractTestUI {
 
         addComponent(layout);
 
-        Button realign = new Button("Realign", evt -> {
-            layout.setComponentAlignment(component, Alignment.TOP_LEFT);
-        });
+        Button realign = new Button("Realign", evt -> layout
+                .setComponentAlignment(component, Alignment.TOP_LEFT));
         addComponent(realign);
     }
 }
index adfd48c41c7bf7f128fe737f969cd34929a69480..aca29935fb2d154c4e100c1abe2a75e3185821a8 100644 (file)
@@ -52,16 +52,13 @@ public class DelayedViewLeaveConfirmation extends AbstractTestUI {
             input = new TextField("Enter a value");
             input.setId("input");
             Button navigateAway = new Button("Navigate to the other view",
-                    e -> {
-                        getUI().getNavigator().navigateTo("other");
-                    });
-            Button logout = new Button("Simulate logout", e -> {
-                getUI().getNavigator().runAfterLeaveConfirmation(() -> {
-                    removeAllComponents();
-                    addComponent(new Label("You have been logged out"));
-                    getUI().getPage().setUriFragment("", false);
-                });
-            });
+                    e -> getUI().getNavigator().navigateTo("other"));
+            Button logout = new Button("Simulate logout", e -> getUI()
+                    .getNavigator().runAfterLeaveConfirmation(() -> {
+                        removeAllComponents();
+                        addComponent(new Label("You have been logged out"));
+                        getUI().getPage().setUriFragment("", false);
+                    }));
             navigateAway.setId("navigateAway");
             logout.setId("logout");
             addComponents(saved, input, navigateAway, logout);
@@ -95,9 +92,7 @@ public class DelayedViewLeaveConfirmation extends AbstractTestUI {
                 action.run();
             });
             leave.setId("leave");
-            Button stay = new Button("NO, STAY!", e -> {
-                close();
-            });
+            Button stay = new Button("NO, STAY!", e -> close());
             stay.setId("stay");
             layout.addComponents(new HorizontalLayout(leave, stay));
             setContent(layout);
index 6fc1338e2851c41f85d46ec05c8f642bb8ea3a7b..9c6eeb446a6865fa4f9a73e3f1898c973c7956ba 100644 (file)
@@ -32,10 +32,8 @@ public class FrontendLaterLoadedResourceUI extends AbstractTestUIWithLog {
     @Override
     protected void setup(VaadinRequest request) {
         Button b = new MyButton();
-        b.addClickListener(e -> {
-            getPage().getJavaScript()
-                    .execute("document.body.innerHTML=window.jsFile;\n");
-        });
+        b.addClickListener(e -> getPage().getJavaScript()
+                .execute("document.body.innerHTML=window.jsFile;\n"));
         addComponent(b);
     }
 
index 3bcfac446268434f7430aaf1897753f3ad43b23e..346e9ef7cfdc641d5bd170393d10015b4629eff7 100644 (file)
@@ -21,21 +21,18 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class TreeBasicFeaturesTest extends MultiBrowserTest {
 
-    private static final Predicate<TestBenchElement> THEME_RESOURCE = e -> {
-        return e.isElementPresent(By.tagName("img"))
-                && e.findElement(By.tagName("img")).getAttribute("src")
-                        .contains("bullet.png");
-    };
-    private static final Predicate<TestBenchElement> VAADIN_ICON = e -> {
-        return e.isElementPresent(By.className("v-icon"))
-                && e.findElement(By.className("v-icon")).getAttribute("class")
-                        .contains("Vaadin-Icons");
-    };
-    private static final Predicate<TestBenchElement> CLASS_RESOURCE = e -> {
-        return e.isElementPresent(By.tagName("img"))
-                && e.findElement(By.tagName("img")).getAttribute("src")
-                        .contains("m.gif");
-    };
+    private static final Predicate<TestBenchElement> THEME_RESOURCE =
+            e -> e.isElementPresent(By.tagName("img"))
+            && e.findElement(By.tagName("img")).getAttribute("src")
+                    .contains("bullet.png");
+    private static final Predicate<TestBenchElement> VAADIN_ICON =
+            e -> e.isElementPresent(By.className("v-icon"))
+            && e.findElement(By.className("v-icon")).getAttribute("class")
+                    .contains("Vaadin-Icons");
+    private static final Predicate<TestBenchElement> CLASS_RESOURCE =
+            e -> e.isElementPresent(By.tagName("img"))
+            && e.findElement(By.tagName("img")).getAttribute("src")
+                    .contains("m.gif");
 
     @Before
     public void before() {