import org.sonar.api.profiles.RulesProfile;
import org.sonar.api.resources.Languages;
import org.sonar.api.resources.Project;
-import org.sonar.api.scan.filesystem.ModuleExclusions;
+import org.sonar.api.scan.filesystem.FileExclusions;
import org.sonar.api.scan.filesystem.PathResolver;
import org.sonar.batch.DefaultProfileLoader;
import org.sonar.batch.DefaultProjectClasspath;
// file system
container.addSingleton(PathResolver.class);
- container.addSingleton(ModuleExclusions.class);
+ container.addSingleton(FileExclusions.class);
container.addSingleton(LanguageFileFilters.class);
container.addSingleton(ExclusionFileFilter.class);
container.addSingleton(DefaultProjectClasspath.class);
private boolean accept(File file, FileFilterContext context) {
context.setFileRelativePath(pathResolver.relativePath(context.sourceDir(), file));
+ try {
+ context.setFileCanonicalPath(file.getCanonicalPath());
+ } catch (Exception e) {
+ throw new IllegalStateException("Fail to get the canonical path of: " + file);
+ }
for (FileFilter fileFilter : fileFilters) {
if (!fileFilter.accept(file, context)) {
return false;
*/
package org.sonar.batch.scan.filesystem;
+import org.apache.commons.lang.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.sonar.api.BatchComponent;
import org.sonar.api.batch.ResourceFilter;
import org.sonar.api.resources.Resource;
import org.sonar.api.resources.ResourceUtils;
+import org.sonar.api.scan.filesystem.FileExclusions;
import org.sonar.api.scan.filesystem.FileFilter;
-import org.sonar.api.scan.filesystem.ModuleExclusions;
import org.sonar.api.utils.WildcardPattern;
import java.io.File;
public class ExclusionFileFilter implements FileFilter, ResourceFilter, BatchComponent {
- private final WildcardPattern[] sourceInclusions;
- private final WildcardPattern[] testInclusions;
- private final WildcardPattern[] sourceExclusions;
- private final WildcardPattern[] testExclusions;
+ private final FilePattern[] sourceInclusions;
+ private final FilePattern[] testInclusions;
+ private final FilePattern[] sourceExclusions;
+ private final FilePattern[] testExclusions;
- public ExclusionFileFilter(ModuleExclusions exclusions) {
- sourceInclusions = WildcardPattern.create(exclusions.sourceInclusions());
+ public ExclusionFileFilter(FileExclusions exclusions) {
+ sourceInclusions = FilePattern.create(exclusions.sourceInclusions());
log("Included sources: ", sourceInclusions);
- sourceExclusions = WildcardPattern.create(exclusions.sourceExclusions());
+ sourceExclusions = FilePattern.create(exclusions.sourceExclusions());
log("Excluded sources: ", sourceExclusions);
- testInclusions = WildcardPattern.create(exclusions.testInclusions());
+ testInclusions = FilePattern.create(exclusions.testInclusions());
log("Included tests: ", testInclusions);
- testExclusions = WildcardPattern.create(exclusions.testExclusions());
+ testExclusions = FilePattern.create(exclusions.testExclusions());
log("Excluded tests: ", testExclusions);
}
- private void log(String title, WildcardPattern[] patterns) {
+ private void log(String title, FilePattern[] patterns) {
if (patterns.length > 0) {
Logger log = LoggerFactory.getLogger(ExclusionFileFilter.class);
log.info(title);
- for (WildcardPattern pattern : patterns) {
+ for (FilePattern pattern : patterns) {
log.info(" " + pattern);
}
}
}
public boolean accept(File file, Context context) {
- WildcardPattern[] inclusionPatterns = (context.fileType() == FileType.TEST ? testInclusions : sourceInclusions);
+ FilePattern[] inclusionPatterns = (context.fileType() == FileType.TEST ? testInclusions : sourceInclusions);
if (inclusionPatterns.length > 0) {
boolean matchInclusion = false;
- for (WildcardPattern pattern : inclusionPatterns) {
- matchInclusion |= pattern.match(context.fileRelativePath());
+ for (FilePattern pattern : inclusionPatterns) {
+ matchInclusion |= pattern.match(context);
}
if (!matchInclusion) {
return false;
}
}
- WildcardPattern[] exclusionPatterns = (context.fileType() == FileType.TEST ? testExclusions : sourceExclusions);
- for (WildcardPattern pattern : exclusionPatterns) {
- if (pattern.match(context.fileRelativePath())) {
+ FilePattern[] exclusionPatterns = (context.fileType() == FileType.TEST ? testExclusions : sourceExclusions);
+ for (FilePattern pattern : exclusionPatterns) {
+ if (pattern.match(context)) {
return false;
}
}
}
private boolean isIgnoredFileResource(Resource resource) {
- WildcardPattern[] inclusionPatterns = (ResourceUtils.isUnitTestClass(resource) ? testInclusions : sourceInclusions);
+ FilePattern[] inclusionPatterns = (ResourceUtils.isUnitTestClass(resource) ? testInclusions : sourceInclusions);
if (inclusionPatterns.length > 0) {
boolean matchInclusion = false;
- for (WildcardPattern pattern : inclusionPatterns) {
- matchInclusion |= resource.matchFilePattern(pattern.toString());
+ for (FilePattern pattern : inclusionPatterns) {
+ matchInclusion |= pattern.match(resource);
}
if (!matchInclusion) {
return true;
}
}
- WildcardPattern[] exclusionPatterns = (ResourceUtils.isUnitTestClass(resource) ? testExclusions : sourceExclusions);
- for (WildcardPattern pattern : exclusionPatterns) {
- if (resource.matchFilePattern(pattern.toString())) {
+ FilePattern[] exclusionPatterns = (ResourceUtils.isUnitTestClass(resource) ? testExclusions : sourceExclusions);
+ for (FilePattern pattern : exclusionPatterns) {
+ if (pattern.match(resource)) {
return true;
}
}
return false;
}
- WildcardPattern[] sourceInclusions() {
+ FilePattern[] sourceInclusions() {
return sourceInclusions;
}
- WildcardPattern[] testInclusions() {
+ FilePattern[] testInclusions() {
return testInclusions;
}
- WildcardPattern[] sourceExclusions() {
+ FilePattern[] sourceExclusions() {
return sourceExclusions;
}
- WildcardPattern[] testExclusions() {
+ FilePattern[] testExclusions() {
return testExclusions;
}
+
+ static abstract class FilePattern {
+ final WildcardPattern pattern;
+
+ protected FilePattern(String pattern) {
+ this.pattern = WildcardPattern.create(pattern);
+ }
+
+ abstract boolean match(Context context);
+
+ abstract boolean match(Resource resource);
+
+ static FilePattern create(String s) {
+ if (StringUtils.startsWithIgnoreCase(s, "file:")) {
+ return new AbsolutePathPattern(StringUtils.substring(s, "file:".length()));
+ }
+ return new RelativePathPattern(s);
+ }
+
+ static FilePattern[] create(String[] s) {
+ FilePattern[] result = new FilePattern[s.length];
+ for (int i = 0; i < s.length; i++) {
+ result[i] = FilePattern.create(s[i]);
+ }
+ return result;
+ }
+ }
+
+ private static class AbsolutePathPattern extends FilePattern {
+ private AbsolutePathPattern(String pattern) {
+ super(pattern);
+ }
+
+ boolean match(Context context) {
+ return pattern.match(context.fileCanonicalPath());
+ }
+
+ boolean match(Resource resource) {
+ return false;
+ }
+
+ @Override
+ public String toString() {
+ return "file:" + pattern.toString();
+ }
+ }
+
+ private static class RelativePathPattern extends FilePattern {
+ private RelativePathPattern(String pattern) {
+ super(pattern);
+ }
+
+ boolean match(Context context) {
+ return pattern.match(context.fileRelativePath());
+ }
+
+ boolean match(Resource resource) {
+ return resource.matchFilePattern(pattern.toString());
+ }
+
+ @Override
+ public String toString() {
+ return pattern.toString();
+ }
+ }
}
private final FileFilter.FileType fileType;
private File sourceDir;
private String fileRelativePath;
+ private String fileCanonicalPath;
FileFilterContext(ModuleFileSystem fileSystem, FileFilter.FileType fileType) {
this.fileSystem = fileSystem;
return fileRelativePath;
}
- FileFilterContext setSourceDir(File sourceDir) {
- this.sourceDir = sourceDir;
+ public String fileCanonicalPath() {
+ return fileCanonicalPath;
+ }
+
+ FileFilterContext setSourceDir(File d) {
+ this.sourceDir = d;
+ return this;
+ }
+
+ FileFilterContext setFileRelativePath(String s) {
+ this.fileRelativePath = s;
return this;
}
- FileFilterContext setFileRelativePath(String fileRelativePath) {
- this.fileRelativePath = fileRelativePath;
+ FileFilterContext setFileCanonicalPath(String s) {
+ this.fileCanonicalPath = s;
return this;
}
}
import org.sonar.api.config.Settings;
import org.sonar.api.resources.File;
import org.sonar.api.resources.JavaFile;
+import org.sonar.api.resources.Project;
+import org.sonar.api.scan.filesystem.FileExclusions;
import org.sonar.api.scan.filesystem.FileFilter;
-import org.sonar.api.scan.filesystem.ModuleExclusions;
import org.sonar.api.scan.filesystem.ModuleFileSystem;
import java.io.IOException;
public void source_inclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*Dao.java");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
FileFilterContext context = new FileFilterContext(mock(ModuleFileSystem.class), FileFilter.FileType.SOURCE);
context.setFileRelativePath("com/mycompany/Foo.java");
public void source_exclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "**/*Dao.java");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
FileFilterContext context = new FileFilterContext(mock(ModuleFileSystem.class), FileFilter.FileType.SOURCE);
context.setFileRelativePath("com/mycompany/FooDao.java");
assertThat(filter.accept(temp.newFile(), context)).isTrue();
}
+ @Test
+ public void source_exclusion_by_absolute_path() throws IOException {
+ java.io.File includedFile = temp.newFile("Foo.java");
+ java.io.File excludedFile = temp.newFile("Bar.java");
+
+ Settings settings = new Settings();
+ settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "file:" + excludedFile.getCanonicalPath());
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
+
+ FileFilterContext context = new FileFilterContext(mock(ModuleFileSystem.class), FileFilter.FileType.SOURCE);
+ context.setFileRelativePath("org/bar/Foo.java");
+ context.setFileCanonicalPath(includedFile.getCanonicalPath());
+ assertThat(filter.accept(includedFile, context)).isTrue();
+
+ context.setFileRelativePath("org/bar/Bar.java");
+ context.setFileCanonicalPath(excludedFile.getCanonicalPath());
+ assertThat(filter.accept(excludedFile, context)).isFalse();
+ }
+
@Test
public void resource_inclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*Dao.c");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.isIgnored(new File("org/sonar", "FooDao.c"))).isFalse();
assertThat(filter.isIgnored(new File("org/sonar", "Foo.c"))).isTrue();
public void resource_exclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "**/*Dao.c");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.isIgnored(new File("org/sonar", "FooDao.c"))).isTrue();
assertThat(filter.isIgnored(new File("org/sonar", "Foo.c"))).isFalse();
public void java_resource_inclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*Dao.java");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.isIgnored(new JavaFile("org.sonar", "FooDao"))).isFalse();
assertThat(filter.isIgnored(new JavaFile("org.sonar", "Foo"))).isTrue();
public void java_resource_exclusions() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "**/*Dao.java");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.isIgnored(new JavaFile("org.sonar", "FooDao"))).isTrue();
assertThat(filter.isIgnored(new JavaFile("org.sonar", "Foo"))).isFalse();
}
+ @Test
+ public void do_not_check_exclusions_on_non_file_resources() throws IOException {
+ Settings settings = new Settings();
+ settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "*");
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
+
+ assertThat(filter.isIgnored(new Project("MyProject"))).isFalse();
+ }
+
@Test
public void test_settings() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "source/exclusions");
settings.setProperty(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY, "test/inclusions");
settings.setProperty(CoreProperties.PROJECT_TEST_EXCLUSIONS_PROPERTY, "test/exclusions");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.sourceInclusions()[0].toString()).isEqualTo("source/inclusions");
assertThat(filter.testInclusions()[0].toString()).isEqualTo("test/inclusions");
public void should_trim_pattern() throws IOException {
Settings settings = new Settings();
settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, " **/*Dao.java ");
- ExclusionFileFilter filter = new ExclusionFileFilter(new ModuleExclusions(settings));
+ ExclusionFileFilter filter = new ExclusionFileFilter(new FileExclusions(settings));
assertThat(filter.sourceExclusions()[0].toString()).isEqualTo("**/*Dao.java");
}
* Patterns of resource exclusion as defined in project settings page.
*
* @since 3.3 also applies exclusions in general settings page and global exclusions.
- * @deprecated replaced by {@link org.sonar.api.scan.filesystem.ModuleExclusions} in version 3.5
+ * @deprecated replaced by {@link org.sonar.api.scan.filesystem.FileExclusions} in version 3.5
*/
@Deprecated
public String[] getExclusionPatterns() {
* Also applies exclusions in general settings page and global exclusions.
*
* @since 3.3
- * @deprecated replaced by {@link org.sonar.api.scan.filesystem.ModuleExclusions} in version 3.5
+ * @deprecated replaced by {@link org.sonar.api.scan.filesystem.FileExclusions} in version 3.5
*/
@Deprecated
public String[] getTestExclusionPatterns() {
/**
* Set exclusion patterns. Configuration is not saved, so this method must be used ONLY IN UNIT TESTS.
- * @deprecated replaced by {@link org.sonar.api.scan.filesystem.ModuleExclusions} in version 3.5
+ * @deprecated replaced by {@link org.sonar.api.scan.filesystem.FileExclusions} in version 3.5
*/
@Deprecated
public Project setExclusionPatterns(String[] s) {
--- /dev/null
+/*
+ * Sonar, open source software quality management tool.
+ * Copyright (C) 2008-2012 SonarSource
+ * mailto:contact AT sonarsource DOT com
+ *
+ * Sonar is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * Sonar is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with Sonar; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
+ */
+package org.sonar.api.scan.filesystem;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.ObjectArrays;
+import org.apache.commons.lang.StringUtils;
+import org.sonar.api.BatchComponent;
+import org.sonar.api.CoreProperties;
+import org.sonar.api.config.Settings;
+
+import java.util.List;
+
+/**
+ * Configuration of file inclusions and exclusions
+ *
+ * @since 3.5
+ */
+public class FileExclusions implements BatchComponent {
+ private final Settings settings;
+
+ public FileExclusions(Settings settings) {
+ this.settings = settings;
+ }
+
+ public String[] sourceInclusions() {
+ return inclusions(CoreProperties.PROJECT_INCLUSIONS_PROPERTY);
+ }
+
+ public String[] testInclusions() {
+ return inclusions(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY);
+ }
+
+ private String[] inclusions(String propertyKey) {
+ String[] patterns = sanitize(settings.getStringArray(propertyKey));
+ List<String> list = Lists.newArrayList();
+ for (String pattern : patterns) {
+ if (!"**/*".equals(pattern) && !"file:**/*".equals(pattern)) {
+ list.add(pattern);
+ }
+ }
+ return list.toArray(new String[list.size()]);
+ }
+
+ public String[] sourceExclusions() {
+ return exclusions(CoreProperties.GLOBAL_EXCLUSIONS_PROPERTY, CoreProperties.PROJECT_EXCLUSIONS_PROPERTY);
+ }
+
+ public String[] testExclusions() {
+ return exclusions(CoreProperties.GLOBAL_TEST_EXCLUSIONS_PROPERTY, CoreProperties.PROJECT_TEST_EXCLUSIONS_PROPERTY);
+ }
+
+ private String[] exclusions(String globalExclusionsProperty, String exclusionsProperty) {
+ String[] globalExclusions = settings.getStringArray(globalExclusionsProperty);
+ String[] exclusions = settings.getStringArray(exclusionsProperty);
+ return sanitize(ObjectArrays.concat(globalExclusions, exclusions, String.class));
+ }
+
+ private static String[] sanitize(String[] patterns) {
+ for (int i = 0; i < patterns.length; i++) {
+ patterns[i] = StringUtils.trim(patterns[i]);
+ }
+ return patterns;
+ }
+}
ModuleFileSystem fileSystem();
FileType fileType();
File sourceDir();
+
+ /**
+ * File path relative to source directory. Never return null.
+ */
String fileRelativePath();
+
+ /**
+ * Absolute file path. Never return null.
+ */
+ String fileCanonicalPath();
}
boolean accept(File file, Context context);
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.api.scan.filesystem;
-
-import com.google.common.collect.Lists;
-import com.google.common.collect.ObjectArrays;
-import org.apache.commons.lang.StringUtils;
-import org.sonar.api.BatchComponent;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.config.Settings;
-
-import java.util.List;
-
-/**
- * Configuration of file inclusions and exclusions
- *
- * @since 3.5
- */
-public class ModuleExclusions implements BatchComponent {
- private final Settings settings;
-
- public ModuleExclusions(Settings settings) {
- this.settings = settings;
- }
-
- public String[] sourceInclusions() {
- return inclusions(CoreProperties.PROJECT_INCLUSIONS_PROPERTY);
- }
-
- public String[] testInclusions() {
- return inclusions(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY);
- }
-
- private String[] inclusions(String propertyKey) {
- String[] patterns = sanitize(settings.getStringArray(propertyKey));
- List<String> list = Lists.newArrayList();
- for (String pattern : patterns) {
- if (!"**/*".equals(pattern)) {
- list.add(pattern);
- }
- }
- return list.toArray(new String[list.size()]);
- }
-
- public String[] sourceExclusions() {
- return exclusions(CoreProperties.GLOBAL_EXCLUSIONS_PROPERTY, CoreProperties.PROJECT_EXCLUSIONS_PROPERTY);
- }
-
- public String[] testExclusions() {
- return exclusions(CoreProperties.GLOBAL_TEST_EXCLUSIONS_PROPERTY, CoreProperties.PROJECT_TEST_EXCLUSIONS_PROPERTY);
- }
-
- private String[] exclusions(String globalExclusionsProperty, String exclusionsProperty) {
- String[] globalExclusions = settings.getStringArray(globalExclusionsProperty);
- String[] exclusions = settings.getStringArray(exclusionsProperty);
- return sanitize(ObjectArrays.concat(globalExclusions, exclusions, String.class));
- }
-
- private static String[] sanitize(String[] patterns) {
- for (int i = 0; i < patterns.length; i++) {
- patterns[i] = StringUtils.trim(patterns[i]);
- }
- return patterns;
- }
-}
--- /dev/null
+/*
+ * Sonar, open source software quality management tool.
+ * Copyright (C) 2008-2012 SonarSource
+ * mailto:contact AT sonarsource DOT com
+ *
+ * Sonar is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * Sonar is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with Sonar; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
+ */
+package org.sonar.api.scan.filesystem;
+
+import org.junit.Test;
+import org.sonar.api.CoreProperties;
+import org.sonar.api.config.Settings;
+
+import static org.fest.assertions.Assertions.assertThat;
+
+public class FileExclusionsTest {
+ @Test
+ public void ignore_inclusion_of_world() {
+ Settings settings = new Settings();
+ settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*");
+ settings.setProperty(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY, "**/*");
+ assertThat(new FileExclusions(settings).sourceInclusions()).isEmpty();
+ assertThat(new FileExclusions(settings).testInclusions()).isEmpty();
+ }
+
+ @Test
+ public void load_inclusions() {
+ Settings settings = new Settings();
+ settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*Foo.java");
+ settings.setProperty(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY, "**/*FooTest.java");
+ FileExclusions moduleExclusions = new FileExclusions(settings);
+
+ assertThat(moduleExclusions.sourceInclusions()).containsOnly("**/*Foo.java");
+ assertThat(moduleExclusions.testInclusions()).containsOnly("**/*FooTest.java");
+ }
+
+ @Test
+ public void load_exclusions() {
+ Settings settings = new Settings();
+ settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "**/*Foo.java");
+ settings.setProperty(CoreProperties.PROJECT_TEST_EXCLUSIONS_PROPERTY, "**/*FooTest.java");
+ FileExclusions moduleExclusions = new FileExclusions(settings);
+
+ assertThat(moduleExclusions.sourceInclusions()).isEmpty();
+ assertThat(moduleExclusions.sourceExclusions()).containsOnly("**/*Foo.java");
+ assertThat(moduleExclusions.testInclusions()).isEmpty();
+ assertThat(moduleExclusions.testExclusions()).containsOnly("**/*FooTest.java");
+ }
+}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.api.scan.filesystem;
-
-import org.junit.Test;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.config.Settings;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class ModuleExclusionsTest {
- @Test
- public void ignore_inclusion_of_world() {
- Settings settings = new Settings();
- settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*");
- settings.setProperty(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY, "**/*");
- assertThat(new ModuleExclusions(settings).sourceInclusions()).isEmpty();
- assertThat(new ModuleExclusions(settings).testInclusions()).isEmpty();
- }
-
- @Test
- public void load_inclusions() {
- Settings settings = new Settings();
- settings.setProperty(CoreProperties.PROJECT_INCLUSIONS_PROPERTY, "**/*Foo.java");
- settings.setProperty(CoreProperties.PROJECT_TEST_INCLUSIONS_PROPERTY, "**/*FooTest.java");
- ModuleExclusions moduleExclusions = new ModuleExclusions(settings);
-
- assertThat(moduleExclusions.sourceInclusions()).containsOnly("**/*Foo.java");
- assertThat(moduleExclusions.testInclusions()).containsOnly("**/*FooTest.java");
- }
-
- @Test
- public void load_exclusions() {
- Settings settings = new Settings();
- settings.setProperty(CoreProperties.PROJECT_EXCLUSIONS_PROPERTY, "**/*Foo.java");
- settings.setProperty(CoreProperties.PROJECT_TEST_EXCLUSIONS_PROPERTY, "**/*FooTest.java");
- ModuleExclusions moduleExclusions = new ModuleExclusions(settings);
-
- assertThat(moduleExclusions.sourceInclusions()).isEmpty();
- assertThat(moduleExclusions.sourceExclusions()).containsOnly("**/*Foo.java");
- assertThat(moduleExclusions.testInclusions()).isEmpty();
- assertThat(moduleExclusions.testExclusions()).containsOnly("**/*FooTest.java");
- }
-}
projects / sonarqube.git / commitdiff