]> source.dussan.org Git - nextcloud-server.git/commitdiff
fix: lower threshold for system address book sync 41649/head
authorDaniel Kesselberg <mail@danielkesselberg.de>
Tue, 21 Nov 2023 18:46:13 +0000 (19:46 +0100)
committerDaniel Kesselberg <mail@danielkesselberg.de>
Wed, 22 Nov 2023 13:59:02 +0000 (14:59 +0100)
- Switch back to countUsers to have the actual value. countSeenUsers is bad if Nextcloud is connected to a larger directory, but only a part is using Nextcloud and therefore the seen count is much lower because the sync is done for all users.
- Lower the threshold to 100 for smaller installations.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
apps/dav/lib/Migration/Version1027Date20230504122946.php

index 6d0ac9f6f8671b70fa76d14cbfc4e1b72b1f2669..b1aaec0559b21f0d9ff5ee83d1373f3765f0993b 100644 (file)
@@ -49,7 +49,7 @@ class Version1027Date20230504122946 extends SimpleMigrationStep {
         * @param array $options
         */
        public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
-               if($this->userManager->countSeenUsers() > 1000) {
+               if($this->userManager->countSeenUsers() > 100 || array_sum($this->userManager->countUsers()) > 100) {
                        $this->config->setAppValue('dav', 'needs_system_address_book_sync', 'yes');
                        $output->info('Could not sync system address books during update - too many user records have been found. Please call occ dav:sync-system-addressbook manually.');
                        return;