SONAR-5718 Fix clipping effect

diff --git a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
index 981f29799dc1abd7eba98707e2156e574ba16dc3..e106896b9e995c292ea29c14aa6c3407c88cb826 100644 (file)
--- a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
+++ b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
@@ -236,9 +236,6 @@ define [
       line = issue.get('line') || 0
       @model.set key: componentKey, issueLine: line, issueIndex: issue.get('index')
 
-      # disable clipping effect of the black header
-      @$el.addClass 'full-height'
-
       @requestSources(line - LINES_AROUND, line + LINES_AROUND)
       .done (data) =>
         formattedSource = _.map data.sources, (item) => lineNumber: item[0], code: item[1]
@@ -255,7 +252,6 @@ define [
           @render()
           @bindScrollEvents()
           @bindShortcuts()
-          @$el.removeClass 'full-height'
           @scrollToLine issue.get 'line'
       .fail =>
         @source.set
@@ -265,7 +261,6 @@ define [
         @issues.reset @options.app.issues.filter (issue) => issue.get('component') == componentKey
         @render()
         @bindShortcuts()
-        @$el.removeClass 'full-height'
         @scrollToLine issue.get 'line'
 
 
@@ -289,6 +284,7 @@ define [
     scrollToLine: (line) ->
       row = @$("[data-line-number=#{line}]")
       goal = if row.length > 0 then row.offset().top - 200 else 0
+      goal = Math.max goal, 30
       $(window).scrollTop goal
 
 

diff --git a/server/sonar-web/src/main/less/issues.less b/server/sonar-web/src/main/less/issues.less
index fc416dc36e16cc61f051e22d0767fd9b091ce9cd..d1185e565a101bc17db476a2d22b813207a26ae1 100644 (file)
--- a/server/sonar-web/src/main/less/issues.less
+++ b/server/sonar-web/src/main/less/issues.less
@@ -309,10 +309,7 @@
 
 .issues-workspace-component-viewer {
   padding: 1px 10px;
-
-  &.full-height {
-    min-height: 100vh;
-  }
+  min-height: 100vh;
 
   .code-issue-modern {
     margin: 5px 0;