]> source.dussan.org Git - vaadin-framework.git/commitdiff
some refactoring
authorMatti Tahvonen <matti.tahvonen@itmill.com>
Thu, 18 Feb 2010 15:00:50 +0000 (15:00 +0000)
committerMatti Tahvonen <matti.tahvonen@itmill.com>
Thu, 18 Feb 2010 15:00:50 +0000 (15:00 +0000)
svn changeset:11384/svn branch:6.3_dd

40 files changed:
src/com/vaadin/event/ComponentTransferable.java
src/com/vaadin/event/DataBoundTransferable.java
src/com/vaadin/event/dd/DragAndDropEvent.java
src/com/vaadin/event/dd/DragEvent.java [deleted file]
src/com/vaadin/event/dd/DragSource.java
src/com/vaadin/event/dd/DropEvent.java [deleted file]
src/com/vaadin/event/dd/DropHandler.java
src/com/vaadin/event/dd/DropTarget.java
src/com/vaadin/event/dd/DropTargetDetails.java [new file with mode: 0644]
src/com/vaadin/event/dd/DropTargetDetailsImpl.java [new file with mode: 0644]
src/com/vaadin/event/dd/TargetDetails.java [deleted file]
src/com/vaadin/event/dd/TargetDetailsImpl.java [deleted file]
src/com/vaadin/terminal/gwt/client/ui/dd/VAcceptAll.java
src/com/vaadin/terminal/gwt/client/ui/dd/VAcceptCriterion.java
src/com/vaadin/terminal/gwt/client/ui/dd/VAnd.java
src/com/vaadin/terminal/gwt/client/ui/dd/VComponentFilter.java
src/com/vaadin/terminal/gwt/client/ui/dd/VContainsDataFlawor.java
src/com/vaadin/terminal/gwt/client/ui/dd/VDataBound.java
src/com/vaadin/terminal/gwt/client/ui/dd/VDropDetailEquals.java
src/com/vaadin/terminal/gwt/client/ui/dd/VIdentifierIs.java
src/com/vaadin/terminal/gwt/client/ui/dd/VIsOverId.java
src/com/vaadin/terminal/gwt/client/ui/dd/VLazyInitItemIdentifiers.java
src/com/vaadin/terminal/gwt/client/ui/dd/VNot.java
src/com/vaadin/terminal/gwt/client/ui/dd/VOr.java
src/com/vaadin/terminal/gwt/client/ui/dd/VOverTreeNode.java
src/com/vaadin/terminal/gwt/client/ui/dd/VServerAccept.java
src/com/vaadin/terminal/gwt/client/ui/dd/VSourceIsSameAsTarget.java
src/com/vaadin/terminal/gwt/server/DragAndDropService.java
src/com/vaadin/ui/AbstractSelect.java
src/com/vaadin/ui/DragAndDropWrapper.java
src/com/vaadin/ui/DragDropPane.java
src/com/vaadin/ui/Table.java
src/com/vaadin/ui/Tree.java
tests/src/com/vaadin/tests/dd/CustomDDImplementation.java
tests/src/com/vaadin/tests/dd/DDTest1.java
tests/src/com/vaadin/tests/dd/DDTest2.java
tests/src/com/vaadin/tests/dd/DDTest4.java
tests/src/com/vaadin/tests/dd/DDTest5.java
tests/src/com/vaadin/tests/dd/HorizontalLayoutSortableWithWrappers.java
tests/src/com/vaadin/tests/dd/HorizontalSortableCssLayoutWithWrappers.java

index c1b713690ac249ef1d6de50d5820eb2da0e7dbe2..2b7ac6696e0e6e85e53904ee209a452936f2827a 100644 (file)
@@ -1,12 +1,35 @@
 package com.vaadin.event;
 
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+
 import com.vaadin.ui.Component;
 
-public interface ComponentTransferable extends Transferable {
+public class ComponentTransferable implements Transferable {
+    private Map<String, Object> rawVariables = new HashMap<String, Object>();
+    private Component sourceComponent;
+
+    public ComponentTransferable(Component sourceComponent,
+            Map<String, Object> rawVariables) {
+        this.sourceComponent = sourceComponent;
+        this.rawVariables = rawVariables;
+    }
+
+    public Component getSourceComponent() {
+        return sourceComponent;
+    }
+
+    public Object getData(String dataFlawor) {
+        return rawVariables.get(dataFlawor);
+    }
+
+    public void setData(String dataFlawor, Object value) {
+        rawVariables.put(dataFlawor, value);
+    }
 
-    /**
-     * @return the component that started the drag operation
-     */
-    public Component getSourceComponent();
+    public Collection<String> getDataFlawors() {
+        return rawVariables.keySet();
+    }
 
 }
index fd259f04819f3e2276ff0e9e7f97b5926ae0cf4b..ddb3cb17ce20b8dbed261ad418295aaf54ae7445 100644 (file)
@@ -1,9 +1,18 @@
 package com.vaadin.event;
 
-public interface DataBoundTransferable extends ComponentTransferable {
+import java.util.Map;
 
-    public Object getItemId();
+import com.vaadin.ui.Component;
 
-    public Object getPropertyId();
+public abstract class DataBoundTransferable extends ComponentTransferable {
+
+    public DataBoundTransferable(Component sourceComponent,
+            Map<String, Object> rawVariables) {
+        super(sourceComponent, rawVariables);
+    }
+
+    public abstract Object getItemId();
+
+    public abstract Object getPropertyId();
 
 }
index 126edb15d8413a6e9f0ec0cb6a4306ca97438c66..4adc4e757e9010a2a5f3874ac43e7ce627c534e6 100644 (file)
@@ -4,12 +4,12 @@ import java.io.Serializable;
 
 import com.vaadin.event.Transferable;
 
-public abstract class DragAndDropEvent implements Serializable {
+public class DragAndDropEvent implements Serializable {
     private static final long serialVersionUID = -2232591107911385564L;
     private Transferable transferable;
-    private TargetDetails dropDetails;
+    private DropTargetDetails dropDetails;
 
-    public DragAndDropEvent(Transferable tr, TargetDetails details) {
+    public DragAndDropEvent(Transferable tr, DropTargetDetails details) {
         transferable = tr;
         dropDetails = details;
     }
@@ -18,7 +18,7 @@ public abstract class DragAndDropEvent implements Serializable {
         return transferable;
     }
 
-    public TargetDetails getDropTargetData() {
+    public DropTargetDetails getDropTargetData() {
         return dropDetails;
     }
 }
diff --git a/src/com/vaadin/event/dd/DragEvent.java b/src/com/vaadin/event/dd/DragEvent.java
deleted file mode 100644 (file)
index 951f850..0000000
+++ /dev/null
@@ -1,34 +0,0 @@
-package com.vaadin.event.dd;
-
-import java.util.HashMap;
-import java.util.Map;
-
-import com.vaadin.event.Transferable;
-
-public class DragEvent extends DragAndDropEvent {
-
-    private HashMap<String, Object> responseData;
-
-    public DragEvent(Transferable tr, TargetDetails details) {
-        super(tr, details);
-    }
-
-    private static final long serialVersionUID = 7105802828455781246L;
-
-    public void setResponseData(String key, Object value) {
-        if (responseData != null) {
-            responseData = new HashMap<String, Object>();
-        }
-        responseData.put(key, value);
-    }
-
-    /**
-     * non-api, used by terminal
-     * 
-     * @return
-     */
-    public Map<String, Object> getResponseData() {
-        return responseData;
-    }
-
-}
index 3b69f1b028e830b263241d241c7afead985907c9..73f8c09a410592a92c962825b8cc3755fc3a62d6 100644 (file)
@@ -18,14 +18,9 @@ public interface DragSource extends Serializable {
      * 
      * <p>
      * 
-     * @param transferable
-     *            the Transferable object if one has been created for this drag
-     *            and drop operation, null if Transferable is not yet
-     *            instantiated
      * @param rawVariables
-     * @return
+     * @return the drag source related transferable
      */
-    public Transferable getTransferable(Transferable transferable,
-            Map<String, Object> rawVariables);
+    public Transferable getTransferable(Map<String, Object> rawVariables);
 
 }
\ No newline at end of file
diff --git a/src/com/vaadin/event/dd/DropEvent.java b/src/com/vaadin/event/dd/DropEvent.java
deleted file mode 100644 (file)
index 546da31..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-package com.vaadin.event.dd;
-
-import com.vaadin.event.Transferable;
-
-public class DropEvent extends DragAndDropEvent {
-
-    public DropEvent(Transferable tr, TargetDetails details) {
-        super(tr, details);
-    }
-}
index b5ebbc0fa16e459fd703d38acf5849bc5092fefd..4bdc435b9e64a0c6c2bff274a99d99cfc9c9a4d7 100644 (file)
@@ -7,7 +7,7 @@ import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 
 public interface DropHandler extends Serializable {
 
-    public void drop(DropEvent dropEvent);
+    public void drop(DragAndDropEvent dropEvent);
 
     /**
      * Returns the {@link AcceptCriterion} used to evaluate whether the
index 9b24d7d2f56bcb3f38ce47997050efbfb057982e..407bb2395894632a1a1f58f5da56f305fab59c4e 100644 (file)
@@ -18,7 +18,7 @@ public interface DropTarget extends Component {
      * Called before a drop operation to translate the drop data provided by the
      * client widget. Should return a DropData implementation with the new
      * values. If null is returned the terminal implementation will
-     * automatically create a {@link TargetDetails} with all the client
+     * automatically create a {@link DropTargetDetails} with all the client
      * variables.
      * <p>
      * If this method returns null the data from client side will be passed
@@ -28,7 +28,7 @@ public interface DropTarget extends Component {
      *            Parameters passed from the client side widget.
      * @return A DropData object with the translated data or null.
      */
-    public TargetDetails translateDragDropDetails(
+    public DropTargetDetails translateDragDropDetails(
             Map<String, Object> clientVariables);
 
 }
\ No newline at end of file
diff --git a/src/com/vaadin/event/dd/DropTargetDetails.java b/src/com/vaadin/event/dd/DropTargetDetails.java
new file mode 100644 (file)
index 0000000..6b8f124
--- /dev/null
@@ -0,0 +1,13 @@
+package com.vaadin.event.dd;
+
+import java.io.Serializable;
+
+public interface DropTargetDetails extends Serializable {
+
+    public Object getData(String key);
+
+    public Object setData(String key, Object value);
+
+    public DropTarget getTarget();
+
+}
diff --git a/src/com/vaadin/event/dd/DropTargetDetailsImpl.java b/src/com/vaadin/event/dd/DropTargetDetailsImpl.java
new file mode 100644 (file)
index 0000000..3046f03
--- /dev/null
@@ -0,0 +1,28 @@
+package com.vaadin.event.dd;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.vaadin.terminal.gwt.server.DragAndDropService;
+
+public class DropTargetDetailsImpl implements DropTargetDetails {
+
+    private HashMap<String, Object> data = new HashMap<String, Object>();
+
+    public DropTargetDetailsImpl(Map<String, Object> rawDropData) {
+        data.putAll(rawDropData);
+    }
+
+    public Object getData(String key) {
+        return data.get(key);
+    }
+
+    public Object setData(String key, Object value) {
+        return data.put(key, value);
+    }
+
+    public DropTarget getTarget() {
+        return (DropTarget) data.get(DragAndDropService.DROPTARGET_KEY);
+    }
+
+}
\ No newline at end of file
diff --git a/src/com/vaadin/event/dd/TargetDetails.java b/src/com/vaadin/event/dd/TargetDetails.java
deleted file mode 100644 (file)
index 7711160..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-package com.vaadin.event.dd;
-
-import java.io.Serializable;
-
-public interface TargetDetails extends Serializable {
-
-    public Object getData(String key);
-
-    public Object setData(String key, Object value);
-
-    public DropTarget getTarget();
-
-}
diff --git a/src/com/vaadin/event/dd/TargetDetailsImpl.java b/src/com/vaadin/event/dd/TargetDetailsImpl.java
deleted file mode 100644 (file)
index ae7c7d0..0000000
+++ /dev/null
@@ -1,28 +0,0 @@
-package com.vaadin.event.dd;
-
-import java.util.HashMap;
-import java.util.Map;
-
-import com.vaadin.terminal.gwt.server.DragAndDropService;
-
-public class TargetDetailsImpl implements TargetDetails {
-
-    private HashMap<String, Object> data = new HashMap<String, Object>();
-
-    public TargetDetailsImpl(Map<String, Object> rawDropData) {
-        data.putAll(rawDropData);
-    }
-
-    public Object getData(String key) {
-        return data.get(key);
-    }
-
-    public Object setData(String key, Object value) {
-        return data.put(key, value);
-    }
-
-    public DropTarget getTarget() {
-        return (DropTarget) data.get(DragAndDropService.DROPTARGET_KEY);
-    }
-
-}
\ No newline at end of file
index 78a58cbc4c014d38ce57350e62b61e28dee22430..6bca3f97f92ab227bca34577cad4a02fac6dbab5 100644 (file)
@@ -5,13 +5,10 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VAcceptAll implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
-        callback.accepted(drag);
-    }
+final public class VAcceptAll extends VAcceptCriterion {
 
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return true;
     }
 }
\ No newline at end of file
index 0a759b383a7261cee8ebf074f52505be59229ebf..032045f84752a553b20c4208452a83c581cae007 100644 (file)
@@ -2,7 +2,7 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-public interface VAcceptCriterion {
+public abstract class VAcceptCriterion {
 
     /**
      * Checks if current drag event has valid drop target and target accepts the
@@ -12,9 +12,30 @@ public interface VAcceptCriterion {
      * @param configuration
      * @param callback
      */
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback);
+    public void accept(final VDragEvent drag, UIDL configuration,
+            final VAcceptCallback callback) {
+        if (needsServerSideCheck(drag, configuration)) {
+            VDragEventServerCallback acceptCallback = new VDragEventServerCallback() {
+                public void handleResponse(boolean accepted, UIDL response) {
+                    if (accepted) {
+                        callback.accepted(drag);
+                    }
+                }
+            };
+            VDragAndDropManager.get().visitServer(acceptCallback);
+        } else {
+            boolean validates = validates(drag, configuration);
+            if (validates) {
+                callback.accepted(drag);
+            }
+        }
 
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL);
+    }
+
+    public abstract boolean validates(VDragEvent drag, UIDL configuration);
+
+    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
+        return false;
+    }
 
 }
index d12632349a6c936f769af37d41baba58993985ae..5681d5144df5f9c6a8961d7cee016792d273bf86 100644 (file)
@@ -6,21 +6,31 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 import com.vaadin.terminal.gwt.client.ApplicationConnection;
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VAnd implements VAcceptCriterion {
+/**
+ * TODO implementation could now be simplified/optimized
+ * 
+ */
+final public class VAnd extends VAcceptCriterion {
     private boolean b1;
     private boolean b2;
     private VAcceptCriterion crit1;
     private VAcceptCriterion crit2;
 
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+    private VAcceptCriterion getCriteria(VDragEvent drag, UIDL configuration,
+            int i) {
+        UIDL childUIDL = configuration.getChildUIDL(i);
+        return VAcceptCriteria.get(childUIDL.getStringAttribute("name"));
+    }
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         if (crit1 == null) {
             crit1 = getCriteria(drag, configuration, 0);
             crit2 = getCriteria(drag, configuration, 1);
             if (crit1 == null || crit2 == null) {
                 ApplicationConnection.getConsole().log(
                         "And criteria didn't found a chidl criteria");
-                return;
+                return false;
             }
         }
 
@@ -40,18 +50,8 @@ final public class VAnd implements VAcceptCriterion {
 
         crit1.accept(drag, configuration.getChildUIDL(0), accept1cb);
         crit2.accept(drag, configuration.getChildUIDL(1), accept2cb);
-        if (b1 && b2) {
-            callback.accepted(drag);
-        }
-    }
 
-    private VAcceptCriterion getCriteria(VDragEvent drag, UIDL configuration,
-            int i) {
-        UIDL childUIDL = configuration.getChildUIDL(i);
-        return VAcceptCriteria.get(childUIDL.getStringAttribute("name"));
+        return b1 && b2;
     }
 
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false; // TODO enforce on server side
-    }
 }
\ No newline at end of file
index 50abae6d4b11b4c7e2b03435197b01bf005dd5e0..6c3216bbc35b0e04cc4a37f23cb390dbdd0a4d23 100644 (file)
@@ -6,9 +6,10 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 import com.vaadin.terminal.gwt.client.Paintable;
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VComponentFilter implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VComponentFilter extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         try {
             Paintable component = drag.getTransferable().getDragSource();
             int c = configuration.getIntAttribute("c");
@@ -19,15 +20,11 @@ final public class VComponentFilter implements VAcceptCriterion {
                         .getCurrentDropHandler().getApplicationConnection()
                         .getPaintable(requiredPid);
                 if (paintable == component) {
-                    callback.accepted(drag);
+                    return true;
                 }
             }
         } catch (Exception e) {
         }
-        return;
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return false;
     }
 }
\ No newline at end of file
index 7829a3202437022f093d9e77fbbf413d064abcd5..0e16515bc7ccd36fc9b08ffe4508502b997056c7 100644 (file)
@@ -5,18 +5,11 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VContainsDataFlawor implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
-        String name = configuration.getStringAttribute("p");
-        boolean contains = drag.getTransferable().getDataFlawors().contains(
-                name);
-        if (contains) {
-            callback.accepted(drag);
-        }
-    }
+final public class VContainsDataFlawor extends VAcceptCriterion {
 
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        String name = configuration.getStringAttribute("p");
+        return drag.getTransferable().getDataFlawors().contains(name);
     }
 }
\ No newline at end of file
index 8b4e7fbc54b4bb3067a6c9504eb87eb6205250a3..8384c156da19eb12a15a51434adab4a58ab53267 100644 (file)
@@ -5,15 +5,10 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VDataBound implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
-        if (drag.getTransferable().getData("itemId") != null) {
-            callback.accepted(drag);
-        }
-    }
+final public class VDataBound extends VAcceptCriterion {
 
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return drag.getTransferable().getData("itemId") != null;
     }
 }
\ No newline at end of file
index fab84f17b81e0c84c195606f12903f17acddb5eb..1b0dd3d2ef76cbca37d5da18afc6b849d1318983 100644 (file)
@@ -5,18 +5,13 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VDropDetailEquals implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VDropDetailEquals extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         String name = configuration.getStringAttribute("p");
         String value = configuration.getStringAttribute("v");
         Object object = drag.getDropDetails().get(name);
-        if (value.equals(object)) {
-            callback.accepted(drag);
-        }
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+        return value.equals(object);
     }
 }
\ No newline at end of file
index f353e8db9de6adfdc2adbe41a4b1b736d57b0d83..c9b8a1d018a1c0351254f31390ea299604b2423b 100644 (file)
@@ -7,22 +7,17 @@ import java.util.Set;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VIdentifierIs implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VIdentifierIs extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         try {
             Object data = drag.getTransferable().getData("itemId");
             Set<String> stringArrayVariableAsSet = configuration
                     .getStringArrayVariableAsSet("keys");
-            if (stringArrayVariableAsSet.contains(data)) {
-                callback.accepted(drag);
-            }
+            return stringArrayVariableAsSet.contains(data);
         } catch (Exception e) {
         }
-        return;
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return false;
     }
 }
\ No newline at end of file
index e1a5df8d181e292731205461b6fc57665c2c951e..defdb559a4e91f4bb5ea8595dac6df1334b62438 100644 (file)
@@ -7,22 +7,17 @@ import java.util.Set;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VIsOverId implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VIsOverId extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         try {
             Set<String> stringArrayVariableAsSet = configuration
                     .getStringArrayVariableAsSet("keys");
-            if (stringArrayVariableAsSet.contains(drag.getDropDetails().get(
-                    "itemIdOver"))) {
-                callback.accepted(drag);
-            }
+            return stringArrayVariableAsSet.contains(drag.getDropDetails().get(
+                    "itemIdOver"));
         } catch (Exception e) {
         }
-        return;
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return false;
     }
 }
\ No newline at end of file
index 42b5a23801c3ca7a6f0d84a20027661e7bfda9c8..5a49d9dbe003db686aeca050e9129f43d3406b14 100644 (file)
@@ -12,11 +12,12 @@ import com.vaadin.terminal.gwt.client.UIDL;
  * @deprecated example class testing custom behavior
  */
 @Deprecated
-final public class VLazyInitItemIdentifiers implements VAcceptCriterion {
+final public class VLazyInitItemIdentifiers extends VAcceptCriterion {
     private boolean loaded = false;
     private HashSet<String> hashSet;
     private VDragEvent lastDragEvent;
 
+    @Override
     public void accept(final VDragEvent drag, UIDL configuration,
             final VAcceptCallback callback) {
         if (lastDragEvent == null || lastDragEvent != drag) {
@@ -51,7 +52,13 @@ final public class VLazyInitItemIdentifiers implements VAcceptCriterion {
 
     }
 
+    @Override
     public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return loaded;
     }
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return false; // not used is this implementation
+    }
 }
\ No newline at end of file
index fe6fa8b6fbb3bf2758cd07e516117fe1aba75442..283813702538a7f6ffe9756ddb152e28d614db67 100644 (file)
@@ -6,10 +6,15 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 import com.vaadin.terminal.gwt.client.ApplicationConnection;
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VNot implements VAcceptCriterion {
+/**
+ * TODO implementation could now be simplified/optimized
+ * 
+ */
+final public class VNot extends VAcceptCriterion {
     private boolean b1;
     private VAcceptCriterion crit1;
 
+    @Override
     public void accept(VDragEvent drag, UIDL configuration,
             VAcceptCallback callback) {
         if (crit1 == null) {
@@ -41,7 +46,13 @@ final public class VNot implements VAcceptCriterion {
         return VAcceptCriteria.get(childUIDL.getStringAttribute("name"));
     }
 
+    @Override
     public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return false; // TODO enforce on server side
     }
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return false; // not used
+    }
 }
\ No newline at end of file
index 114794f509f30b3f3b6f69b728c958f85bdf1086..1c001ce9a63cee7491d11c76a5efa5be8c519ad6 100644 (file)
@@ -6,12 +6,17 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 import com.vaadin.terminal.gwt.client.ApplicationConnection;
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VOr implements VAcceptCriterion {
+/**
+ * TODO implementation could now be simplified/optimized
+ * 
+ */
+final public class VOr extends VAcceptCriterion {
     private boolean b1;
     private boolean b2;
     private VAcceptCriterion crit1;
     private VAcceptCriterion crit2;
 
+    @Override
     public void accept(VDragEvent drag, UIDL configuration,
             VAcceptCallback callback) {
         if (crit1 == null) {
@@ -51,8 +56,14 @@ final public class VOr implements VAcceptCriterion {
         return VAcceptCriteria.get(childUIDL.getStringAttribute("name"));
     }
 
+    @Override
     public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return false; // TODO enforce on server side
     }
 
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return false; // not used here
+    }
+
 }
\ No newline at end of file
index db59d526aebc72b68b6dc10451737a2d30edf775..f5fd4dec7f8eefa2f26a7258cef2c5fe911b7fff 100644 (file)
@@ -5,19 +5,12 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VOverTreeNode implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VOverTreeNode extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         Boolean containsKey = (Boolean) drag.getDropDetails().get(
                 "itemIdOverIsNode");
-        if (containsKey != null && containsKey.booleanValue()) {
-            callback.accepted(drag);
-            return;
-        }
-        return;
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+        return containsKey != null && containsKey.booleanValue();
     }
 }
\ No newline at end of file
index b1cea05d54aacb9954cd32bc4608f17458b62630..68eb09c422228eaaaa2a28c4c39c1b49fd9d3fc2 100644 (file)
@@ -5,7 +5,8 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VServerAccept implements VAcceptCriterion {
+final public class VServerAccept extends VAcceptCriterion {
+    @Override
     public void accept(final VDragEvent drag, UIDL configuration,
             final VAcceptCallback callback) {
 
@@ -19,7 +20,13 @@ final public class VServerAccept implements VAcceptCriterion {
         VDragAndDropManager.get().visitServer(acceptCallback);
     }
 
+    @Override
     public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
         return true;
     }
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
+        return false; // not used
+    }
 }
\ No newline at end of file
index 5a7608366ad8707723553ab5269337a687fd370b..8e5bc54126d4a473cae6576105fecc899f974044 100644 (file)
@@ -6,19 +6,14 @@ package com.vaadin.terminal.gwt.client.ui.dd;
 import com.vaadin.terminal.gwt.client.Paintable;
 import com.vaadin.terminal.gwt.client.UIDL;
 
-final public class VSourceIsSameAsTarget implements VAcceptCriterion {
-    public void accept(VDragEvent drag, UIDL configuration,
-            VAcceptCallback callback) {
+final public class VSourceIsSameAsTarget extends VAcceptCriterion {
+
+    @Override
+    public boolean validates(VDragEvent drag, UIDL configuration) {
         Paintable dragSource = drag.getTransferable().getDragSource();
         Paintable paintable = VDragAndDropManager.get().getCurrentDropHandler()
                 .getPaintable();
 
-        if (paintable == dragSource) {
-            callback.accepted(drag);
-        }
-    }
-
-    public boolean needsServerSideCheck(VDragEvent drag, UIDL criterioUIDL) {
-        return false;
+        return paintable == dragSource;
     }
 }
\ No newline at end of file
index 5a318f071c1edbee9c4e02670b297c8d918c633d..8255aadbbbee0cfcbe40eac52fd302bb5bcac97f 100644 (file)
@@ -7,13 +7,12 @@ import java.util.Map;
 
 import com.vaadin.event.ComponentTransferable;
 import com.vaadin.event.Transferable;
-import com.vaadin.event.dd.DragEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DragSource;
-import com.vaadin.event.dd.DropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
-import com.vaadin.event.dd.TargetDetailsImpl;
+import com.vaadin.event.dd.DropTargetDetails;
+import com.vaadin.event.dd.DropTargetDetailsImpl;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.terminal.PaintException;
 import com.vaadin.terminal.VariableOwner;
@@ -30,11 +29,9 @@ public class DragAndDropService implements VariableOwner {
 
     private int currentEventId;
 
-    private Transferable transferable;
-
     private boolean lastVisitAccepted = false;
 
-    private DragEvent dragEvent;
+    private DragAndDropEvent dragEvent;
 
     private final AbstractCommunicationManager manager;
 
@@ -95,8 +92,10 @@ public class DragAndDropService implements VariableOwner {
          * source for Transferable, drop target for DragDropDetails).
          */
         Transferable transferable = constructTransferable(dropTarget, variables);
-        TargetDetails dropData = constructDragDropDetails(dropTarget, variables);
-        DropEvent dropEvent = new DropEvent(transferable, dropData);
+        DropTargetDetails dropData = constructDragDropDetails(dropTarget,
+                variables);
+        DragAndDropEvent dropEvent = new DragAndDropEvent(transferable,
+                dropData);
         if (dropHandler.getAcceptCriterion().accepts(dropEvent)) {
             dropHandler.drop(dropEvent);
         }
@@ -120,10 +119,10 @@ public class DragAndDropService implements VariableOwner {
          * source for Transferable, current target for DragDropDetails).
          */
         Transferable transferable = constructTransferable(dropTarget, variables);
-        TargetDetails dragDropDetails = constructDragDropDetails(dropTarget,
-                variables);
+        DropTargetDetails dragDropDetails = constructDragDropDetails(
+                dropTarget, variables);
 
-        dragEvent = new DragEvent(transferable, dragDropDetails);
+        dragEvent = new DragAndDropEvent(transferable, dragDropDetails);
 
         lastVisitAccepted = acceptCriterion.accepts(dragEvent);
     }
@@ -138,17 +137,17 @@ public class DragAndDropService implements VariableOwner {
      * @return
      */
     @SuppressWarnings("unchecked")
-    private TargetDetails constructDragDropDetails(DropTarget dropTarget,
+    private DropTargetDetails constructDragDropDetails(DropTarget dropTarget,
             Map<String, Object> variables) {
         Map<String, Object> rawDragDropDetails = (Map<String, Object>) variables
                 .get("evt");
 
-        TargetDetails dropData = dropTarget
+        DropTargetDetails dropData = dropTarget
                 .translateDragDropDetails(rawDragDropDetails);
 
         if (dropData == null) {
             // Create a default DragDropDetails with all the raw variables
-            dropData = new TargetDetailsImpl(rawDragDropDetails);
+            dropData = new DropTargetDetailsImpl(rawDragDropDetails);
         }
 
         dropData.setData(DROPTARGET_KEY, dropTarget);
@@ -169,9 +168,6 @@ public class DragAndDropService implements VariableOwner {
     private Transferable constructTransferable(DropTarget dropHandlerOwner,
             Map<String, Object> variables) {
         int eventId = (Integer) variables.get("eventId");
-        if (currentEventId != eventId) {
-            transferable = null;
-        }
         currentEventId = eventId;
 
         final Component sourceComponent = (Component) variables
@@ -179,33 +175,15 @@ public class DragAndDropService implements VariableOwner {
 
         variables = (Map<String, Object>) variables.get("tra");
 
+        Transferable transferable = null;
         if (sourceComponent != null && sourceComponent instanceof DragSource) {
-            transferable = ((DragSource) sourceComponent).getTransferable(
-                    transferable, variables);
+            transferable = ((DragSource) sourceComponent)
+                    .getTransferable(variables);
         } else {
             if (transferable == null) {
                 if (sourceComponent != null) {
-                    transferable = new ComponentTransferable() {
-
-                        private Map<String, Object> td = new HashMap<String, Object>();
-
-                        public Component getSourceComponent() {
-                            return sourceComponent;
-                        }
-
-                        public Object getData(String dataFlawor) {
-                            return td.get(dataFlawor);
-                        }
-
-                        public void setData(String dataFlawor, Object value) {
-                            td.put(dataFlawor, value);
-                        }
-
-                        public Collection<String> getDataFlawors() {
-                            return td.keySet();
-                        }
-
-                    };
+                    transferable = new ComponentTransferable(sourceComponent,
+                            variables);
                 } else {
                     transferable = new Transferable() {
                         private Map<String, Object> td = new HashMap<String, Object>();
@@ -227,13 +205,6 @@ public class DragAndDropService implements VariableOwner {
             }
         }
 
-        /*
-         * Add remaining (non-handled) variables to transferable as is
-         */
-        for (String key : variables.keySet()) {
-            transferable.setData(key, variables.get(key));
-        }
-
         return transferable;
     }
 
index cdaf2715e28e52e7f033c8cbe72744bfbe20cac0..a553a9ad90d056b4607c632162e976bb52d36d82 100644 (file)
@@ -22,7 +22,7 @@ import com.vaadin.data.util.IndexedContainer;
 import com.vaadin.event.DataBoundTransferable;
 import com.vaadin.event.Transferable;
 import com.vaadin.event.dd.DragAndDropEvent;
-import com.vaadin.event.dd.TargetDetailsImpl;
+import com.vaadin.event.dd.DropTargetDetailsImpl;
 import com.vaadin.event.dd.acceptCriteria.ClientCriterion;
 import com.vaadin.event.dd.acceptCriteria.ClientSideCriterion;
 import com.vaadin.terminal.KeyMapper;
@@ -1756,7 +1756,7 @@ public abstract class AbstractSelect extends AbstractField implements
 
     }
 
-    public class AbstractSelectDropDetails extends TargetDetailsImpl {
+    public class AbstractSelectDropDetails extends DropTargetDetailsImpl {
 
         private Object idOver;
 
index 827aa354b0698e41417a71d42f9e22fc52fa8926..e2fb2942e7700927ea9b5695e5f702e3ed821c47 100644 (file)
@@ -1,6 +1,5 @@
 package com.vaadin.ui;
 
-import java.util.Collection;
 import java.util.Map;
 
 import com.vaadin.event.ComponentTransferable;
@@ -8,7 +7,7 @@ import com.vaadin.event.Transferable;
 import com.vaadin.event.dd.DragSource;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
+import com.vaadin.event.dd.DropTargetDetails;
 import com.vaadin.terminal.PaintException;
 import com.vaadin.terminal.PaintTarget;
 import com.vaadin.terminal.gwt.client.ui.VDragAndDropWrapper;
@@ -17,28 +16,11 @@ import com.vaadin.terminal.gwt.client.ui.VDragAndDropWrapper;
 public class DragAndDropWrapper extends CustomComponent implements DropTarget,
         DragSource {
 
-    public class DDWrapperTransferable implements ComponentTransferable {
-        private final Map<String, Object> rawVariables;
+    public class DDWrapperTransferable extends ComponentTransferable {
 
-        private DDWrapperTransferable(Map<String, Object> rawVariables) {
-            this.rawVariables = rawVariables;
-        }
-
-        public void setData(String dataFlawor, Object value) {
-            // TODO Auto-generated method stub
-
-        }
-
-        public Collection<String> getDataFlawors() {
-            return rawVariables.keySet();
-        }
-
-        public Object getData(String dataFlawor) {
-            return rawVariables.get(dataFlawor);
-        }
-
-        public Component getSourceComponent() {
-            return DragAndDropWrapper.this;
+        public DDWrapperTransferable(Component sourceComponent,
+                Map<String, Object> rawVariables) {
+            super(sourceComponent, rawVariables);
         }
 
         /**
@@ -48,7 +30,7 @@ public class DragAndDropWrapper extends CustomComponent implements DropTarget,
          * @return
          */
         public Component getDraggedComponent() {
-            Component object = (Component) rawVariables.get("component");
+            Component object = (Component) getData("component");
             return object;
         }
     }
@@ -87,15 +69,14 @@ public class DragAndDropWrapper extends CustomComponent implements DropTarget,
         requestRepaint();
     }
 
-    public TargetDetails translateDragDropDetails(
+    public DropTargetDetails translateDragDropDetails(
             Map<String, Object> clientVariables) {
         // TODO Auto-generated method stub
         return null;
     }
 
-    public Transferable getTransferable(Transferable transferable,
-            final Map<String, Object> rawVariables) {
-        return new DDWrapperTransferable(rawVariables);
+    public Transferable getTransferable(final Map<String, Object> rawVariables) {
+        return new DDWrapperTransferable(this, rawVariables);
     }
 
     public void setDragStartMode(DragStartMode dragStartMode) {
index 923c5945519ab062b3f0a15e12a47011231e5824..3c8a9c2f80fd50c93f6640edd9cc12071524bcbc 100644 (file)
@@ -5,11 +5,11 @@ import java.util.Map;
 import com.vaadin.event.ComponentTransferable;
 import com.vaadin.event.DataBoundTransferable;
 import com.vaadin.event.Transferable;
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
-import com.vaadin.event.dd.TargetDetailsImpl;
+import com.vaadin.event.dd.DropTargetDetails;
+import com.vaadin.event.dd.DropTargetDetailsImpl;
 import com.vaadin.event.dd.acceptCriteria.AcceptAll;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.terminal.PaintException;
@@ -70,7 +70,7 @@ public class DragDropPane extends AbsoluteLayout implements DropTarget {
     }
 
     public static class ImportPrettyMuchAnything implements DropHandler {
-        public void drop(DropEvent event) {
+        public void drop(DragAndDropEvent event) {
             DragDropPane pane = (DragDropPane) event.getDropTargetData()
                     .getTarget();
 
@@ -163,7 +163,7 @@ public class DragDropPane extends AbsoluteLayout implements DropTarget {
         }
     }
 
-    class DragEventDetails extends TargetDetailsImpl {
+    class DragEventDetails extends DropTargetDetailsImpl {
 
         public DragEventDetails(Map<String, Object> rawVariables) {
             super(rawVariables);
@@ -188,7 +188,7 @@ public class DragDropPane extends AbsoluteLayout implements DropTarget {
 
     }
 
-    public TargetDetails translateDragDropDetails(
+    public DropTargetDetails translateDragDropDetails(
             Map<String, Object> clientVariables) {
         return new DragEventDetails(clientVariables);
     }
index f6e01025d3757bc3eabd8d1da57b3f7704b096c5..42e9d95b49e9e90deebb09dbeb5091b4c6780cfb 100644 (file)
@@ -25,7 +25,6 @@ import com.vaadin.data.util.IndexedContainer;
 import com.vaadin.event.Action;
 import com.vaadin.event.DataBoundTransferable;
 import com.vaadin.event.ItemClickEvent;
-import com.vaadin.event.Transferable;
 import com.vaadin.event.Action.Handler;
 import com.vaadin.event.ItemClickEvent.ItemClickListener;
 import com.vaadin.event.ItemClickEvent.ItemClickSource;
@@ -3330,51 +3329,31 @@ public class Table extends AbstractSelect implements Action.Container,
         requestRepaint();
     }
 
-    class TableTransferable implements DataBoundTransferable {
+    class TableTransferable extends DataBoundTransferable {
 
-        private final HashMap<String, Object> data = new HashMap<String, Object>();
+        public TableTransferable(Map<String, Object> rawVariables) {
+            super(Table.this, rawVariables);
+            Object object = rawVariables.get("itemId");
+            if (object != null) {
+                setData("itemId", itemIdMapper.get((String) object));
+            }
+        }
 
+        @Override
         public Object getItemId() {
-            return data.get("itemId");
+            return getData("itemId");
         }
 
+        @Override
         public Object getPropertyId() {
             return getItemCaptionPropertyId();
         }
 
-        public Component getSourceComponent() {
-            return Table.this;
-        }
-
-        public Object getData(String dataFlawor) {
-            return data.get(dataFlawor);
-        }
-
-        public Collection<String> getDataFlawors() {
-            return data.keySet();
-        }
-
-        public void setData(String dataFlawor, Object value) {
-            data.put(dataFlawor, value);
-        }
-
     }
 
-    private void updateTransferable(Map<String, Object> payload, Transferable tr) {
-        Object object = payload.get("itemId");
-        if (object != null) {
-            tr.setData("itemId", itemIdMapper.get((String) object));
-            payload.remove("itemId");
-        }
-    }
-
-    public TableTransferable getTransferable(Transferable transferable,
-            Map<String, Object> rawVariables) {
-        if (transferable == null) {
-            transferable = new TableTransferable();
-        }
-        updateTransferable(rawVariables, transferable);
-        return (TableTransferable) transferable;
+    public TableTransferable getTransferable(Map<String, Object> rawVariables) {
+        TableTransferable transferable = new TableTransferable(rawVariables);
+        return transferable;
     }
 
     public DropHandler getDropHandler() {
index 02b486046f64801a69b3ad04ca27cce332f2650b..850519f9f7f0cb111b2f287b7e6c8fee656e6279 100644 (file)
@@ -118,49 +118,31 @@ public class Tree extends AbstractSelect implements Container.Hierarchical,
 
     private int itemDragModes = DRAG_OUT;
 
-    class TreeTransferable implements DataBoundTransferable {
+    class TreeTransferable extends DataBoundTransferable {
 
-        private final HashMap<String, Object> data = new HashMap<String, Object>();
+        public TreeTransferable(Component sourceComponent,
+                Map<String, Object> rawVariables) {
+            super(sourceComponent, rawVariables);
+        }
 
+        @Override
         public Object getItemId() {
-            return data.get("itemId");
+            return getData("itemId");
         }
 
+        @Override
         public Object getPropertyId() {
             return getItemCaptionPropertyId();
         }
-
-        public Component getSourceComponent() {
-            return Tree.this;
-        }
-
-        public Object getData(String dataFlawor) {
-            if (dataFlawor.equals("Text")) {
-                return getItemCaption(getItemId());
-            }
-            return data.get(dataFlawor);
-        }
-
-        public Collection<String> getDataFlawors() {
-            return data.keySet();
-        }
-
-        public void setData(String dataFlawor, Object value) {
-            data.put(dataFlawor, value);
-        }
     }
 
-    public Transferable getTransferable(Transferable transferable,
-            Map<String, Object> payload) {
-        if (transferable == null) {
-            transferable = new TreeTransferable();
-        }
+    public Transferable getTransferable(Map<String, Object> payload) {
+        TreeTransferable transferable = new TreeTransferable(this, payload);
         // updating drag source variables
         Object object = payload.get("itemId");
         if (object != null) {
             transferable.setData("itemId", itemIdMapper.get((String) object));
         }
-        payload.remove("itemId");
 
         return transferable;
     }
index ca8c9a583a6fac2bc9de80e7d0cfcbb8738afd1c..7f91471b5d85bd3e6f76c1bc12c82ecc6924c062 100644 (file)
@@ -2,10 +2,10 @@ package com.vaadin.tests.dd;
 
 import java.util.Map;
 
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
+import com.vaadin.event.dd.DropTargetDetails;
 import com.vaadin.event.dd.acceptCriteria.AcceptAll;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.ui.AbstractComponent;
@@ -43,7 +43,7 @@ public class CustomDDImplementation extends CustomComponent {
         public DropHandler getDropHandler() {
             return new DropHandler() {
 
-                public void drop(DropEvent event) {
+                public void drop(DragAndDropEvent event) {
                     // Do something with data
                     return;
                 }
@@ -55,7 +55,7 @@ public class CustomDDImplementation extends CustomComponent {
             };
         }
 
-        public TargetDetails translateDragDropDetails(
+        public DropTargetDetails translateDragDropDetails(
                 Map<String, Object> clientVariables) {
             // If component has some special drop details that it needs to
             // translate for server side use, developer must return a
index 18d028601215cb8b93d26da29e74d1ec92777929..d8e387f9621bb77823628802c20ffd49a73ed4b4 100644 (file)
@@ -8,7 +8,6 @@ import com.vaadin.event.ComponentTransferable;
 import com.vaadin.event.DataBoundTransferable;
 import com.vaadin.event.Transferable;
 import com.vaadin.event.dd.DragAndDropEvent;
-import com.vaadin.event.dd.DropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.event.dd.acceptCriteria.IsDatabound;
@@ -65,7 +64,7 @@ public class DDTest1 extends TestBase {
                     Transferable transferable = dragEvent.getTransferable();
                     // System.out.println("Simulating 500ms processing...");
                     // try {
-                    // Thread.sleep(200);
+                    // Thread.sleep(9000);
                     // } catch (InterruptedException e) {
                     // // TODO Auto-generated catch block
                     // e.printStackTrace();
@@ -187,7 +186,7 @@ public class DDTest1 extends TestBase {
 
             }
 
-            public void drop(DropEvent event) {
+            public void drop(DragAndDropEvent event) {
                 AbstractSelectDropDetails details = (AbstractSelectDropDetails) event
                         .getDropTargetData();
                 // TODO set properties, so same sorter could be used in Table
index ff0ed0d4bad3fda7dd8c5c5ef20acb59edfd9c48..e88026ecd209410d712cef0bb58c9c351135f208 100644 (file)
@@ -12,7 +12,6 @@ import com.vaadin.demo.tutorial.addressbook.data.PersonContainer;
 import com.vaadin.event.DataBoundTransferable;
 import com.vaadin.event.Transferable;
 import com.vaadin.event.dd.DragAndDropEvent;
-import com.vaadin.event.dd.DropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.event.dd.acceptCriteria.And;
@@ -82,7 +81,7 @@ public class DDTest2 extends TestBase {
         };
 
         tree3.setDropHandler(new DropHandler() {
-            public void drop(DropEvent dropEvent) {
+            public void drop(DragAndDropEvent dropEvent) {
                 Transferable transferable = dropEvent.getTransferable();
                 String data = (String) transferable.getData("Text");
                 if (data == null) {
@@ -116,7 +115,7 @@ public class DDTest2 extends TestBase {
 
         DropHandler dropHandler = new DropHandler() {
 
-            public void drop(DropEvent event) {
+            public void drop(DragAndDropEvent event) {
                 /*
                  * We know transferrable is from table, so it is of type
                  * DataBindedTransferrable
@@ -172,7 +171,7 @@ public class DDTest2 extends TestBase {
          */
 
         dropHandler = new DropHandler() {
-            public void drop(DropEvent event) {
+            public void drop(DragAndDropEvent event) {
                 AbstractSelectDropDetails details = (AbstractSelectDropDetails) event
                         .getDropTargetData();
                 Transferable transferable = event.getTransferable();
index 84e49cf19225791849903a7b0b9ed6f658f97694..0b5022caaa65bef5c5bc91a00c696fb9b6f4e19e 100644 (file)
@@ -5,7 +5,7 @@ import com.vaadin.data.util.IndexedContainer;
 import com.vaadin.demo.tutorial.addressbook.data.Person;
 import com.vaadin.demo.tutorial.addressbook.data.PersonContainer;
 import com.vaadin.event.DataBoundTransferable;
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.event.dd.acceptCriteria.ComponentFilter;
@@ -56,7 +56,7 @@ public class DDTest4 extends TestBase {
                 return crit;
             }
 
-            public void drop(DropEvent dropEvent) {
+            public void drop(DragAndDropEvent dropEvent) {
                 AbstractSelectDropDetails dropTargetData = (AbstractSelectDropDetails) dropEvent
                         .getDropTargetData();
                 DataBoundTransferable transferable = (DataBoundTransferable) dropEvent
index 7c7ffa3ba327efcb45ff05d956fc22bd720f6098..77b4d0b11afcfb22661ca425e9ea6a625989341e 100644 (file)
@@ -2,7 +2,7 @@ package com.vaadin.tests.dd;
 
 import java.util.Iterator;
 
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
 import com.vaadin.event.dd.acceptCriteria.AcceptAll;
@@ -91,7 +91,7 @@ public class DDTest5 extends TestBase {
                 return AcceptAll.get();
             }
 
-            public void drop(DropEvent dropEvent) {
+            public void drop(DragAndDropEvent dropEvent) {
 
                 /*
                  * TODO wrap componentns in wrappers (so we can build reordering
index 5caeaf443202a66ed81adf961ca81999dd21567a..32f02a29b97d0a12cc8bd1e57aa05b628a505962 100644 (file)
@@ -4,10 +4,10 @@ import java.util.Iterator;
 
 import com.vaadin.event.ComponentTransferable;
 import com.vaadin.event.Transferable;
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
+import com.vaadin.event.dd.DropTargetDetails;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.event.dd.acceptCriteria.And;
 import com.vaadin.event.dd.acceptCriteria.DropDetailEquals;
@@ -59,7 +59,7 @@ public class HorizontalLayoutSortableWithWrappers extends Window {
             return crit;
         }
 
-        public void drop(DropEvent dropEvent) {
+        public void drop(DragAndDropEvent dropEvent) {
             Transferable transferable = dropEvent.getTransferable();
             if (transferable instanceof ComponentTransferable) {
                 ComponentTransferable ct = (ComponentTransferable) transferable;
@@ -69,7 +69,7 @@ public class HorizontalLayoutSortableWithWrappers extends Window {
                     Iterator<Component> componentIterator = layout
                             .getComponentIterator();
                     Component next = componentIterator.next();
-                    TargetDetails dropTargetData = dropEvent
+                    DropTargetDetails dropTargetData = dropEvent
                             .getDropTargetData();
                     DropTarget target = dropTargetData.getTarget();
                     while (next != target) {
index 8673ffb71fc164b4e0a9628895ac8c0168426c17..10c3dd5956f4c8bc5dbbd4e65eb4b1a2b3ea5338 100644 (file)
@@ -4,10 +4,10 @@ import java.util.Iterator;
 
 import com.vaadin.event.ComponentTransferable;
 import com.vaadin.event.Transferable;
-import com.vaadin.event.dd.DropEvent;
+import com.vaadin.event.dd.DragAndDropEvent;
 import com.vaadin.event.dd.DropHandler;
 import com.vaadin.event.dd.DropTarget;
-import com.vaadin.event.dd.TargetDetails;
+import com.vaadin.event.dd.DropTargetDetails;
 import com.vaadin.event.dd.acceptCriteria.AcceptAll;
 import com.vaadin.event.dd.acceptCriteria.AcceptCriterion;
 import com.vaadin.ui.Component;
@@ -52,7 +52,7 @@ public class HorizontalSortableCssLayoutWithWrappers extends Window {
             return AcceptAll.get();
         }
 
-        public void drop(DropEvent dropEvent) {
+        public void drop(DragAndDropEvent dropEvent) {
             Transferable transferable = dropEvent.getTransferable();
             if (transferable instanceof ComponentTransferable) {
                 ComponentTransferable ct = (ComponentTransferable) transferable;
@@ -62,7 +62,7 @@ public class HorizontalSortableCssLayoutWithWrappers extends Window {
                     Iterator<Component> componentIterator = cssLayout
                             .getComponentIterator();
                     Component next = componentIterator.next();
-                    TargetDetails dropTargetData = dropEvent
+                    DropTargetDetails dropTargetData = dropEvent
                             .getDropTargetData();
                     DropTarget target = dropTargetData.getTarget();
                     while (next != target) {