Refactor core/Command/Background

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

diff --git a/core/Command/Background/Ajax.php b/core/Command/Background/Ajax.php
index 5dc94d939d79ee8f484c62b0e23e9f3bbecb72b5..41b80eb531f11d17766064e7f2201a5470626f0a 100644 (file)
--- a/core/Command/Background/Ajax.php
+++ b/core/Command/Background/Ajax.php
@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class Ajax extends Base {
-       protected function getMode() {
+       protected function getMode(): string {
                return 'ajax';
        }
 }

diff --git a/core/Command/Background/Base.php b/core/Command/Background/Base.php
index 5b2da21af75f10181f4f89419a1d93b3dbc45b44..715596f99797223b7d3ae3e187806e59848cafe3 100644 (file)
--- a/core/Command/Background/Base.php
+++ b/core/Command/Background/Base.php
@@ -45,7 +45,7 @@ abstract class Base extends Command {
                parent::__construct();
        }
 
-       protected function configure() {
+       protected function configure(): void {
                $mode = $this->getMode();
                $this
                        ->setName("background:$mode")
@@ -59,6 +59,7 @@ abstract class Base extends Command {
         *
         * @param InputInterface $input
         * @param OutputInterface $output
+        * @return int
         */
        protected function execute(InputInterface $input, OutputInterface $output): int {
                $mode = $this->getMode();

diff --git a/core/Command/Background/Cron.php b/core/Command/Background/Cron.php
index 9dbb4f855e5047cfa8a0a0d449d473bb46858cd5..665919b5ae9ea2402cff4388ad7ffb4cb25f5285 100644 (file)
--- a/core/Command/Background/Cron.php
+++ b/core/Command/Background/Cron.php
@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class Cron extends Base {
-       protected function getMode() {
+       protected function getMode(): string {
                return 'cron';
        }
 }

diff --git a/core/Command/Background/Job.php b/core/Command/Background/Job.php
index fdfb7484b513d3c4680bf20d1a9afae8e400159c..dfa413b958b9c85106c5956a2eab8c7090517b44 100644 (file)
--- a/core/Command/Background/Job.php
+++ b/core/Command/Background/Job.php
@@ -58,6 +58,9 @@ class Job extends Command {
                ;
        }
 
+       /**
+        * @throws \ReflectionException
+        */
        protected function execute(InputInterface $input, OutputInterface $output): int {
                $jobId = (int) $input->getArgument('job-id');
 
@@ -102,7 +105,10 @@ class Job extends Command {
                return 0;
        }
 
-       protected function printJobInfo(int $jobId, IJob $job, OutputInterface$output): void {
+       /**
+        * @throws \ReflectionException
+        */
+       protected function printJobInfo(int $jobId, IJob $job, OutputInterface $output): void {
                $row = $this->jobList->getDetailsById($jobId);
 
                $lastRun = new \DateTime();

diff --git a/core/Command/Background/WebCron.php b/core/Command/Background/WebCron.php
index 7da379b6a533eaf01ace48ff6916076f96dc1abb..59bf4746c4073fac68abcb81ff7b6ce08647ae77 100644 (file)
--- a/core/Command/Background/WebCron.php
+++ b/core/Command/Background/WebCron.php
@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class WebCron extends Base {
-       protected function getMode() {
+       protected function getMode(): string {
                return 'webcron';
        }
 }