SONAR-10577 Fix quality issues

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
index ba1e8c683e3cb5a53312bd80bc7c8504fbcf662f..1b1de06f7d2b048cdd35f218fe50a9f4fba68a26 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
@@ -164,8 +164,8 @@ public class SearchAction implements IssuesWsAction {
         new Change("5.5", "response fields 'reporter' and 'actionPlan' are removed (drop of action plan and manual issue features)"),
         new Change("5.5", "parameters 'reporters', 'actionPlans' and 'planned' are dropped and therefore ignored (drop of action plan and manual issue features)"),
         new Change("5.5", "response field 'debt' is renamed 'effort'"),
-        new Change("7.2", "response 'issue' now indicates if issue has been created by an externally defined rule engine and his name through the optional 'externalRuleEngine' field")
-      ).setResponseExample(getClass().getResource("search-example.json"));
+        new Change("7.2", "response field 'externalRuleEngine' added to issues that have been imported from an external rule engine"))
+      .setResponseExample(getClass().getResource("search-example.json"));
 
     action.addPagingParams(100, MAX_LIMIT);
     action.createParam(Param.FACETS)

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
index fdfcd8ef618aed72d3bd3c9fa394837a462a6819..6c4d5b364877cee915f48460d50133a89afad3ea 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
@@ -200,7 +200,7 @@ public class SearchResponseFormat {
     setNullable(dto.getIssueCloseDate(), issueBuilder::setCloseDate, DateUtils::formatDateTime);
   }
 
-  private String engineNameFrom(RuleKey ruleKey) {
+  private static String engineNameFrom(RuleKey ruleKey) {
     checkState(ruleKey.repository().startsWith(EXTERNAL_RULE_REPO_PREFIX));
     return ruleKey.repository().replace(EXTERNAL_RULE_REPO_PREFIX, "");
   }