]> source.dussan.org Git - vaadin-framework.git/commitdiff
Don't show loading spinner if there are no tabs (#15241)
authorLeif Åstrand <leif@vaadin.com>
Thu, 20 Nov 2014 13:23:44 +0000 (15:23 +0200)
committerVaadin Code Review <review@vaadin.com>
Wed, 13 May 2015 13:24:50 +0000 (13:24 +0000)
Change-Id: Ib2f08fc036d0f9940a865353c43d2433767df1fc

client/src/com/vaadin/client/ui/VTabsheet.java
uitest/src/com/vaadin/tests/components/tabsheet/EmptyTabSheetTest.java

index a02679a0fca039d0c6d9415d9d7756d0a6198e33..8e4f3cb6433e6b1bfc8d8294234447ef11cad831 100644 (file)
@@ -909,7 +909,6 @@ public class VTabsheet extends VTabsheetBase implements Focusable, SubPartAware
 
         deco = DOM.createDiv();
 
-        addStyleDependentName("loading"); // Indicate initial progress
         tb.setStyleName(CLASSNAME + "-tabs");
         DOM.setElementProperty(contentNode, "className", CLASSNAME + "-content");
         DOM.setElementProperty(deco, "className", CLASSNAME + "-deco");
index cebb00c11bcbc5084f828608fdd526131e3b72ce..6d0b78debdb5b0b4aa26a26f4374a5fe1abb1c8a 100644 (file)
  */
 package com.vaadin.tests.components.tabsheet;
 
+import org.junit.Assert;
 import org.junit.Test;
+import org.openqa.selenium.By;
+import org.openqa.selenium.WebElement;
 
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
@@ -27,4 +30,14 @@ public class EmptyTabSheetTest extends MultiBrowserTest {
         compareScreen("empty");
     }
 
+    @Test
+    public void emptyTabSheetValo() {
+        openTestURL("theme=valo");
+
+        WebElement deco = getDriver().findElement(
+                By.className("v-tabsheet-deco"));
+
+        Assert.assertEquals("none", deco.getCssValue("display"));
+    }
+
 }