squid:UselessParenthesesCheck Useless parentheses around expressions should be remove...

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/GQuery.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/GQuery.java
index 06f72b0ea7909e17b94112b7d06ff884aca113ac..4d680690d8e7fa88b36c79267602da73ba574c1b 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/GQuery.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/GQuery.java
@@ -4744,7 +4744,7 @@ public class GQuery implements Lazy<GQuery, LazyGQuery> {
       } else if ("input".equalsIgnoreCase(name)) {
         InputElement ie = InputElement.as(e);
         String type = ie.getType();
-        if ("radio".equalsIgnoreCase((type)) || "checkbox".equalsIgnoreCase(type)) {
+        if ("radio".equalsIgnoreCase(type) || "checkbox".equalsIgnoreCase(type)) {
           ie.setChecked(false);
           for (String v : values) {
             if (ie.getValue().equals(v)) {

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/DocumentStyleImpl.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/DocumentStyleImpl.java
index 0a466a07f43f656efed674dfaa64c3f6dd0b46fb..f9e7323477ada1c389b8413f11267b86149ad556 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/DocumentStyleImpl.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/DocumentStyleImpl.java
@@ -63,11 +63,11 @@ public class DocumentStyleImpl {
     }
     String val = curCSS(elem, prop, force);
     if ("thick".equalsIgnoreCase(val)) {
-      return (5);
+      return 5;
     } else if ("medium".equalsIgnoreCase(val)) {
-      return (3);
+      return 3;
     } else if ("thin".equalsIgnoreCase(val)) {
-      return (1);
+      return 1;
     }
     if (!val.matches("^[\\d\\.]+.*$")) {
       val = curCSS(elem, prop, false);

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/research/SelectorEngineJS.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/research/SelectorEngineJS.java
index f517a43134f6b06b05d6025ef5b86da6e59c6d53..3536645a77e67f4c6e9091685d66b64a9294615b 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/research/SelectorEngineJS.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/impl/research/SelectorEngineJS.java
@@ -98,7 +98,7 @@ public class SelectorEngineJS extends SelectorEngineImpl {
       return null;
     } else {
       if (truth(pseudoValue.get(2))) { // odd or even
-        start = (eq(pseudoValue.get(2), "odd")) ? 1 : 2;
+        start = eq(pseudoValue.get(2), "odd") ? 1 : 2;
         modVal = (start == 1) ? 1 : 0;
       } else if (JsUtils
           .truth(pseudoValue.get(3))) { // single digit
@@ -214,7 +214,7 @@ public class SelectorEngineJS extends SelectorEngineImpl {
 
   private static void getGeneralSiblingNodes(JsNodeArray matchingElms,
       JsObjectArray<String> nextTag, JsRegexp nextRegExp, Node prevRef) {
-    while (JsUtils.truth((prevRef = SelectorEngine.getNextSibling(prevRef)))
+    while (JsUtils.truth(prevRef = SelectorEngine.getNextSibling(prevRef))
         && !isAdded(prevRef)) {
       if (!JsUtils.truth(nextTag) || nextRegExp
           .test(prevRef.getNodeName())) {
@@ -419,9 +419,9 @@ public class SelectorEngineJS extends SelectorEngineImpl {
                       ? attributeMatch.get(3).replaceAll("\\.", "\\.")
                       : null;
               String attrVal = attrToRegExp(attributeValue,
-                  (JsUtils.or(attributeMatch.get(2), null)));
-              regExpAttributes[q] = (JsUtils.truth(attrVal) ? new JsRegexp(
-                  attrVal) : null);
+                  JsUtils.or(attributeMatch.get(2), null));
+              regExpAttributes[q] = JsUtils.truth(attrVal) ? new JsRegexp(
+                  attrVal) : null;
               regExpAttributesStr[q] = attributeMatch.get(1);
             }
             JsNodeArray matchingAttributeElms = JsNodeArray.create();
@@ -594,11 +594,11 @@ public class SelectorEngineJS extends SelectorEngineImpl {
       previous = next = previousMatch.getElement(j);
       if (previousDir) {
         while (JsUtils
-            .truth((next = SelectorEngine.getPreviousSibling(next)))
+            .truth(next = SelectorEngine.getPreviousSibling(next))
             && next.getNodeType() != Node.ELEMENT_NODE) {
         }
       } else {
-        while (JsUtils.truth((next = SelectorEngine.getNextSibling(next)))
+        while (JsUtils.truth(next = SelectorEngine.getNextSibling(next))
             && next.getNodeType() != Node.ELEMENT_NODE) {
         }
       }

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/js/JsObjectArray.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/js/JsObjectArray.java
index bbbe5d084cf32425994b6b6b32d8aa43cc6435cd..594ee060c4e9580011b7eb9f38b6d19e84e2554c 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/js/JsObjectArray.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/js/JsObjectArray.java
@@ -38,7 +38,7 @@ public final class JsObjectArray<T> extends JavaScriptObject {
   public JsObjectArray<T> add(T... vals) {
     for (T t : vals) {
       if (t instanceof Number) {
-        c().putNumber(length(), (((Number) t).doubleValue()));
+        c().putNumber(length(), ((Number) t).doubleValue());
       } else if (t instanceof Boolean) {
         c().putBoolean(length(), (Boolean) t);
       } else {

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/MousePlugin.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/MousePlugin.java
index 2202bc7126741b7f578dfbce368b061d569365e2..bdedbfe413fac61af9cf4f6d1b74bf9c5f2949eb 100755 (executable)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/MousePlugin.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/MousePlugin.java
@@ -206,7 +206,7 @@ public abstract class MousePlugin extends UiPlugin {
     unbindOtherEvents();
     if (started) {
       started = false;
-      preventClickEvent = (event.getCurrentEventTarget() == startEvent.getCurrentEventTarget());
+      preventClickEvent = event.getCurrentEventTarget() == startEvent.getCurrentEventTarget();
       mouseStop(element, event);
     }
 

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/UiPlugin.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/UiPlugin.java
index 92938d1719971aec267a34fbf296ce690e1375e8..7b69482a31daa8403be366be7902499a8b93c6cb 100755 (executable)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/UiPlugin.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/UiPlugin.java
@@ -117,8 +117,8 @@ public class UiPlugin extends GQuery {
     @Override
     protected boolean scrollParentPositionTest(UiPlugin gQueryUi) {
       String position = gQueryUi.css("position", false);
-      return ("absolute".equals(position) || "relative".equals(position) || "static"
-          .equals(position));
+      return "absolute".equals(position) || "relative".equals(position) || "static"
+          .equals(position);
     }
   }
 

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
index 6794d1c16b9017762480baa958e8f5e63d6244e3..378cb745a67139a7e329f94afdd9ba3b5d466a9f 100755 (executable)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
@@ -134,7 +134,7 @@ public class ClipAnimation extends PropertiesAnimation {
       return;
     }
     if (currentAction == Action.HIDE) {
-      progress = (1 - progress);
+      progress = 1 - progress;
     }
     int w = g.outerWidth();
     int h = g.outerHeight();
@@ -154,11 +154,11 @@ public class ClipAnimation extends PropertiesAnimation {
       left = (w - right) / 2;
     }
     if (corner == Corner.TOP_RIGHT || corner == Corner.BOTTOM_RIGHT) {
-      left = (w - right);
+      left = w - right;
       right = w;
     }
     if (corner == Corner.BOTTOM_LEFT || corner == Corner.BOTTOM_RIGHT) {
-      top = (h - bottom);
+      top = h - bottom;
       bottom = h;
     }
 

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
index 1e202e33f031e8b77bacc6e773770c7b9d66941a..508b0b15266816ecf9261c129e7dcdabe2f47d0a 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
@@ -268,7 +268,7 @@ public class Fx {
   }
 
   public void applyValue(GQuery g, double progress) {
-    double ret = (start + ((end - start) * progress));
+    double ret = start + ((end - start) * progress);
     String val = ("px".equals(unit) ? ((int) ret) : ret) + unit;
     if ("scrollTop".equals(cssprop)) {
       g.scrollTop((int) ret);

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsniBundleGenerator.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsniBundleGenerator.java
index eb1511e4f7a4d7b516957ea7af00ce8dbf51f930..d7c8112dc6876beaf405e6d703edc400c91c944b 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsniBundleGenerator.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsniBundleGenerator.java
@@ -251,11 +251,11 @@ public class JsniBundleGenerator extends Generator {
           if (isJS)
             out = "\n";
         } else if (isCComment) {
-          isSlash = isCComment = !(isJS = (last == '*' && c == '/'));
+          isSlash = isCComment = !(isJS = last == '*' && c == '/');
           if (isJS)
             out = "";
         } else if (isRegex) {
-          isJS = !(isSlash = isRegex = (last == '\\' || c != '/'));
+          isJS = !(isSlash = isRegex = last == '\\' || c != '/');
           if (isJS) {
             String mod = "";
             while (++i < l) {

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java
index 3b36f293669f0b4337d2c6f2f3124b5aadb3e89c..b315151c2fe259ae93c30b44c39aaa89b1726065 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java
@@ -298,7 +298,7 @@ public class JsonBuilderGenerator extends Generator {
 
   public boolean isTypeAssignableTo(JType t, JClassType o) {
     JClassType c = t.isClassOrInterface();
-    return (c != null && c.isAssignableTo(o));
+    return c != null && c.isAssignableTo(o);
   }
 
   private void generateCreateMethod(SourceWriter sw, TreeLogger logger) {

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/SelectorGeneratorXPath.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/SelectorGeneratorXPath.java
index fc88d80402a0a48617e2233f10ed03808509196b..11473cfd8743ea54f847da8f9962ecd7e00bab05 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/SelectorGeneratorXPath.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/SelectorGeneratorXPath.java
@@ -238,7 +238,7 @@ public class SelectorGeneratorXPath extends SelectorGeneratorBase {
       return null;
     } else {
       if (notNull(pseudoValue.group(2))) { // odd or even
-        start = ("odd".equals(pseudoValue.group(2))) ? 1 : 2;
+        start = "odd".equals(pseudoValue.group(2)) ? 1 : 2;
         modVal = (start == 1) ? 1 : 0;
       } else if (notNull(pseudoValue.group(3))) { // single digit
         start = Integer.parseInt(pseudoValue.group(3), 10);
@@ -287,8 +287,8 @@ public class SelectorGeneratorXPath extends SelectorGeneratorBase {
     } else if ("nth".equals(pseudo[0])) {
       if (!pseudoValue.matches("^n$")) {
         String position =
-            (("last".equals(pseudo[1])) ? "(count(following-sibling::"
-                : "(count(preceding-sibling::") + tag + ") + 1)";
+            "last".equals(pseudo[1]) ? "(count(following-sibling::"
+                : "(count(preceding-sibling::" + tag + ") + 1)";
         Sequence sequence = getSequence(pseudoValue);
         if (sequence != null) {
           if (sequence.start == sequence.max) {

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java
index d68af8173236d5df0f19dff8090e78ebd55874ac..1466360c3038e55cb53e949f77d5c99ee32d25d2 100644 (file)
--- a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java
@@ -76,7 +76,7 @@ public class XmlBuilderGenerator extends Generator {
 
   public boolean isTypeAssignableTo(JType t, JClassType o) {
     JClassType c = t.isClassOrInterface();
-    return (c != null && c.isAssignableTo(o));
+    return c != null && c.isAssignableTo(o);
   }
 
   public void generateMethod(SourceWriter sw, JMethod method, TreeLogger logger)