]> source.dussan.org Git - nextcloud-server.git/commitdiff
fix(core): Do not invert app menu text color
authorFerdinand Thiessen <opensource@fthiessen.de>
Wed, 3 May 2023 10:58:07 +0000 (12:58 +0200)
committerJonas <jonas@freesources.org>
Mon, 19 Jun 2023 07:49:36 +0000 (09:49 +0200)
* Also fixes other cypress test
* Build assets

Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
core/src/components/AppMenu.vue
cypress/e2e/theming/admin-settings.cy.ts
cypress/e2e/theming/user-background.cy.ts

index b7b5b8bd4562ab77371ff1f91ad3a9e3ccfb7ced..6f65f185a4dab9b8f4c2aa8d6170a21b7526f09e 100644 (file)
@@ -146,7 +146,6 @@ $header-icon-size: 20px;
                height: 50px;
                position: relative;
                display: flex;
-               filter: var(--background-image-invert-if-bright);
 
                &.app-menu-entry__active {
                        opacity: 1;
@@ -187,6 +186,7 @@ $header-icon-size: 20px;
                        height: $header-icon-size;
                        padding: calc((100% - $header-icon-size) / 2);
                        box-sizing: content-box;
+                       filter: var(--background-image-invert-if-bright);
                }
 
                .app-menu-entry--label {
index 4736ace9e4d6fc571080666d33c5ff24df084879..63242d64f1bd6ae23eb325cbc61f2aad621143fa 100644 (file)
@@ -167,7 +167,7 @@ describe.only('Remove the default background with a bright color', function() {
 
        it('See the header being inverted', function() {
                cy.waitUntil(() => cy.window().then((win) => {
-                       const firstEntry = win.document.querySelector('.app-menu-main li')
+                       const firstEntry = win.document.querySelector('.app-menu-main li img')
                        if (!firstEntry) {
                                return false
                        }
index 86b66627ee63fe8edae0b0bde675bc8b3c3b73a6..92617b33b59853216052bc6fffe8f16baae495ed 100644 (file)
@@ -162,7 +162,7 @@ describe('User select a bright custom color and remove background', function() {
 
        it('See the header being inverted', function() {
                cy.waitUntil(() => cy.window().then((win) => {
-                       const firstEntry = win.document.querySelector('.app-menu-main li')
+                       const firstEntry = win.document.querySelector('.app-menu-main li img')
                        if (!firstEntry) {
                                return false
                        }