Fix invalid struct tags and remove unreachable code.

diff --git a/modules/auth/repo_form.go b/modules/auth/repo_form.go
index a6c71e99eaa773d5cda01e3ca28633abf05d13c7..1b1a4f71203d0a956ed72ef526389f68a2347674 100644 (file)
--- a/modules/auth/repo_form.go
+++ b/modules/auth/repo_form.go
@@ -71,7 +71,7 @@ func (f *RepoSettingForm) Validate(ctx *macaron.Context, errs *binding.Errors, l
 type NewWebhookForm struct {
        Url         string `form:"url" binding:"Required;Url"`
        ContentType string `form:"content_type" binding:"Required"`
-       Secret      string `form:"secret""`
+       Secret      string `form:"secret"`
        PushOnly    bool   `form:"push_only"`
        Active      bool   `form:"active"`
 }

diff --git a/modules/log/file.go b/modules/log/file.go
index cce53529696ef42c616843cc4a459cde76fb9356..52a2f68c73ad1e0ba94f26ecb15bfa57e1dedeb4 100644 (file)
--- a/modules/log/file.go
+++ b/modules/log/file.go
@@ -34,7 +34,7 @@ type FileLogWriter struct {
 
        // Rotate daily
        Daily          bool  `json:"daily"`
-       Maxdays        int64 `json:"maxdays`
+       Maxdays        int64 `json:"maxdays"`
        daily_opendate int
 
        Rotate bool `json:"rotate"`

diff --git a/modules/social/social.go b/modules/social/social.go
index 326a463fac84af318416f3beaebe4f1666ce4a6f..f4d859882084640bda9232d7d9011964af10849d 100644 (file)
--- a/modules/social/social.go
+++ b/modules/social/social.go
@@ -391,5 +391,4 @@ func (s *SocialWeibo) UserInfo(token *oauth.Token, _ *url.URL) (*BasicUserInfo,
                Identity: token.Extra["id_token"],
                Name:     data.Name,
        }, nil
-       return nil, nil
 }