SONAR-21692 Remove warnings from design-system

diff --git a/server/sonar-web/design-system/src/components/__tests__/FavoriteButton-test.tsx b/server/sonar-web/design-system/src/components/__tests__/FavoriteButton-test.tsx
index 819ebbe8e1839411b66e1f1f7b794c4132974e47..c2ac6fe2403599b1f60f2fe1354687b6c75b284f 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/FavoriteButton-test.tsx
+++ b/server/sonar-web/design-system/src/components/__tests__/FavoriteButton-test.tsx
@@ -22,6 +22,7 @@ import userEvent from '@testing-library/user-event';
 import { render } from '../../helpers/testUtils';
 import { FCProps } from '../../types/misc';
 import { FavoriteButton } from '../FavoriteButton';
+import { Tooltip } from '../Tooltip';
 
 it('should render favorite filled', () => {
   const { container } = renderFavoriteButton({ favorite: true });
@@ -44,6 +45,12 @@ it('should toggle favorite', async () => {
 
 function renderFavoriteButton(props: Partial<FCProps<typeof FavoriteButton>> = {}) {
   return render(
-    <FavoriteButton favorite overlay="label-info" toggleFavorite={jest.fn()} {...props} />,
+    <FavoriteButton
+      favorite
+      overlay="label-info"
+      toggleFavorite={jest.fn()}
+      tooltip={Tooltip}
+      {...props}
+    />,
   );
 }

diff --git a/server/sonar-web/design-system/src/components/__tests__/LineCoverage-test.tsx b/server/sonar-web/design-system/src/components/__tests__/LineCoverage-test.tsx
index 3c47dfe0dc6126c1ffe6e6b59f979ca030e5797a..f383723283b2ea684b7c7d15a3e9c8ca568e0831 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/LineCoverage-test.tsx
+++ b/server/sonar-web/design-system/src/components/__tests__/LineCoverage-test.tsx
@@ -54,5 +54,7 @@ it('should render correctly when no data', () => {
 });
 
 function setupWithProps(props: Partial<FCProps<typeof LineCoverage>> = {}) {
-  return render(<LineCoverage coverageStatus="covered" lineNumber={16} status="OK" {...props} />);
+  return render(<LineCoverage coverageStatus="covered" lineNumber={16} status="OK" {...props} />, {
+    container: document.createElement('tr'),
+  });
 }

diff --git a/server/sonar-web/design-system/src/components/__tests__/LineNumber-test.tsx b/server/sonar-web/design-system/src/components/__tests__/LineNumber-test.tsx
index e656dd7a365e5bf0e1d7a9a7cb2ed4050de5e8dc..e72494cdd7ffe5bb7fc437c677860bcf49eb650b 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/LineNumber-test.tsx
+++ b/server/sonar-web/design-system/src/components/__tests__/LineNumber-test.tsx
@@ -33,13 +33,19 @@ it('should a popup when clicked', async () => {
 
 function setupWithProps(props: Partial<FCProps<typeof LineNumber>> = {}) {
   return render(
-    <LineNumber
-      ariaLabel="aria-label"
-      displayOptions
-      firstLineNumber={1}
-      lineNumber={16}
-      popup={<div>Popup</div>}
-      {...props}
-    />,
+    <table>
+      <tbody>
+        <tr>
+          <LineNumber
+            ariaLabel="aria-label"
+            displayOptions
+            firstLineNumber={1}
+            lineNumber={16}
+            popup={<div>Popup</div>}
+            {...props}
+          />
+        </tr>
+      </tbody>
+    </table>,
   );
 }

diff --git a/server/sonar-web/design-system/src/components/__tests__/LineWrapper-test.tsx b/server/sonar-web/design-system/src/components/__tests__/LineWrapper-test.tsx
index f7128ff309fe97e10d3c30262bbfd92ecef0a8c0..03bb657177e1adf6f924632303768006f279b41f 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/LineWrapper-test.tsx
+++ b/server/sonar-web/design-system/src/components/__tests__/LineWrapper-test.tsx
@@ -46,5 +46,6 @@ it('should set a highlighted background color in css props', () => {
 function setupWithProps(props: Partial<FCProps<typeof LineWrapper>> = {}) {
   return render(
     <LineWrapper displayCoverage displaySCM duplicationsCount={2} highlighted={false} {...props} />,
+    { container: document.createElement('tbody') },
   );
 }

diff --git a/server/sonar-web/design-system/src/components/__tests__/Tags-test.tsx b/server/sonar-web/design-system/src/components/__tests__/Tags-test.tsx
index c16f54d4dd0f30e8d49646b6ee0e1f983965ab0d..7683e281bc8405f191716204fa776d2d237549ab 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/Tags-test.tsx
+++ b/server/sonar-web/design-system/src/components/__tests__/Tags-test.tsx
@@ -26,6 +26,7 @@ import { renderWithContext } from '../../helpers/testUtils';
 import { FCProps } from '../../types/misc';
 import { MultiSelector } from '../MultiSelector';
 import { Tags } from '../Tags';
+import { Tooltip } from '../Tooltip';
 
 it('should display "no tags"', () => {
   renderTags({ tags: [] });
@@ -108,6 +109,7 @@ function Wrapper(overrides: Partial<FCProps<typeof Tags>> = {}) {
       emptyText="no tags"
       overlay={overlay}
       tags={selectedTags}
+      tooltip={Tooltip}
       {...overrides}
     />
   );

diff --git a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/FavoriteButton-test.tsx.snap b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/FavoriteButton-test.tsx.snap
index 065987cb84ac15d4f609c26155b56543aa76c210..26d17a1a8d0e9fb5f1303a7f09d4dc6de9aa79ed 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/FavoriteButton-test.tsx.snap
+++ b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/FavoriteButton-test.tsx.snap
@@ -60,6 +60,7 @@ exports[`should render favorite empty 1`] = `
 
 <div>
   <button
+    aria-describedby="tooltip-2"
     aria-label="label-info"
     class="it__favorite-link it__is-filled emotion-0 emotion-1 emotion-2"
     type="button"
@@ -143,6 +144,7 @@ exports[`should render favorite filled 1`] = `
 
 <div>
   <button
+    aria-describedby="tooltip-1"
     aria-label="label-info"
     class="it__favorite-link it__is-filled emotion-0 emotion-1 emotion-2"
     type="button"

diff --git a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineCoverage-test.tsx.snap b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineCoverage-test.tsx.snap
index 88462699f2fe74b617db7f193c94257e8f35246d..5423d1645fff5492e0d6cb4436fa84f349130c99 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineCoverage-test.tsx.snap
+++ b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineCoverage-test.tsx.snap
@@ -30,7 +30,7 @@ exports[`should render correctly when covered 1`] = `
   outline: none;
 }
 
-<div>
+<tr>
   <td
     aria-describedby="tooltip-1"
     class="emotion-0 emotion-1"
@@ -41,7 +41,7 @@ exports[`should render correctly when covered 1`] = `
       class="emotion-2 emotion-3"
     />
   </td>
-</div>
+</tr>
 `;
 
 exports[`should render correctly when no data 1`] = `
@@ -62,12 +62,12 @@ exports[`should render correctly when no data 1`] = `
   background-color: rgb(239,242,249);
 }
 
-<div>
+<tr>
   <td
     class="emotion-0 emotion-1"
     data-line-number="16"
   />
-</div>
+</tr>
 `;
 
 exports[`should render correctly when partially covered with 5/10 conditions 1`] = `
@@ -99,7 +99,7 @@ exports[`should render correctly when partially covered with 5/10 conditions 1`]
   outline: none;
 }
 
-<div>
+<tr>
   <td
     aria-describedby="tooltip-4"
     class="emotion-0 emotion-1"
@@ -128,7 +128,7 @@ exports[`should render correctly when partially covered with 5/10 conditions 1`]
       </svg>
     </div>
   </td>
-</div>
+</tr>
 `;
 
 exports[`should render correctly when partially covered without conditions 1`] = `
@@ -160,7 +160,7 @@ exports[`should render correctly when partially covered without conditions 1`] =
   outline: none;
 }
 
-<div>
+<tr>
   <td
     aria-describedby="tooltip-3"
     class="emotion-0 emotion-1"
@@ -189,7 +189,7 @@ exports[`should render correctly when partially covered without conditions 1`] =
       </svg>
     </div>
   </td>
-</div>
+</tr>
 `;
 
 exports[`should render correctly when uncovered 1`] = `
@@ -222,7 +222,7 @@ exports[`should render correctly when uncovered 1`] = `
   outline: none;
 }
 
-<div>
+<tr>
   <td
     aria-describedby="tooltip-2"
     class="emotion-0 emotion-1"
@@ -233,5 +233,5 @@ exports[`should render correctly when uncovered 1`] = `
       class="emotion-2 emotion-3"
     />
   </td>
-</div>
+</tr>
 `;

diff --git a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineWrapper-test.tsx.snap b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineWrapper-test.tsx.snap
index 2bbcd9fed073323f3602012fa741d7fcf8d97a6a..ca308966a94755fd6c51b11e42a328bc2f76c3f8 100644 (file)
--- a/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineWrapper-test.tsx.snap
+++ b/server/sonar-web/design-system/src/components/__tests__/__snapshots__/LineWrapper-test.tsx.snap
@@ -15,10 +15,10 @@ exports[`should render with correct styling 1`] = `
   font-weight: 400;
 }
 
-<div>
+<tbody>
   <tr
     class="emotion-0 emotion-1"
     style="--columns: 44px 50px 26px repeat(3, 6px) 1fr; --line-background: rgb(255,255,255);"
   />
-</div>
+</tbody>
 `;