Use start_with? or end_with? to check the first or last character of a string (#37591).

Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@21774 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/lib/redmine/diff_table.rb b/lib/redmine/diff_table.rb
index 2976d22283af5ac1660e9033662e41630c67519f..ca8c4b9d2b1d8de199dd3287584f0164441236e1 100644 (file)
--- a/lib/redmine/diff_table.rb
+++ b/lib/redmine/diff_table.rb
@@ -118,7 +118,7 @@ module Redmine
     end
 
     def parse_line(line, type="inline")
-      if line[0, 1] == "+"
+      if line.start_with?('+')
         diff = diff_for_added_line
         diff.line_right = line[1..-1]
         diff.nb_line_right = @line_num_r
@@ -126,7 +126,7 @@ module Redmine
         @line_num_r += 1
         @added += 1
         true
-      elsif line[0, 1] == "-"
+      elsif line.start_with?('-')
         diff = Diff.new
         diff.line_left = line[1..-1]
         diff.nb_line_left = @line_num_l
@@ -137,7 +137,7 @@ module Redmine
         true
       else
         write_offsets
-        if /\s/.match?(line[0, 1])
+        if line.start_with?(/\s/)
           diff = Diff.new
           diff.line_right = line[1..-1]
           diff.nb_line_right = @line_num_r

diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index e586a2a0acb076b40a186bd81f2ed6e770f132f7..cdf8eca3c51c7a8e200360bb40a3315029434933 100644 (file)
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -120,7 +120,7 @@ module Redmine
         end
 
         def get_sever_url(url)
-          if !empty_string(url) and (url[0, 1] == '/')
+          if !empty_string(url) and url.start_with?('/')
             Setting.host_name.split('/')[0] + url
           else
             url

diff --git a/lib/redmine/scm/adapters/abstract_adapter.rb b/lib/redmine/scm/adapters/abstract_adapter.rb
index 5d92bb2d7efa306ad83844b027e90da0c8532174..0ad3d7f45a024bf5eb19e0e93b7aabace615a764 100644 (file)
--- a/lib/redmine/scm/adapters/abstract_adapter.rb
+++ b/lib/redmine/scm/adapters/abstract_adapter.rb
@@ -158,12 +158,12 @@ module Redmine
 
         def with_leading_slash(path)
           path ||= ''
-          (path[0, 1]!="/") ? "/#{path}" : path
+          path.start_with?('/') ? path : "/#{path}"
         end
 
         def with_trailling_slash(path)
           path ||= ''
-          (path[-1, 1] == "/") ? path : "#{path}/"
+          path.end_with?('/') ? path : "#{path}/"
         end
 
         def without_leading_slash(path)
@@ -173,7 +173,7 @@ module Redmine
 
         def without_trailling_slash(path)
           path ||= ''
-          (path[-1, 1] == "/") ? path[0..-2] : path
+          path.end_with?('/') ? path[0..-2] : path
         end
 
         def valid_name?(name)