SONAR-5362 Do not fail if not all parameters are set

diff --git a/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdate.java b/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdate.java
index ad0eccdee74fb3b6e3af14ffa52cee70ceed12c3..cf6bddc1d2af446db13b611a1333186cef8b2291 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdate.java
+++ b/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdate.java
@@ -111,6 +111,7 @@ public class RuleUpdate {
     return this;
   }
 
+  @CheckForNull
   public String getName() {
     return name;
   }
@@ -122,6 +123,7 @@ public class RuleUpdate {
     return this;
   }
 
+  @CheckForNull
   public String getHtmlDescription() {
     return htmlDescription;
   }
@@ -133,28 +135,33 @@ public class RuleUpdate {
     return this;
   }
 
+  @CheckForNull
   public String getSeverity() {
     return severity;
   }
 
-  public RuleUpdate setSeverity(String severity) {
+  public RuleUpdate setSeverity(@Nullable String severity) {
     checkCustomRule();
     this.severity = severity;
     this.changeSeverity = true;
     return this;
   }
 
+  @CheckForNull
   public RuleStatus getStatus() {
     return status;
   }
 
-  public RuleUpdate setStatus(RuleStatus status) {
+  public RuleUpdate setStatus(@Nullable RuleStatus status) {
     checkCustomRule();
     this.status = status;
     this.changeStatus = true;
     return this;
   }
 
+  /**
+   * Parameters to be updated (only for custom rules)
+   */
   public RuleUpdate setParameters(Map<String, String> params) {
     checkCustomRule();
     this.parameters.clear();

diff --git a/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java b/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
index 27a393a4402070dcabd98b70283dbd4bb8cae3f3..80dac2aa2e8f32a38a749ab08314c5da1ad04f73 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
+++ b/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
@@ -177,12 +177,9 @@ public class RuleUpdater implements ServerComponent {
   }
 
   private void updateParameters(RuleUpdate update, Context context) {
-    // All parameters have to be updated
     for (RuleParamDto ruleParamDto : context.parameters) {
       String value = update.parameter(ruleParamDto.getName());
-      if (Strings.isNullOrEmpty(value)) {
-        throw new IllegalArgumentException(String.format("The parameter '%s' has not been set", ruleParamDto.getName()));
-      } else {
+      if (!Strings.isNullOrEmpty(value)) {
         ruleParamDto.setDefaultValue(value);
       }
     }