Fix Quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/component/ws/AppAction.java b/server/sonar-server/src/main/java/org/sonar/server/component/ws/AppAction.java
index 551718ed9af92afdfa5fe6bec05e9de308aa6c63..27dd6d5a5e4b343e2b9221aa5698e875b5e147d9 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/component/ws/AppAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/component/ws/AppAction.java
@@ -178,7 +178,7 @@ public class AppAction implements RequestHandler {
   }
 
   @CheckForNull
-  private String formatCoverageMeasure(Map<String, MeasureDto> measuresByMetricKey) {
+  private static String formatCoverageMeasure(Map<String, MeasureDto> measuresByMetricKey) {
     MeasureDto overallCoverage = measuresByMetricKey.get(CoreMetrics.OVERALL_COVERAGE_KEY);
     if (overallCoverage != null) {
       return formatMeasure(overallCoverage, CoreMetrics.OVERALL_COVERAGE);

diff --git a/server/sonar-server/src/main/java/org/sonar/server/search/ws/BaseMapping.java b/server/sonar-server/src/main/java/org/sonar/server/search/ws/BaseMapping.java
index d613edf34696bf4e138c8528535a5ec05ff7de12..db221363f5df49be083993ae91dd2670c8f2ca6c 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/search/ws/BaseMapping.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/search/ws/BaseMapping.java
@@ -90,6 +90,7 @@ public abstract class BaseMapping<DOC extends BaseDoc, CTX> {
     return this;
   }
 
+  @FunctionalInterface
   public interface Mapper<DOC extends BaseDoc, CTX> {
     void write(JsonWriter json, DOC doc, CTX context);
   }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/command/CommandExecutor.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/command/CommandExecutor.java
index 79ff15faf90c0787eb0bc914d13b1c821079e286..b546b2aca9b82f3ff72234832b1ff3f15b72d6af 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/command/CommandExecutor.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/command/CommandExecutor.java
@@ -24,6 +24,7 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
+import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
@@ -79,7 +80,7 @@ public class CommandExecutor {
 
       final Process finalProcess = process;
       executorService = Executors.newSingleThreadExecutor();
-      Future<Integer> ft = executorService.submit(() -> finalProcess.waitFor());
+      Future<Integer> ft = executorService.submit((Callable<Integer>) finalProcess::waitFor);
       int exitCode;
       if (timeoutMilliseconds < 0) {
         exitCode = ft.get();