]> source.dussan.org Git - vaadin-framework.git/commitdiff
Remove deprecated usage of ApplicationConnection.hasEventListeners() (#10248)
authorAhmed Ashour <asashour@yahoo.com>
Tue, 7 Nov 2017 11:47:09 +0000 (12:47 +0100)
committerPekka Maanpää <pekkamaa@vaadin.com>
Tue, 7 Nov 2017 11:47:09 +0000 (13:47 +0200)
From VDateField and VWindow

client/src/main/java/com/vaadin/client/ui/VAbstractTextualDate.java
client/src/main/java/com/vaadin/client/ui/VDateField.java
client/src/main/java/com/vaadin/client/ui/VWindow.java
client/src/main/java/com/vaadin/client/ui/datefield/AbstractDateFieldConnector.java
client/src/main/java/com/vaadin/client/ui/window/WindowConnector.java

index 6525180903593d4df827209fca6063690c64b5ae..340e4faf6a393a196bb5487fb62c51c9af890b84 100644 (file)
@@ -402,8 +402,7 @@ public abstract class VAbstractTextualDate<R extends Enum<R>>
         } else {
             text.removeStyleName(styleName);
         }
-        if (getClient() != null && getClient()
-                .hasEventListeners(VAbstractTextualDate.this, eventId)) {
+        if (getClient() != null && connector.hasEventListener(eventId)) {
             // may excessively send events if if focus went to another
             // sub-component
             if (EventId.FOCUS.equals(eventId)) {
index be56fd99ee8f5dd1b013a7800f26c4861a5a247f..3bfa8e9649c415a4bc38ca5f704c41b1a05af662 100644 (file)
@@ -27,6 +27,7 @@ import com.google.gwt.user.client.ui.FlowPanel;
 import com.google.gwt.user.client.ui.HasEnabled;
 import com.vaadin.client.ApplicationConnection;
 import com.vaadin.client.DateTimeService;
+import com.vaadin.client.ui.datefield.AbstractDateFieldConnector;
 import com.vaadin.shared.ui.datefield.AbstractDateFieldServerRpc;
 
 /**
@@ -43,10 +44,10 @@ public abstract class VDateField<R extends Enum<R>> extends FlowPanel
     public static final String CLASSNAME = "v-datefield";
 
     /** For internal use only. May be removed or replaced in the future. */
-    public String paintableId;
+    public ApplicationConnection client;
 
     /** For internal use only. May be removed or replaced in the future. */
-    public ApplicationConnection client;
+    public AbstractDateFieldConnector<R> connector;
 
     private R currentResolution;
 
@@ -200,7 +201,7 @@ public abstract class VDateField<R extends Enum<R>> extends FlowPanel
     }
 
     public String getId() {
-        return paintableId;
+        return connector.getConnectorId();
     }
 
     public ApplicationConnection getClient() {
index e53997ec172190da415ba2e6b3fde76e675c79fb..02d3ce63cd05d1e72360bffb3750da9c35f85f99 100644 (file)
@@ -59,6 +59,7 @@ import com.vaadin.client.WidgetUtil;
 import com.vaadin.client.debug.internal.VDebugWindow;
 import com.vaadin.client.ui.ShortcutActionHandler.ShortcutActionHandlerOwner;
 import com.vaadin.client.ui.aria.AriaHelper;
+import com.vaadin.client.ui.window.WindowConnector;
 import com.vaadin.client.ui.window.WindowMoveEvent;
 import com.vaadin.client.ui.window.WindowMoveHandler;
 import com.vaadin.client.ui.window.WindowOrderEvent;
@@ -130,6 +131,9 @@ public class VWindow extends VOverlay implements ShortcutActionHandlerOwner,
     /** For internal use only. May be removed or replaced in the future. */
     public ApplicationConnection client;
 
+    /** For internal use only. May be removed or replaced in the future. */
+    public WindowConnector connector;
+
     /** For internal use only. May be removed or replaced in the future. */
     public String id;
 
@@ -1351,14 +1355,14 @@ public class VWindow extends VOverlay implements ShortcutActionHandlerOwner,
 
     @Override
     public void onBlur(BlurEvent event) {
-        if (client.hasEventListeners(this, EventId.BLUR)) {
+        if (connector.hasEventListener(EventId.BLUR)) {
             client.updateVariable(id, EventId.BLUR, "", true);
         }
     }
 
     @Override
     public void onFocus(FocusEvent event) {
-        if (client.hasEventListeners(this, EventId.FOCUS)) {
+        if (connector.hasEventListener(EventId.FOCUS)) {
             client.updateVariable(id, EventId.FOCUS, "", true);
         }
     }
index fb060ad326f37ef780b77caaf72d58d81b9373dd..b31447fcacc28b875d08ccbbdd60e4b804aa992a 100644 (file)
@@ -96,7 +96,7 @@ public abstract class AbstractDateFieldConnector<R extends Enum<R>>
 
         // Save details
         widget.client = getConnection();
-        widget.paintableId = getConnectorId();
+        widget.connector = this;
 
         widget.setReadonly(isReadOnly());
         widget.setEnabled(isEnabled());
index fb1bba418209046ac6b34717863399e47cf1f58d..1de571592afcb063eec648835f7067bc01f7a617 100644 (file)
@@ -105,6 +105,7 @@ public class WindowConnector extends AbstractSingleComponentContainerConnector
         VWindow window = getWidget();
         window.id = getConnectorId();
         window.client = getConnection();
+        window.connector = this;
 
         getLayoutManager().registerDependency(this,
                 window.contentPanel.getElement());