ComboBox newItemsAllowed=false by default, to avoid mistakes (#1374)

May affect applications! Must be prominently noted in changes -file.

svn changeset:3691/svn branch:trunk

diff --git a/src/com/itmill/toolkit/ui/ComboBox.java b/src/com/itmill/toolkit/ui/ComboBox.java
index 3f3bd67bced99735d78ceeade2e7b48c3281f0ab..0125af1d0fc3beac1c5c533ef4fc97630a5162d1 100644 (file)
--- a/src/com/itmill/toolkit/ui/ComboBox.java
+++ b/src/com/itmill/toolkit/ui/ComboBox.java
@@ -9,34 +9,35 @@ import java.util.Collection;
 import com.itmill.toolkit.data.Container;\r
 \r
 /**\r
- * A filtering dropdown single-select with newItemsAllowed. Items are filtered\r
- * based on user input, and loaded dynamically ("lazy-loading") from the server.\r
- * You can turn off newItemsAllowed and change filtering mode (and also turn it\r
- * off), but you can not turn on multi-select mode.\r
+ * A filtering dropdown single-select. Suitable for newItemsAllowed, but it's\r
+ * turned of by default to avoid mistakes. Items are filtered based on user\r
+ * input, and loaded dynamically ("lazy-loading") from the server. You can turn\r
+ * on newItemsAllowed and change filtering mode (and also turn it off), but you\r
+ * can not turn on multi-select mode.\r
  * \r
  */\r
 public class ComboBox extends Select {\r
     public ComboBox() {\r
         setMultiSelect(false);\r
-        setNewItemsAllowed(true);\r
+        setNewItemsAllowed(false);\r
     }\r
 \r
     public ComboBox(String caption, Collection options) {\r
         super(caption, options);\r
         setMultiSelect(false);\r
-        setNewItemsAllowed(true);\r
+        setNewItemsAllowed(false);\r
     }\r
 \r
     public ComboBox(String caption, Container dataSource) {\r
         super(caption, dataSource);\r
         setMultiSelect(false);\r
-        setNewItemsAllowed(true);\r
+        setNewItemsAllowed(false);\r
     }\r
 \r
     public ComboBox(String caption) {\r
         super(caption);\r
         setMultiSelect(false);\r
-        setNewItemsAllowed(true);\r
+        setNewItemsAllowed(false);\r
     }\r
 \r
     public void setMultiSelect(boolean multiSelect) {\r