some more notes

git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@412324 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
index fabe952bdd22a7ff483350370eb2391b8495ab05..54def2bfba31e448c6884b28d52f2358feee9641 100644 (file)
--- a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
+++ b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
@@ -47,7 +47,9 @@ import java.util.Map;
 import java.util.StringTokenizer;\r
 \r
 /**\r
- * Implementation Class for searching through the index\r
+ * Implementation Class for searching through the index.\r
+ *\r
+ * @todo this is not a component, but extends ALE, meaning logging will throw an exception! -- should be a component\r
  */\r
 public class DefaultRepositoryIndexSearcher\r
     extends AbstractLogEnabled\r

diff --git a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
index 8d38b715a02cca6724a13f6a3f16828745ff3227..7c2af3ec0f048708853b1414fb898f0750c195c7 100644 (file)
--- a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
+++ b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
@@ -23,6 +23,7 @@ import org.apache.maven.repository.digest.Digester;
 /**
  * @author Edwin Punzalan
  * @plexus.component role="org.apache.maven.repository.indexing.RepositoryIndexingFactory"
+ * @todo these methods should be replaced by plexus lookups of some kind!
  */
 public class DefaultRepositoryIndexingFactory
     implements RepositoryIndexingFactory

diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
index 08812b4de89d66e9bf79cd53ec71b01502eef09d..ddac61885548a9b120fa57ed462a3f5fefb66674 100644 (file)
--- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
+++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
@@ -53,6 +53,7 @@ import java.util.Map;
  * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
  * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary?
  * @todo this isn't reusing the parts of wagon manager than handle snapshots [!]
+ * @todo currently, cache must be in the same layout as the request, which prohibits any mapping
  */
 public class DefaultProxyManager
     extends AbstractLogEnabled

diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
index 8e336b1c0e888c9c796a2b2c95f9b715baa688f2..3fb52cc057837dea2dd948b2508ce9617783a566 100644 (file)
--- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
+++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
@@ -122,7 +122,10 @@ public class MavenProxyPropertyLoader
         return config;
     }
 
-    private void validateRemoteRepo( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateRemoteRepo( ProxyConfiguration configuration )
         throws ValidationException
     {
         //Verify remote repository set
@@ -171,7 +174,10 @@ public class MavenProxyPropertyLoader
         return value;
     }
 
-    private void validateDirectories( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateDirectories( ProxyConfiguration configuration )
         throws ValidationException
     {
         File f = new File( configuration.getRepositoryCachePath() );